When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom32() generate the number of UINT32_MAX.
And no packet need be sampled when the probability is 0.
Signed-off-by: Wenyu Zhang
---
datapath/actions.c |4 +++-
1 file changed, 3 insertio
So ideally this will be fixed in a future release of DPDK. We have flagged
this. However that solution will not be in place until the DPDK 2.2 release in
December at the earliest (DPDK 2.1 is currently in release candidate mode at
the moment so it won't make it to that). When this has been chang
Hi,
I want to implement and contribute Egress Tables [EXT-306], Openflow 1.5
feature to OpenVSwitch.
If anybody has already started working on it then please let us know.
Thanks and Regards,
Saloni Jain
Tata Consultancy Services
Mailto: saloni.j...@tcs.com
Website: http://www.tcs.com
__
Hi,
I'm looking for an external Layer2 Device integration within the OpenStack.
This Layer2 device can have only 2 physical cable 1 for input and 1 for
output to enable a network interception and then blocking the traffic based
on the analysis.
The whole of the OpenStack setup is comprised of 3
In multiqueue mode several pmd threads may process one
port, but different queues. Flow doesn't depend on queue.
So, while miss upcall processing, all threads (except first
for that port) will receive error = ENOSPC due to
ukey_install failure. Therefore they will not add the flow
to flow_table an
This patch fixes just the Python 3 problems found by running
python3 setup.py install
There are still many other issues to be fixed, but this is a start.
Signed-off-by: Terry Wilson
---
python/ovs/daemon.py | 31 ---
python/ovs/db/idl.py | 10 +
hi Sorin,
OvsInitExternalNBLContext() is called from OvsStartNBLIngress() which is the
function that hooks into NDIS to get hold of packets in the ingress path.
Typically these are packets that are generated by VMs, or it could be generated
by an layered driver above OVS.
Under what conditions
I know this is already checked in, but just wanted to say “good catch”.
> On Jul 1, 2015, at 12:52 AM, Sorin Vinturis
> wrote:
>
> Tunnel ports are not initialized with the corresponding default port.
> The newly allocated vport is not yet initialized and the ovsType
> member does not reflect t
I ran this:
$ git grep "Binding table" | grep -v Port_
ovn/controller/pipeline.c: * Binding table within the logical datapath. */
ovn/controller/pipeline.c:/* Iterates through all of the records in the
Binding table, updating the
ovn/ovn-architecture.7.xml:Binding tables, whereas
ovn-north
On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> datapath/actions.c | 6 +-
> datapath/datapath.c | 2 ++
> datapath/flow.h | 1 -
> datapath/flow_netlink.c | 7 ---
> datapath/vport.c| 3 +--
> datapath/vport.h|
> On Jul 29, 2015, at 8:46 AM, Ben Pfaff wrote:
>
> On Tue, Jul 28, 2015 at 04:53:24PM -0700, Justin Pettit wrote:
>
>> If you agree, there's no reason to repost these patches.
>
> I think you should take another look, just to be sure.
I agree that you're correct and that the patch is fine.
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> @@ -309,7 +295,7 @@ main(int argc, char *argv[])
> ctx.ovnsb_idl_txn = idl_loop_run(&ovnsb_idl_loop);
> ctx.ovs_idl_txn = idl_loop_run(&ovs_idl_loop);
>
> -const struct ovsrec_bridge *br_int = get_bridge(&ctx, br_int_na
On 07/29/2015 10:12 PM, Terry Wilson wrote:
> This patch fixes just the Python 3 problems found by running
>
> python3 setup.py install
>
> There are still many other issues to be fixed, but this is a start.
>
> Signed-off-by: Terry Wilson
This is just a rebase, right? All of the changes st
On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> datapath/datapath.c | 25 +
> datapath/datapath.h | 2 +-
> 2 files changed, 14 insertions(+), 13 deletions(-)
If I remember correctly the reason why these weren't marked const i
On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> datapath/actions.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswit
On Thu, Jul 30, 2015 at 10:03 AM, Justin Pettit wrote:
>
>> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>>
>> @@ -309,7 +295,7 @@ main(int argc, char *argv[])
>> ctx.ovnsb_idl_txn = idl_loop_run(&ovnsb_idl_loop);
>> ctx.ovs_idl_txn = idl_loop_run(&ovs_idl_loop);
>>
>> -c
On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
> Backport of upstream commit 2c7a88c252bf3381958cf716f31b6b2e0f2f3fa7:
> "etherdev: Fix sparse error, make test usable by other functions"
>
> Signed-off-by: Joe Stringer
Acked-by: Jesse Gross
___
On Thu, Jul 30, 2015 at 12:06 PM, Russell Bryant wrote:
> On 07/29/2015 10:12 PM, Terry Wilson wrote:
> > This patch fixes just the Python 3 problems found by running
> >
> > python3 setup.py install
> >
> > There are still many other issues to be fixed, but this is a start.
> >
> > Signed-off-
On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
> From: Alexander Duyck
>
> Replace "ntohs(proto) >= ETH_P_802_3_MIN" w/ eth_proto_is_802_3(proto).
>
> Backport of upstream commit 6713fc9b8fa33444aa000f0f31076f6a859ccb34:
> "openvswitch: Use eth_proto_is_802_3"
>
> Signed-off-by: Alexander
I've pushed this series up to this patch to master now.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, I fixed those up too.
On Thu, Jul 30, 2015 at 09:32:05AM -0700, Alex Wang wrote:
> I ran this:
>
> $ git grep "Binding table" | grep -v Port_
> ovn/controller/pipeline.c: * Binding table within the logical datapath. */
> ovn/controller/pipeline.c:/* Iterates through all of the records in
Nithin,
When a packet (NBL) with multiple NB arrives, it is splitted into a list of
multiple packets (NBLs) with single NB by the OvsCreateNewNBLsFromMultipleNBs()
function. The new NBL list is inserted into the head of the existing NBL list
and the execution continues with the processing of th
[adding Aaron Rosen]
On Wed, Jul 29, 2015 at 12:20:30PM +0300, Gal Sagie wrote:
> Currently Neutron support defining few subnets (IP cidrs) on a network
> (logical switch)
> and connecting them to the same router (or different routers).
> Currently in the NB schema, the logical switch can be conne
Yes, i checked this on my setup.
For example, you can have both IPv6 and IPv4 subnets per the same network
(which maps to a logical switch)
and connect both as two different router ports (to the same router)
You can also connect the same network to two different routers, i am not
sure if you need
Also adding Salvatore.
On Thu, Jul 30, 2015 at 9:12 PM, Gal Sagie wrote:
> Yes, i checked this on my setup.
> For example, you can have both IPv6 and IPv4 subnets per the same network
> (which maps to a logical switch)
> and connect both as two different router ports (to the same router)
>
> You
Those two packages are needed to build but they might not
be present in the system.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index f44da3
Acked-by: Daniele Di Proietto
On 30/07/2015 00:52, "Joe Stringer" wrote:
>The initial sanity test only checked IPv4 without IP fragments. This patch
>adds additional tests using IPv6 and VLANs with IP fragments and expands
>the existing test to be more strict.
>
>Signed-off-by: Joe Stringer
>C
Acked-by: Daniele Di Proietto
On 30/07/2015 00:52, "Joe Stringer" wrote:
>We already queue the removal of the kernel module in OVS_VSWITCHD_START,
>via an ON_EXIT() call. This redundant removal also doesn't interact very
>well with usage of vports: If the datapath still exists in the kernel,
>
On 07/30/2015 02:16 PM, Flavio Leitner wrote:
> Those two packages are needed to build but they might not
> be present in the system.
>
> Signed-off-by: Flavio Leitner
Acked-by: Russell Bryant
--
Russell Bryant
___
dev mailing list
dev@openvswitch.o
If both the router ports point to the same router, then I am not sure
why this would need to be two ports. Maybe the schema is not sufficient
to report both IPv4 and IPv6 addresses on a single router port; if so,
then I would support enhancing the schema to fix that.
I suspect that for connecting
[also adding Salvatore]
On Thu, Jul 30, 2015 at 11:27:57AM -0700, Ben Pfaff wrote:
> If both the router ports point to the same router, then I am not sure
> why this would need to be two ports. Maybe the schema is not sufficient
> to report both IPv4 and IPv6 addresses on a single router port; if
On Thu, Jul 30, 2015 at 03:16:30PM -0300, Flavio Leitner wrote:
> Those two packages are needed to build but they might not
> be present in the system.
>
> Signed-off-by: Flavio Leitner
Thanks, applied to master, branch-2.4, and branch-2.3.
___
dev mai
I get a warning in the OVS log that causes this test to fail.
It appears that when br0 is removed (in OVS_KMOD_VSWITCHD_STOP)
OVS gets a rtnetlink message (because br0 had an address in the
routing table), but route_table_parse() fails, because
if_indextoname() returns an error (the device is not
On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
> We already queue the removal of the kernel module in OVS_VSWITCHD_START,
> via an ON_EXIT() call. This redundant removal also doesn't interact very
> well with usage of vports: If the datapath still exists in the kernel,
> we cannot remove a v
On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> tests/kmod-macros.at | 20
> tests/kmod-traffic.at | 49 +
> 2 files changed, 69 insertions(+)
>
> diff --git a/tests/kmod-macros.at b/
On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
> diff --git a/.travis.yml b/.travis.yml
> index 70cc14b..f3236db 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -12,6 +12,7 @@ env:
>- TESTSUITE=1 KERNEL=3.18.1
>- TESTSUITE=1 OPTS="--enable-shared"
>- BUILD_ENV="-m32" OPTS="-
On Thu, Jul 30, 2015 at 12:02 AM, Wenyu Zhang wrote:
> When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
> should be sampled even the prandom32() generate the number of UINT32_MAX.
> And no packet need be sampled when the probability is 0.
>
> Signed-off-by: Wenyu Zhang
On 30 July 2015 at 11:57, Andy Zhou wrote:
> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
>> We already queue the removal of the kernel module in OVS_VSWITCHD_START,
>> via an ON_EXIT() call. This redundant removal also doesn't interact very
>> well with usage of vports: If the datapath s
Acked-by: Justin Pettit
--Justin
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> This drops an unused parameter and groups the calls to these functions
> with ofctrl_destroy() in each case.
>
> Signed-off-by: Ben Pfaff
> ---
> ovn/controller/ovn-controller.c | 5 ++---
> ovn/controller/p
Acked-by: Justin Pettit
--Justin
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> Until now, controller_ctx has been a store of common state (although
> the amount of data stored in it has declined to just database state).
> I think it's clearer if we just use it as a way to pass data to
>
Acked-by: Justin Pettit
--Justin
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> To be used in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> Acked-by: Russell Bryant
> ---
> lib/smap.c | 13 -
> lib/smap.h | 4 +++-
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
> On Jul 29, 2015, at 9:05 AM, Ben Pfaff wrote:
>
> On Tue, Jul 28, 2015 at 11:31:48PM -0700, Alex Wang wrote:
>> On Tue, Jul 28, 2015 at 8:44 AM, Ben Pfaff wrote:
>>
>>> This will be used in documentation for an upcoming change, to document
>>> how Geneve OVN options are encoded.
>>>
>>> The
Acked-by: Justin Pettit
--Justin
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> An upcoming patch will add a Datapath_Binding table, so clarifying the
> name seems useful.
>
> Signed-off-by: Ben Pfaff
> ---
> ovn/controller/binding.c | 28 ++---
> ovn/controller/physical.c |
On 30 July 2015 at 10:08, Jesse Gross wrote:
> On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>> ---
>> datapath/datapath.c | 25 +
>> datapath/datapath.h | 2 +-
>> 2 files changed, 14 insertions(+), 13 deletions(-)
>
> If I rememb
On 30 July 2015 at 12:24, Jesse Gross wrote:
> On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer wrote:
>> diff --git a/.travis.yml b/.travis.yml
>> index 70cc14b..f3236db 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -12,6 +12,7 @@ env:
>>- TESTSUITE=1 KERNEL=3.18.1
>>- TESTSUITE=1
I think Pipeline is more descriptive about what it actually is. I also find it
confusing since we use the term "rule" in the classifier. I think Flow (or
Logical_Flow) would be clearer than Rule, since we really are talking about
flows, and people may look for a distinction that isn't there.
Thanks Jesse, applied patches 1-5 to master. I'll address your
comments on patch #6 in a new series.
On 29 July 2015 at 12:53, Joe Stringer wrote:
> This series addresses a few low-hanging fruit of stylistic differences between
> the ovs tree datapath module and the upstream linux module, and add
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> When an upcoming commit divides the pipeline up into ingress and egress
> pipeline, it will become necessary to resubmit to different tables from
> each of those pipelines to implement output. This commit makes that
> possible.
>
> Signed-off
Acked-by: Justin Pettit
--Justin
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
> The other logical fields have their own macros, so the logical datapath
> field might as well have one.
>
> Signed-off-by: Ben Pfaff
> ---
> ovn/controller/physical.c | 10 +-
> ovn/controller/rule.h
On 30 July 2015 at 11:37, Daniele Di Proietto wrote:
> I get a warning in the OVS log that causes this test to fail.
>
> It appears that when br0 is removed (in OVS_KMOD_VSWITCHD_STOP)
> OVS gets a rtnetlink message (because br0 had an address in the
> routing table), but route_table_parse() fails
On 30 July 2015 at 12:02, Andy Zhou wrote:
> On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>> ---
>> tests/kmod-macros.at | 20
>> tests/kmod-traffic.at | 49 +
>> 2 files changed, 69 ins
Until now, Clang 3.7+ and sufficiently new versions of GCC complained about
TYPE_MAXIMUM(int), etc., because it shifts a negative value. This commit
fixes the problem.
This commit also gives these macros sensible definitions for _Bool, and
documents all of them.
Reported-by: Joe Stringer
Signed
On 30 July 2015 at 17:46, Ben Pfaff wrote:
> Until now, Clang 3.7+ and sufficiently new versions of GCC complained about
> TYPE_MAXIMUM(int), etc., because it shifts a negative value. This commit
> fixes the problem.
>
> This commit also gives these macros sensible definitions for _Bool, and
> do
On Thu, Jul 30, 2015 at 05:57:13PM -0700, Joe Stringer wrote:
> On 30 July 2015 at 17:46, Ben Pfaff wrote:
> > Until now, Clang 3.7+ and sufficiently new versions of GCC complained about
> > TYPE_MAXIMUM(int), etc., because it shifts a negative value. This commit
> > fixes the problem.
> >
> > Th
Hi Gal,
So you're saying that ml2 allows you to configure a topology like this?
VM (10.0.0.2) Logical_Switch(10.0.0.2)LogicalRouter
|
|
+--(10.0.0.3)--Logical-Router--WAN
Fixes typo in STT sampling code.
Signed-off-by: Pravin B Shelar
---
datapath/vport-stt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/vport-stt.c b/datapath/vport-stt.c
index 9a1c8a6..4eb0282 100644
--- a/datapath/vport-stt.c
+++ b/datapath/vport-stt.c
@@ -1
56 matches
Mail list logo
