Re: [ovs-dev] Query related to OF1.4 Group and Meter change notification

Hi Ben, Thanks for the reply. We will send the whole message in OFPT_REQUESTFORWARD as suggested. Thanks Niti On Tue, Jul 21, 2015 at 8:53 PM, Ben Pfaff wrote: > On Tue, Jul 21, 2015 at 03:50:55PM +0530, niti Rohilla wrote: > > We are implementing Group and meter change notification > messages

Re: [ovs-dev] [PATCH net-next 00/22 v2] Lightweight & flow based encapsulation

Hi Thomas, This looks promising. One question: will this approach allow MPLS-in-GRE and MPLS-in-UDP ? -Thomas 2015-07-21, Thomas Graf: This series combines the work previously posted by Roopa, Robert and myself. It's according to what we discussed at NFWS. The motivation of this series is to:

Re: [ovs-dev] intra VM communication

> > Hello, > > I am trying to use vhost-user for sending traffic between VMs . I have > configured two "dpdkvhostuser" interfaces each VM using one of them each > . > > vswitchd is running with dpdk. > Qemu is running with the vhost interfaces > > Guest OS can see interfaces - Verified with the

Re: [ovs-dev] [PATCH v3 00/10] OVN support for Neutron provider networks

On 07/21/2015 07:10 PM, Salvatore Orlando wrote: > I reckon that this approach makes sense, as it alters very little OVN's > northbound schema; moreover at first glance I do not see in the patch > series any change to the OVN pipeline. > > Also mapping neutron provider networks extension onto OVN

Re: [ovs-dev] [PATCH] tnl-arp-cache: Indentation fixes.

On Tue, Jul 21, 2015 at 09:53:23PM -0700, Pravin Shelar wrote: > On Tue, Jul 21, 2015 at 4:03 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > lib/tnl-arp-cache.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/lib/tnl-arp-cache.c b/lib/tn

Re: [ovs-dev] [PATCH] tnl-arp-cache: Remove spurious OVS_UNUSED from tnl_arp_cache_flush().

On Tue, Jul 21, 2015 at 09:53:00PM -0700, Pravin Shelar wrote: > On Tue, Jul 21, 2015 at 4:05 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > lib/tnl-arp-cache.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c

[ovs-dev] [PATCH] treewide: Change doubled "; ; " to single "; " in C code.

Except in "for (;;)". Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 2 +- lib/syslog-direct.c | 2 +- lib/vlog.c | 4 ++-- ofproto/connmgr.c | 2 +- ofproto/ofproto.c | 2 +- ovn/lib/actions.h | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/netdev

Re: [ovs-dev] [PATCH net-next 00/22 v2] Lightweight & flow based encapsulation

On 7/22/15, 1:58 AM, thomas.mo...@orange.com wrote: Hi Thomas, This looks promising. One question: will this approach allow MPLS-in-GRE and MPLS-in-UDP ? The current series was focused on IP to MPLS tunnels. But, the infrastructure allows associating encap state with routes and calling the r

Re: [ovs-dev] [PATCH] treewide: Change doubled "; ; " to single "; " in C code.

On 07/22/2015 11:30 AM, Ben Pfaff wrote: > Except in "for (;;)". > > Signed-off-by: Ben Pfaff All the changes look right to me. I'm not sure s/;;/;/ represents copyrightable material worth updating the copyright date for, but I'm mainly just picking. Acked-by: Russell Bryant > diff --git a/l

Re: [ovs-dev] [ovn-controller-vtep V4 4/6] ovn-controller-vtep: Add gateway module.

On 07/21/2015 03:51 PM, Russell Bryant wrote: > On 07/16/2015 03:56 AM, Alex Wang wrote: >> This commit adds the gateway module to ovn-controller-vtep. The >> module will register the physical switches to ovnsb as chassis and >> constantly update the "vtep_logical_switches" column in Chassis table

Re: [ovs-dev] [PATCH] treewide: Change doubled "; ; " to single "; " in C code.

On Wed, Jul 22, 2015 at 12:15:54PM -0400, Russell Bryant wrote: > On 07/22/2015 11:30 AM, Ben Pfaff wrote: > > Except in "for (;;)". > > > > Signed-off-by: Ben Pfaff > > All the changes look right to me. I'm not sure s/;;/;/ represents > copyrightable material worth updating the copyright date

Re: [ovs-dev] [PATCH] Makefiles: Clean and do not distribute IDL-generated files.

On Tue, Jul 21, 2015 at 10:06:32PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > IDL-generated files don't need to be distributed, and distributing them > > puts them in the source directory rather than the build directory, which > > causes "make distcheck" to fail if any of them need to b

Re: [ovs-dev] [ovn-controller-vtep V4 4/6] ovn-controller-vtep: Add gateway module.

Thx a lot for the review, Russell, I had few crazy days with debugging + customer support, now back to dev~ So, let's see, On Tue, Jul 21, 2015 at 12:51 PM, Russell Bryant wrote: > On 07/16/2015 03:56 AM, Alex Wang wrote: > > This commit adds the gateway module to ovn-controller-vtep. The > >

Re: [ovs-dev] [ovn-controller-vtep V4 5/6] ovn-controller-vtep: Add binding module.

Thx a lot for the review, On Tue, Jul 21, 2015 at 1:35 PM, Russell Bryant wrote: > On 07/16/2015 03:56 AM, Alex Wang wrote: > > This commit adds the binding module to ovn-controller-vtep. The > > module will scan through the Binding table in ovnsb. If there is > > a binding for a logical port

Re: [ovs-dev] [ovn-controller-vtep V4 5/6] ovn-controller-vtep: Add binding module.

On 07/22/2015 01:13 PM, Alex Wang wrote: > Thx a lot for the review, > > > On Tue, Jul 21, 2015 at 1:35 PM, Russell Bryant > wrote: > > On 07/16/2015 03:56 AM, Alex Wang wrote: > > This commit adds the binding module to ovn-controller-vtep. The > > module

Re: [ovs-dev] [ovn-controller-vtep V4 5/6] ovn-controller-vtep: Add binding module.

On Wed, Jul 22, 2015 at 10:32 AM, Russell Bryant wrote: > On 07/22/2015 01:13 PM, Alex Wang wrote: > > Thx a lot for the review, > > > > > > On Tue, Jul 21, 2015 at 1:35 PM, Russell Bryant > > wrote: > > > > On 07/16/2015 03:56 AM, Alex Wang wrote: > > > This c

Re: [ovs-dev] [ovn-controller-vtep V4 6/6] ovn-controller-vtep: Add pipeline module.

On 07/16/2015 03:56 AM, Alex Wang wrote: > This commit adds the pipeline module to ovn-controller-vtep. The > module will scan through the Binding table, and create the > Ucast_Macs_Remote in vtep database for each logical port's MACs in > the same logical datapath (in ovn-sb database). Also the

Re: [ovs-dev] intra VM communication

Hi Ciera , Thank you for your reply . I am assuming , we dont need to configure any flows if both the ports are in the ovs-bridge ( each is connected to a guest) , Please let me know if i am wrong . however, i tried to configure the flows too as per your suggestion , but still i am unable to se

Re: [ovs-dev] [PATCH] Fix detection of vhost_cuse in dpdk rte_config.h

Sorry, I missed this email when it first came in. The use of AC_LANG_PUSH and AC_LANG_POP come from previous bad experiences with macros setting other languages. I usually consider it good practice to not assume the C language has been previously set. It is quite possible that nothing in OVS se

[ovs-dev] [PATCH] netflow: Mark some function parameters 'const'.

Signed-off-by: Ben Pfaff --- ofproto/netflow.c | 7 --- ofproto/netflow.h | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ofproto/netflow.c b/ofproto/netflow.c index 0470443..f1b6fbe 100644 --- a/ofproto/netflow.c +++ b/ofproto/netflow.c @@ -1,5 +1,5 @@ /* - * Copy

Re: [ovs-dev] [PATCH 01/22] ovn-controller: Fix potential use-after-free in get_core_config().

On 07/19/2015 06:44 PM, Ben Pfaff wrote: > It's unsafe to hold a pointer to a row in the IDL across calls to > ovsdb_idl_run() for that IDL. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch

Re: [ovs-dev] [PATCH 02/22] ovn-controller: Drop unnecessary checks for ovsdb_idl_is_alive().

On 07/19/2015 06:44 PM, Ben Pfaff wrote: > The IDLs as created by ovn-controller always retry failed connections, > which means that ovsdb_idl_is_alive() will always report that they are > alive. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant _

Re: [ovs-dev] [PATCH 15/22] smap: New function smap_get_uuid().

On 07/19/2015 06:45 PM, Ben Pfaff wrote: > To be used in an upcoming commit. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 08/22] ovn-controller: Tolerate missing integration bridge.

On 07/19/2015 06:44 PM, Ben Pfaff wrote: > Until now, if the integration bridge was missing, ovn-controller exited. > This commit makes it wait until the integration bridge is created. > > Signed-off-by: Ben Pfaff An alternative would be to create it. I was just working on that and have it here

Re: [ovs-dev] [PATCH] Fix detection of vhost_cuse in dpdk rte_config.h

On Wed, Jul 22, 2015 at 12:03 PM, Mussar, Gary wrote: > Sorry, I missed this email when it first came in. The use of AC_LANG_PUSH and > AC_LANG_POP come from previous bad experiences with macros setting other > languages. I usually consider it good practice to not assume the C language > has be

Re: [ovs-dev] [PATCH 08/22] ovn-controller: Tolerate missing integration bridge.

On Wed, Jul 22, 2015 at 03:35:21PM -0400, Russell Bryant wrote: > On 07/19/2015 06:44 PM, Ben Pfaff wrote: > > Until now, if the integration bridge was missing, ovn-controller exited. > > This commit makes it wait until the integration bridge is created. > > > > Signed-off-by: Ben Pfaff > > An a

Re: [ovs-dev] [PATCH 08/22] ovn-controller: Tolerate missing integration bridge.

On 07/22/2015 03:39 PM, Ben Pfaff wrote: > On Wed, Jul 22, 2015 at 03:35:21PM -0400, Russell Bryant wrote: >> On 07/19/2015 06:44 PM, Ben Pfaff wrote: >>> Until now, if the integration bridge was missing, ovn-controller exited. >>> This commit makes it wait until the integration bridge is created.

Re: [ovs-dev] [PATCH] netflow: Mark some function parameters 'const'.

Acked-by: Jarno Rajahalme > On Jul 22, 2015, at 12:17 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > ofproto/netflow.c | 7 --- > ofproto/netflow.h | 6 +++--- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/ofproto/netflow.c b/ofproto/netflow.c > index 047044

Re: [ovs-dev] [PATCH 03/22] ovn-controller: Avoid blocking to commit OVSDB transactions.

On 07/19/2015 06:44 PM, Ben Pfaff wrote: > Until now, ovn-controller has been full of loops that commit a transaction > to the OVS or OVN Southbound database. These blocking loops delay other > work within ovn-controller. They also make it unsafe to keep pointers to > database records within a si

Re: [ovs-dev] [PATCH 04/22] ovn-controller: Explicitly pass the flow table from function to function.

On 07/19/2015 06:44 PM, Ben Pfaff wrote: > As I was working in ovn-controller, I found it hard to tell what code > produced and what code consumed the OpenFlow flow table, because it was > all implicit. This commit makes the data structure an explicit variable > in the main loop, which makes it ea

[ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

In order for OVS running inside a VM using IVSHMEM to recognize ports created on the host, you have to start vswitchd with the --proc-type=secondary EAL option. When creating rings in secondary processes functions like rte_eth_dev_configure() fail with the error code E_RTE_SECONDARY, i.e., the ope

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

On Wed, Jul 22, 2015 at 01:51:46PM -0700, Melvin Walls wrote: > In order for OVS running inside a VM using IVSHMEM to recognize ports created > on the host, you have to start vswitchd with the --proc-type=secondary EAL > option. > > When creating rings in secondary processes functions like > rte_e

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

Sort of. Helped with the creation of the patch a bit so I figured I should add a sign off. Someone other than me should review it for this reason. Ethan On Wed, Jul 22, 2015 at 3:07 PM, Ben Pfaff wrote: > On Wed, Jul 22, 2015 at 01:51:46PM -0700, Melvin Walls wrote: >> In order for OVS running

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

I understand now. I recommend adding a Co-authored-by, then, to make that clear. On Wed, Jul 22, 2015 at 04:29:55PM -0700, Ethan Jackson wrote: > Sort of. Helped with the creation of the patch a bit so I figured I > should add a sign off. Someone other than me should review it for > this reason

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

Sure, Melvin could you add that to the next version you send out (after this version is reviewed). Ethan On Wed, Jul 22, 2015 at 4:31 PM, Ben Pfaff wrote: > I understand now. I recommend adding a Co-authored-by, then, to make > that clear. > > On Wed, Jul 22, 2015 at 04:29:55PM -0700, Ethan Jac

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

Who should review it? Daniele? Pravin? On Wed, Jul 22, 2015 at 04:34:39PM -0700, Ethan Jackson wrote: > Sure, Melvin could you add that to the next version you send out > (after this version is reviewed). > > Ethan > > On Wed, Jul 22, 2015 at 4:31 PM, Ben Pfaff wrote: > > I understand now. I

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rings in secondary processes in IVSHMEM setups

Probably someone with some experience with the DPDK code. My feeling is that Daniele or Pravin would be appropriate. Wouldn't mind if someone from Intel had a look too. Ethan On Wed, Jul 22, 2015 at 4:36 PM, Ben Pfaff wrote: > Who should review it? Daniele? Pravin? > > On Wed, Jul 22, 2015 a

Re: [ovs-dev] intra VM communication

Hi Ciara , When i further try to debug the issue , i could see that if (OVS_UNLIKELY(!is_vhost_running(virtio_dev))) { return EAGAIN; <<< it always returns from here } >> I believe that dequeue has to be called to get the packets from Guest to User space .