Who should review it? Daniele? Pravin?
On Wed, Jul 22, 2015 at 04:34:39PM -0700, Ethan Jackson wrote: > Sure, Melvin could you add that to the next version you send out > (after this version is reviewed). > > Ethan > > On Wed, Jul 22, 2015 at 4:31 PM, Ben Pfaff <b...@nicira.com> wrote: > > I understand now. I recommend adding a Co-authored-by, then, to make > > that clear. > > > > On Wed, Jul 22, 2015 at 04:29:55PM -0700, Ethan Jackson wrote: > >> Sort of. Helped with the creation of the patch a bit so I figured I > >> should add a sign off. Someone other than me should review it for > >> this reason. > >> > >> Ethan > >> > >> On Wed, Jul 22, 2015 at 3:07 PM, Ben Pfaff <b...@nicira.com> wrote: > >> > On Wed, Jul 22, 2015 at 01:51:46PM -0700, Melvin Walls wrote: > >> >> In order for OVS running inside a VM using IVSHMEM to recognize ports > >> >> created > >> >> on the host, you have to start vswitchd with the --proc-type=secondary > >> >> EAL > >> >> option. > >> >> > >> >> When creating rings in secondary processes functions like > >> >> rte_eth_dev_configure() fail with the error code E_RTE_SECONDARY, i.e., > >> >> the > >> >> operations are not allowed in secondary processes. Avoiding this > >> >> requires some > >> >> changes to the way secondary processes handle dpdk rings. > >> >> > >> >> This patch changes dpdk_ring_create() to use rte_ring_lookup() instead > >> >> of > >> >> rte_ring_create() when called from a secondary process. It also > >> >> introduces two > >> >> functions: netdev_dpdk_ring_rxq_recv() and netdev_dpdk_ring_send__() to > >> >> handle > >> >> tx/rx on dpdk rings in secondary processes. > >> >> > >> >> Signed-off-by: Melvin Walls <mwall...@gmail.com> > >> >> Signed-off-by: Ethan Jackson <et...@nicira.com> > >> > > >> > These sign-offs are weird. Ethan, is this Signed-off-by meant to be an > >> > Acked-by from you? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
