On 07/19/2015 06:44 PM, Ben Pfaff wrote: > Until now, ovn-controller has been full of loops that commit a transaction > to the OVS or OVN Southbound database. These blocking loops delay other > work within ovn-controller. They also make it unsafe to keep pointers to > database records within a single ovn-controller main loop, since calls > to ovsdb_idl_run() can cause IDL records to be destroyed. This commit > drops all of the blocking calls, instead doing a single commit to the > databases at the end of each main loop. > > Signed-off-by: Ben Pfaff <b...@nicira.com>
This is great! This is something I've wanted to do for a while but never got around to. Thanks! The changes look good. I also did some basic testing of this with ovs-sandbox and did not encounter any errors. Alex, I think it would be great to follow this same pattern for ovn-controller-vtep. The idl_loop struct and related functions could be shared between the two, at least. Acked-by: Russell Bryant <rbry...@redhat.com> -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
