Re: [ovs-dev] [PATCH] netdev-dpdk: Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-09 Thread Gray, Mark D
Ok, I see the problem. I think the solution looks good as Daniele said in a separate thread. As mentioned, the flush logic needs a bit of a refactoring but this solution looks ok at this point. > -Original Message- > From: 通天晓0280 [mailto:do...@dtdream.com] > Sent: Saturday, June 6, 2015

Re: [ovs-dev] installing Python 2.7 on Xenserver (was: Re: [PATCH 1/2] Increase prerequisite from Python 2.4 to Python 2.7.)

2015-06-09 Thread Andy Hill
Hi Ben, XenServer 6.6 (still to be released) will ship with Python 2.7 as the system python. Nightlies are currently available at xenserver.org. Versions of XenServer below 6.6 will need Python 2.7 installed probably via RPMs, like you suggested. -AH On Sat, Jun 6, 2015 at 4:46 PM, Ben Pfaff w

[ovs-dev] [PATCH] dpif-netdev: log port/core affinity

2015-06-09 Thread Mark Kavanagh
When using multiple PMDs and numerous ports, a performance gain may be achieved in some use cases by pinning a PMD/port to a particular (set of) core(s). This patch provides a summary of the switch's port/core affinities each time that the status of the switch's ports is modified. Based on this in

Re: [ovs-dev] Can't subscribe this maillist

2015-06-09 Thread William Adams
When I first subscribed, I missed the fact that the listserv sent me a confirmation email (landed in my junk box). So, maybe you received a confirmation email that you have not replied to? -- William === - Shaping clay is easier than digging it out of the ground.

[ovs-dev] Funds Inheritance Overdue Contract Payment(FCA)

2015-06-09 Thread firm.queries fca.org
Direct Telephone:+Tel:+44-743-014-9549. Fax:+44 20 7066 1000. Email: firm.qquer...@ukfca.org Email: firm.queriesfca@gmail.com Attn: Contractor, Sequel to the subsequent meeting with the authority of world bank and the Presidential Adviser on Debt Matters, you are among the Six (6) Contractor

[ovs-dev] dev@openvswitch.org

2015-06-09 Thread 系统管理员
账户dev@openvswitch.org 维护原因由于您长期没有验证OA信息,系统无法验证您的信息,或超过3个月未登录!(为保证正常使用,系统进行升级维护) 维护时间本次升级7-15天,给您带来的不变敬请谅解! 注意事项若您收到此邮件下班前没有验证,系统将自动识别成为无人使用邮箱,将被自动删除,谢谢配合。 处理进度请点击这里取消申请 crkylnaoovbylvegvendybfjolcwkfgdtvrxbibgxgxirkyghtabsdoqnxjdohajyqoicobqprcpzdljtsuelxbfberexfxlomuausdqeqptwoswkvzipop

Re: [ovs-dev] [PATCH 2/2] [RFC] flow: Use new miniflow_builder for miniflow_extract().

2015-06-09 Thread Ben Pfaff
On Mon, Jun 08, 2015 at 10:54:55AM -0700, Jarno Rajahalme wrote: > > > On Jun 8, 2015, at 9:36 AM, Ben Pfaff wrote: > > > > This replaces the very specialized and difficult-to-maintain miniflow > > assembly macros by a simpler data structure named "miniflow_builder" that > > is more general and

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-09 Thread Flavio Leitner
On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo wrote: > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > messages go through slow path, since they may carry multiple multicast > addresses, unlike IGMPv2. > > Tests done: > > * multiple addresses in IGM

[ovs-dev] [PATCH] flow: Make assertions about offsets within struct flow easier to follow.

2015-06-09 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/flow.c | 46 +- lib/util.h | 5 - 2 files changed, 29 insertions(+), 22 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index d2dcc46..9dc29ee 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -50,25 +50,32 @@ const ui

Re: [ovs-dev] [PATCH 1/2] odp-util: Reuse UUID marshalling for UFID.

2015-06-09 Thread Joe Stringer
On 7 June 2015 at 11:03, Ben Pfaff wrote: > On Mon, Jun 01, 2015 at 06:22:19PM -0700, Joe Stringer wrote: >> Unique flow identifiers are really a UUID of sorts, so it makes sense to >> reuse the UUID string representations for UFID. >> >> Suggested-by: Ben Pfaff >> Signed-off-by: Joe Stringer >

[ovs-dev] [PATCH v2] flow: Make assertions about offsets within struct flow easier to follow.

2015-06-09 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- v1->v2: Found and converted a few more assertions. lib/flow.c | 60 +--- lib/util.h | 5 - 2 files changed, 33 insertions(+), 32 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index d2dcc46..3e99d5e 100

Re: [ovs-dev] [PATCH 1/2] odp-util: Reuse UUID marshalling for UFID.

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 11:41:04AM -0700, Joe Stringer wrote: > On 7 June 2015 at 11:03, Ben Pfaff wrote: > > On Mon, Jun 01, 2015 at 06:22:19PM -0700, Joe Stringer wrote: > >> Unique flow identifiers are really a UUID of sorts, so it makes sense to > >> reuse the UUID string representations for U

Re: [ovs-dev] [PATCH v8] netdev-dpdk: add dpdk vhost-user ports

2015-06-09 Thread Flavio Leitner
On Thu, Jun 04, 2015 at 02:51:40PM +0100, Ciara Loftus wrote: > This patch adds support for a new port type to the userspace > datapath called dpdkvhostuser. > > A new dpdkvhostuser port will create a unix domain socket which > when provided to QEMU is used to facilitate communication between > th

Re: [ovs-dev] [PATCH 1/2] odp-util: Reuse UUID marshalling for UFID.

2015-06-09 Thread Joe Stringer
On 9 June 2015 at 12:33, Ben Pfaff wrote: > On Tue, Jun 09, 2015 at 11:41:04AM -0700, Joe Stringer wrote: >> On 7 June 2015 at 11:03, Ben Pfaff wrote: >> > On Mon, Jun 01, 2015 at 06:22:19PM -0700, Joe Stringer wrote: >> >> Unique flow identifiers are really a UUID of sorts, so it makes sense to

[ovs-dev] [PATCH] dpif: Always generate RFC4122 UUIDs for UFID.

2015-06-09 Thread Joe Stringer
This patch sacrifices a few bits of hash quality from the 128-bit unique flow identifiers to make the UFIDs RFC4122-conformant as per the version 4 (random) UUID spec. Given that the 128-bit space is already quite large, this should not affect the spread of UFIDs in any meaningful way for hashing.

Re: [ovs-dev] conntrack: nfqueue action

2015-06-09 Thread Ansis Atteka
Hi Franck On 8 June 2015 at 09:34, Franck BAUDIN wrote: > Hello, > > Conntrack looks in very good progress on > https://github.com/justinpettit/ovs.git > > However, I didn't find any code related to "nfqueue" openvswitch action, > neither on > https://github.com/tgraf/ovs.git. > > Is the nfqueu

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-09 Thread Thadeu Lima de Souza Cascardo
On Tue, Jun 09, 2015 at 03:03:03PM -0300, Flavio Leitner wrote: > On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > > messages go through slow path, since they may carry multiple multicast > > add

Re: [ovs-dev] [PATCH] dpif: Always generate RFC4122 UUIDs for UFID.

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 01:57:59PM -0700, Joe Stringer wrote: > This patch sacrifices a few bits of hash quality from the 128-bit unique > flow identifiers to make the UFIDs RFC4122-conformant as per the version 4 > (random) UUID spec. Given that the 128-bit space is already quite large, > this sho

[ovs-dev] [PATCH 4/4] ofp-parse: Use F_OUT_PORT when parsing.

2015-06-09 Thread Jarno Rajahalme
We set this field flag for the cases when an out_port should be parsed, but failed to make use of it. Two test cases needed to be updated due to use of out_port in flow add, while out_port is legal for flow deletes only. Suggested-by: Ben Pfaff Signed-off-by: Jarno Rajahalme --- lib/ofp-parse.

[ovs-dev] [PATCH 3/4] odp-util: Simplify parsing function for GCC.

2015-06-09 Thread Jarno Rajahalme
GCC 4.7.2 -O3 flagged potential use before initialization for the 'id' and 'id_mask' being scanned in scan_vxlan_gbp(). For the 'id' this was a real possiblity, but for the 'id_mask' it seems to be a false positive in gcc analysis. Simplify scan_vxlan_gbp() to fix this. Signed-off-by: Jarno Raja

[ovs-dev] [PATCH 1/4] ofproto: Fix memory leak in ofproto_rule_delete().

2015-06-09 Thread Jarno Rajahalme
Commit () fixed the memory leak when a rule is deleted, but failed to do the same when all rules in a bridge are deleted just before the bridge itself is deleted. This patch adds the necessary unref to ofproto_rule_delete(). Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c |7 ++- 1

[ovs-dev] [PATCH 2/4] rculist: Use ovsrcu_set() when poisoning.

2015-06-09 Thread Jarno Rajahalme
Should not use ovsrcu_set_hidden() when the pointer may have been visible to other threads already. Signed-off-by: Jarno Rajahalme --- lib/rculist.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rculist.c b/lib/rculist.c index 61a03d0..db2ebf8 100644 --- a/lib/rculis

Re: [ovs-dev] [PATCH 1/4] ofproto: Fix memory leak in ofproto_rule_delete().

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 03:25:07PM -0700, Jarno Rajahalme wrote: > Commit () fixed the memory leak when a rule is deleted, but failed to > do the same when all rules in a bridge are deleted just before the > bridge itself is deleted. > > This patch adds the necessary unref to ofproto_rule_delete()

Re: [ovs-dev] [PATCH 2/4] rculist: Use ovsrcu_set() when poisoning.

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 03:25:08PM -0700, Jarno Rajahalme wrote: > Should not use ovsrcu_set_hidden() when the pointer may have been > visible to other threads already. > > Signed-off-by: Jarno Rajahalme I think that rculist_poison__() is only appropriate when an rculist should not be visible to

Re: [ovs-dev] [PATCH 3/4] odp-util: Simplify parsing function for GCC.

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 03:25:09PM -0700, Jarno Rajahalme wrote: > GCC 4.7.2 -O3 flagged potential use before initialization for the 'id' > and 'id_mask' being scanned in scan_vxlan_gbp(). For the 'id' this > was a real possiblity, but for the 'id_mask' it seems to be a false > positive in gcc ana

Re: [ovs-dev] [PATCH 4/4] ofp-parse: Use F_OUT_PORT when parsing.

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 03:25:10PM -0700, Jarno Rajahalme wrote: > We set this field flag for the cases when an out_port should be > parsed, but failed to make use of it. > > Two test cases needed to be updated due to use of out_port in flow > add, while out_port is legal for flow deletes only. >

Re: [ovs-dev] [PATCH 2/4] rculist: Use ovsrcu_set() when poisoning.

2015-06-09 Thread Jarno Rajahalme
> On Jun 9, 2015, at 3:30 PM, Ben Pfaff wrote: > > On Tue, Jun 09, 2015 at 03:25:08PM -0700, Jarno Rajahalme wrote: >> Should not use ovsrcu_set_hidden() when the pointer may have been >> visible to other threads already. >> >> Signed-off-by: Jarno Rajahalme > > I think that rculist_poison__(

Re: [ovs-dev] [PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-09 Thread Thomas F Herbert
On 6/8/15 11:45 PM, Pravin Shelar wrote: On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert wrote: Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. This patch needs to be merged with earlier patch since it

Re: [ovs-dev] [PATCH 1/4] ofproto: Fix memory leak in ofproto_rule_delete().

2015-06-09 Thread Jarno Rajahalme
> On Jun 9, 2015, at 3:29 PM, Ben Pfaff wrote: > > On Tue, Jun 09, 2015 at 03:25:07PM -0700, Jarno Rajahalme wrote: >> Commit () fixed the memory leak when a rule is deleted, but failed to >> do the same when all rules in a bridge are deleted just before the >> bridge itself is deleted. >> >> T

Re: [ovs-dev] [PATCH 3/4] odp-util: Simplify parsing function for GCC.

2015-06-09 Thread Jarno Rajahalme
> On Jun 9, 2015, at 3:32 PM, Ben Pfaff wrote: > > On Tue, Jun 09, 2015 at 03:25:09PM -0700, Jarno Rajahalme wrote: >> GCC 4.7.2 -O3 flagged potential use before initialization for the 'id' >> and 'id_mask' being scanned in scan_vxlan_gbp(). For the 'id' this >> was a real possiblity, but for t

Re: [ovs-dev] [PATCH 4/4] ofp-parse: Use F_OUT_PORT when parsing.

2015-06-09 Thread Jarno Rajahalme
> On Jun 9, 2015, at 3:32 PM, Ben Pfaff wrote: > > On Tue, Jun 09, 2015 at 03:25:10PM -0700, Jarno Rajahalme wrote: >> We set this field flag for the cases when an out_port should be >> parsed, but failed to make use of it. >> >> Two test cases needed to be updated due to use of out_port in flo

[ovs-dev] [PATCH v4 03/12] classifier: Support table versioning

2015-06-09 Thread Jarno Rajahalme
This patch allows classifier rules to become visible and invisible in specific versions. A 'version' is defined as a positive monotonically increasing integer, which never wraps around. The new 'visibility' attribute replaces the prior 'to_be_removed' and 'visible' attributes. When versioning is

[ovs-dev] [PATCH v4 01/12] ofproto: Rename *_begin functions as *_start.

2015-06-09 Thread Jarno Rajahalme
Weirdest things can bother you at night when you try to sleep ;-) Now we have function triples such as add_flow_begin(), add_flow_finish(), and add_flow_revert(), where a modification is started in *_begin(), which can fail, and when successful can be either made permanent with *_finish(), or canc

[ovs-dev] [PATCH v4 00/12] Atomic bundles with classifier versioning.

2015-06-09 Thread Jarno Rajahalme
This series adds support for atomic flow mod bundles with classifier versioning. Changes since v3: - Added classifier testing for versioning features (patch 05). - Added 'version' to cls_rule, since all users needed one anyway. This is now used also making iterations version-aware (Any version

[ovs-dev] [PATCH v4 04/12] classifier: Make traversing identical rules robust.

2015-06-09 Thread Jarno Rajahalme
The traversal of the list of identical rules from the lookup threads is fragile in the list head is removed during the list traversal. This patch simplifies the implementation of that list by making the list NULL terminated, singly linked RCU-protected list. By having the NULL at the end there is

[ovs-dev] [PATCH v4 06/12] ofproto: Infra for table versioning.

2015-06-09 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 17 - ofproto/ofproto-dpif.c | 43 +- ofproto/ofproto-dpif.h |5 - ofproto/ofproto-provider.h |6 ++ ofproto/ofproto.c|5

[ovs-dev] [PATCH v4 07/12] Use classifier versioning.

2015-06-09 Thread Jarno Rajahalme
Each rule is now added or deleted in a specific tables version. Flow tables are versioned with a monotonically increasing 64-bit integer, where positive values are valid version numbers. Rule modifications are implemented as an insertion of a new rule and a deletion of the old rule, both taking p

[ovs-dev] [PATCH v4 08/12] ofproto: Accurate flow counts.

2015-06-09 Thread Jarno Rajahalme
Classifier's rule count now contains temporary duplicates and rules whose deletion has been deferred. Maintain a new 'n_flows' count in struct oftable to as the count of rules in the latest version. Signed-off-by: Jarno Rajahalme --- ofproto/connmgr.c |2 +- ofproto/ofproto-provide

[ovs-dev] [PATCH v4 05/12] test-classifier: Test versioning features.

2015-06-09 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- tests/classifier.at |8 +- tests/test-classifier.c | 301 +-- 2 files changed, 245 insertions(+), 64 deletions(-) diff --git a/tests/classifier.at b/tests/classifier.at index cfa1bc7..1e75123 100644 --- a/tes

[ovs-dev] [PATCH v4 09/12] ofproto: Revertible eviction.

2015-06-09 Thread Jarno Rajahalme
Handling evictions was broken in the previous patches. Eviction took place early in the commit, and actually inappropriately bumped the version number too early. Now eviction is treated much like a flow modification, where a new rule replaces the old one, but just without any 'inheritance' from th

[ovs-dev] [PATCH v4 12/12] ofproto: Support port mods in bundles.

2015-06-09 Thread Jarno Rajahalme
Add support for port mods in an OpenFlow 1.4 bundle, as required for the minimum support level by the OpenFlow 1.4 specification. If the bundle includes port mods, it may not specify the OFPBF_ATOMIC flag. Port mods and flow mods in a bundle are always applied in order and the consecutive flow mod

[ovs-dev] [PATCH v4 02/12] ovs-ofctl: Add bundle support and unit testing.

2015-06-09 Thread Jarno Rajahalme
All existing ovs-ofctl flow mod commands now take an optional '--bundle' argument, which executes the flow mods as a single transaction. OpenFlow 1.4+ is implicitly assumed when '--bundle' is specified. ovs-ofctl 'add-flow' and 'add-flows' commands now accept flow specifications that start with a

[ovs-dev] [PATCH v4 11/12] ofproto: Use minimatch for making bundles smaller.

2015-06-09 Thread Jarno Rajahalme
struct match in ofputil_flow_mod uses a lot of space, when used for a stored bundle message. This patch adds a new struct ofputil_miniflow_mod, that uses a minimatch instead of match in hopes of using less memory when handling large bundles. Signed-off-by: Jarno Rajahalme --- lib/match.c

[ovs-dev] [PATCH v4 10/12] ofproto: Postpone sending flow removed messages.

2015-06-09 Thread Jarno Rajahalme
The final flow stats are available only after there are no references to the rule. Postpone sending the flow removed message until the final stats are available. Signed-off-by: Jarno Rajahalme --- include/openflow/openflow-common.h |2 ++ lib/ofp-print.c|1 + ofproto

Re: [ovs-dev] [PATCH] dpif: Always generate RFC4122 UUIDs for UFID.

2015-06-09 Thread Joe Stringer
On 9 June 2015 at 15:12, Ben Pfaff wrote: > On Tue, Jun 09, 2015 at 01:57:59PM -0700, Joe Stringer wrote: >> This patch sacrifices a few bits of hash quality from the 128-bit unique >> flow identifiers to make the UFIDs RFC4122-conformant as per the version 4 >> (random) UUID spec. Given that the

Re: [ovs-dev] [PATCH 1/2] odp-util: Reuse UUID marshalling for UFID.

2015-06-09 Thread Joe Stringer
On 9 June 2015 at 13:29, Joe Stringer wrote: > On 9 June 2015 at 12:33, Ben Pfaff wrote: >> On Tue, Jun 09, 2015 at 11:41:04AM -0700, Joe Stringer wrote: >>> On 7 June 2015 at 11:03, Ben Pfaff wrote: >>> > On Mon, Jun 01, 2015 at 06:22:19PM -0700, Joe Stringer wrote: >>> >> Unique flow identifie

Re: [ovs-dev] [PATCH 2/4] rculist: Use ovsrcu_set() when poisoning.

2015-06-09 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 05:05:57PM -0700, Jarno Rajahalme wrote: > > > On Jun 9, 2015, at 3:30 PM, Ben Pfaff wrote: > > > > On Tue, Jun 09, 2015 at 03:25:08PM -0700, Jarno Rajahalme wrote: > >> Should not use ovsrcu_set_hidden() when the pointer may have been > >> visible to other threads alread

[ovs-dev] OVN MAC learning on lports with unknow macs set

2015-06-09 Thread Liran Schour
Hi all, I want to add learning capabilities for lport with unknown macs set.. When an unknown mac source address is going out from a logical port that its macs sets to "unknown", an additional controller action will be take and the packet will be sent to the controller by a PACKET_IN msg. The