Re: [ovs-dev] [per-pmd ftb/cls 3/3] dpif-netdev: Add per-pmd flow-table/classifier.

2014-12-08 Thread Gray, Mark D
> > Thanks for this patch. It's good that some of these locks are > being removed from the datapath. I reviewed the dpif-netdev.c > file. There is an XXX in fast_path_processing() - Can that be > resolved now as you have a per-core classifier or do I > misunderstand?

[ovs-dev] Летающая фея: универсальный подарок для маленьких девочек!

2014-12-08 Thread Летающая Фея
Летающая фея: симпатичная фея, которая станет подружкой для вашей доченьки! Подробности тут ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-08 Thread Thomas Graf
On 12/07/14 at 08:47pm, Pravin Shelar wrote: > Since the beginning OVS kernel datapath development is primarily done > on external OVS repo. Now we have mostly synced upstream and external > OVS. So we have decided to change this process. New process is as > follows. > > 1. OVS feature development

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-08 Thread Ben Pfaff
On Mon, Dec 08, 2014 at 10:28:14PM +0530, Aman Kumar wrote: > So, Now my question is that does ovs snoops only to those ports which is > connected to host? OVS only snoops packets that pass through the OVS "normal" action. ___ dev mailing list dev@openvs

[ovs-dev] [PATCH 2/2] datapath-windows: return bool from NlFillOvs[Msg/Hdr]

2014-12-08 Thread Nithin Raju
Per review comment, in this patch, we update the return values of NlFillOvsMsg() and NlFillOvsHdr() from NTSTATUS to BOOLEAN to make them consistent with the Nl* functions. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c| 31 ++-- datapath-wind

[ovs-dev] [PATCH 1/2] datapath-windows: refactor BuildReplyMsgFromMsgIn & BuildErrorMsg

2014-12-08 Thread Nithin Raju
In this patch, we consolidate code in Netlink.c. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c|2 +- datapath-windows/ovsext/Flow.c|4 +- datapath-windows/ovsext/Netlink/Netlink.c | 40 - datapath-windows/ovsext/Netlin

Re: [ovs-dev] [PATCH 3/3] datapath-windows: refactor BuildReplyMsgFromMsgIn & BuildErrorMsg

2014-12-08 Thread Nithin Raju
On Dec 3, 2014, at 10:32 AM, Nithin Raju wrote: > On Dec 3, 2014, at 10:18 AM, Eitan Eliahu > wrote: > >> >> Hi Nithin, >> It may be out of the scope of this change but for consistency reason all NL >> function should return BOOLEAN rather than NTSTATUS. >> This should apply NlFillOvsMsg() a

[ovs-dev] bug in flow stats for VLAN acceleration?

2014-12-08 Thread Ben Pfaff
Motonori Shindo (CCed) reported to me recently that NetFlow does not include VLAN headers in the byte counts that it exports. Taking a look at the kernel datapath code, I see that ovs_flow_stats_update() accounts raw skb->len to byte counters. I suspect that it should add 4 if a VLAN header was p

Re: [ovs-dev] bug in flow stats for VLAN acceleration?

2014-12-08 Thread Jesse Gross
On Mon, Dec 8, 2014 at 9:58 AM, Ben Pfaff wrote: > Motonori Shindo (CCed) reported to me recently that NetFlow does not > include VLAN headers in the byte counts that it exports. Taking a > look at the kernel datapath code, I see that ovs_flow_stats_update() > accounts raw skb->len to byte counte

Re: [ovs-dev] [PATCH] tests/classifier: Make test work in big-endian systems.

2014-12-08 Thread Jarno Rajahalme
On Dec 5, 2014, at 10:24 AM, Ben Pfaff wrote: > On Wed, Dec 03, 2014 at 01:21:48PM -0800, Jarno Rajahalme wrote: >> Change a test so that the result will be the same in both >> little-endian and big-endian systems. > > ...by editing the test case so that only one bit differs? > >> Reported-by:

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-08 Thread Pravin Shelar
On Mon, Dec 8, 2014 at 9:15 AM, Thomas Graf wrote: > On 12/07/14 at 08:47pm, Pravin Shelar wrote: >> Since the beginning OVS kernel datapath development is primarily done >> on external OVS repo. Now we have mostly synced upstream and external >> OVS. So we have decided to change this process. New

Re: [ovs-dev] [PATCH 2/5] ovs-router: non-Linux support

2014-12-08 Thread Pravin Shelar
On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi wrote: > Refactor ovs-router so that it can work with non-Linux platforms > at least in some extent, using the existing route-table code as > a fallback. Known restriction: for such platforms, "ovs/router/show" > command does not show "Cached" kern

Re: [ovs-dev] [PATCH 3/5] ovs-router: Add "ovs/route/lookup" command

2014-12-08 Thread Pravin Shelar
On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi wrote: > This command is useful at least for testing. > > Example output: > % ovs-appctl ovs/route/lookup '10.0.0.1' > gateway 172.17.0.254 > dev wm0 > % > Can you add documentation for new command? > Signed-off-by: YAMAMOTO Takashi

Re: [ovs-dev] OFtest--time for a new run?

2014-12-08 Thread Madhu Challa
Ok that explains why the barrier isn't working for that test. Sorry about the delay. Pl find a summary of the remaining failures with the associated logs. Thanks. On Fri, Dec 5, 2014 at 11:24 AM, Ben Pfaff wrote: > Currently we don't synchronize barriers and revalidation at all. If > we decide

Re: [ovs-dev] [PATCH 1/3] auto-attach: Initial support for Auto-Attach standard

2014-12-08 Thread Ben Pfaff
On Fri, Nov 14, 2014 at 07:42:07AM -0500, drfl...@avaya.com wrote: > From: Dennis Flynn > > This commit provides the initial delivery of support for the Auto-Attach > standard to Open vSwitch. This standard describes a compact method of using > IEEE 802.1AB Link Layer Discovery Protocol (LLDP) wi

Re: [ovs-dev] [PATCH 1/2] ovs-command-completion: Fix unwanted whitespace.

2014-12-08 Thread Joe Stringer
On 25 November 2014 at 18:17, Alex Wang wrote: > This commit fixes unwanted whitespace in the ovs > bash completion script output. > > Signed-off-by: Alex Wang Did you get review for this? Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.o

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-08 Thread Flavio Leitner
On Mon, Dec 08, 2014 at 10:28:14PM +0530, Aman Kumar wrote: > Hi all, > > Thanks again, because of your help it is working fine but i have a problem > with 2 compute nodes(each one is having different OVS), > below is the complete scenario. > [image: Inline image 1] > > Here, when receiver VM1 se

Re: [ovs-dev] [PATCH 1/2] ovs-command-completion: Fix unwanted whitespace.

2014-12-08 Thread Alex Wang
Nope, do need a review (both patches) ~ thx~ On Mon, Dec 8, 2014 at 11:32 AM, Joe Stringer wrote: > On 25 November 2014 at 18:17, Alex Wang wrote: > > This commit fixes unwanted whitespace in the ovs > > bash completion script output. > > > > Signed-off-by: Alex Wang > > Did you get review for

Re: [ovs-dev] [PATCH 2/3] auto-attach: Add auto-attach support to ofproto layer

2014-12-08 Thread Ben Pfaff
On Fri, Nov 14, 2014 at 07:42:08AM -0500, drfl...@avaya.com wrote: > From: Dennis Flynn > > Signed-off-by: Ludovic Beliveau > Signed-off-by: Dennis Flynn Thanks for the second version! In monitor_mport_run(), I think it would be better to put the result of each of the *_wake_time() calls into

[ovs-dev] [PATCH 0/8] OpenFlow 1.4 bundles fixes.

2014-12-08 Thread Jarno Rajahalme
This series improves the OpenFlow 1.4 bundles code to follow the spec more closely. This is work in progress, as actual commits are still not supported. Jarno Rajahalme (8): connmgr: Dealloc 'bundles' in ofconn_destroy(). rconn: Make OF 1.4 bundle messages 'admitted'. OF1.4 bundles: Verify

[ovs-dev] [PATCH 7/8] bundles: Clean up bundle commit.

2014-12-08 Thread Jarno Rajahalme
This fixes ofp_bundle_commit() in two ways: - Always remove the bundle regardless of the error condition. - A commit of an empty bundle must be successful. The actual commit is still not supported. Signed-off-by: Jarno Rajahalme --- lib/ofp-parse.c |1 - ofproto/bundles.c | 15

[ovs-dev] [PATCH 5/8] bundles: Reject unbundlable messages.

2014-12-08 Thread Jarno Rajahalme
Reject bundle add messages containing messages that should not be bundled. Signed-off-by: Jarno Rajahalme --- lib/ofp-util.c | 94 tests/ofp-print.at | 47 ++ 2 files changed, 134 insertions(+), 7 deletions(-)

[ovs-dev] [PATCH 6/8] ofproto: Reject slave controllers for bundle messages.

2014-12-08 Thread Jarno Rajahalme
Slave controllers are rejected for flow and port mod messages, so they should also be rejected for bundles (that require support at least for flow and port mod messages). Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ofprot

[ovs-dev] [PATCH 3/8] OF1.4 bundles: Verify xids.

2014-12-08 Thread Jarno Rajahalme
A switch may optionally verify that the 'xid' of an added message is the same as the 'xid' of the bundle add message itself. Do it. Signed-off-by: Jarno Rajahalme --- lib/ofp-util.c |3 +++ tests/ofp-print.at | 10 ++ 2 files changed, 13 insertions(+) diff --git a/lib/ofp-uti

[ovs-dev] [PATCH 4/8] bundles: Reject bundle add with bad flags.

2014-12-08 Thread Jarno Rajahalme
OpenFlow 1.4 states that the switch must reject a bundle add message whose flags are different from the ones in the bundle. Do it. Signed-off-by: Jarno Rajahalme --- ofproto/bundles.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ofproto/bundles.c b/ofproto/bund

[ovs-dev] [PATCH 2/8] rconn: Make OF 1.4 bundle messages 'admitted'.

2014-12-08 Thread Jarno Rajahalme
Use of OF 1.4 bundle messages by a controller should indicate that the controller has decided to use the switch, hence make is_admitted_msg() return 'true' for them. Signed-off-by: Jarno Rajahalme --- lib/rconn.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rcon

[ovs-dev] [PATCH 8/8] bundles: Validate bundled messages.

2014-12-08 Thread Jarno Rajahalme
OpenFlow bundle messages should be decoded and validated at the time they are added to the bundle. This commit does this for flow mod and port mod messages. Signed-off-by: Jarno Rajahalme --- lib/ofp-print.c |2 +- lib/ofp-util.c| 10 +++--- lib/ofp-util.h|5 - ofpro

[ovs-dev] [PATCH 1/8] connmgr: Dealloc 'bundles' in ofconn_destroy().

2014-12-08 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/connmgr.c |1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c index 46e7431..5971c37 100644 --- a/ofproto/connmgr.c +++ b/ofproto/connmgr.c @@ -1281,6 +1281,7 @@ ofconn_destroy(struct ofconn *ofconn) }

[ovs-dev] Salut

2014-12-08 Thread Mlle Patricia Rosat
Je m'excuse pour le dérangement, je voudrais faire votre connaissance et liée une amitié sincère avec vous, prière de me répondre. Je promets d'être honnête et de garder une bonne relation avec vous.baisers,Mlle Patricia Rosat ___ dev mailing lis

Re: [ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

2014-12-08 Thread Ben Pfaff
On Fri, Nov 14, 2014 at 07:42:09AM -0500, drfl...@avaya.com wrote: > From: Dennis Flynn > > This is the final commit in the series of commits that deliver initial support > for Auto-Attach. Specifically this commit delivers auto-attach support to the > OVS bridge layer as well as the new auto-att

[ovs-dev] Possible debug improvement in datapath/actions.c (do_output)

2014-12-08 Thread Sabyasachi Sengupta
Looking at do_output, it appears that we silently drop a packet if a bad out_port was specified because vport will be NULL from ovs_vport_rcu and we just free the skb and return from thereon. Instead, an ideal behavior should be to log this in user space via log_execute_message and also perhap

[ovs-dev] [PATCH] revalidator: Fix access of uninitialized memory.

2014-12-08 Thread Joe Stringer
Commit 64bb477 "dpif: Minimize memory copy for revalidation." introduced a bug where the corner case of ukey creation (in revalidator threads) could result in access to uninitialized memory when deleting flows from the datapath. This could result in OVS aborting or deadlock. Fix it. Signed-off-by:

Re: [ovs-dev] [PATCH] revalidator: Fix access of uninitialized memory.

2014-12-08 Thread Ben Pfaff
On Mon, Dec 08, 2014 at 05:26:54PM -0800, Joe Stringer wrote: > Commit 64bb477 "dpif: Minimize memory copy for revalidation." introduced > a bug where the corner case of ukey creation (in revalidator threads) > could result in access to uninitialized memory when deleting flows from > the datapath.

Re: [ovs-dev] [PATCH] revalidator: Fix access of uninitialized memory.

2014-12-08 Thread Joe Stringer
On 8 December 2014 at 17:33, Ben Pfaff wrote: > On Mon, Dec 08, 2014 at 05:26:54PM -0800, Joe Stringer wrote: >> Commit 64bb477 "dpif: Minimize memory copy for revalidation." introduced >> a bug where the corner case of ukey creation (in revalidator threads) >> could result in access to uninitiali

[ovs-dev] [PATCH] include/openvswitch/util: Add extern "C" { ... }.

2014-12-08 Thread Ben Pfaff
Requested-by: Alan Shieh Signed-off-by: Ben Pfaff --- include/openvswitch/util.h | 8 1 file changed, 8 insertions(+) diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h index 58c2b59..b2b20a5 100644 --- a/include/openvswitch/util.h +++ b/include/openvswitch/util.h @@

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-08 Thread Neethi Shashidhar
Hi, It is a openstack setup that we are using. To be more clear with the configuration: -> we have set *mcast_snooping_enable=true* on *br-int* of OVS on both the compute nodes. -> *mcast-snooping-flood=true *for *Patch-tun* port of br-int on both compute nodes ( so that the multi

[ovs-dev] 2015年卓越工程师教育培养计划骨干教师研讨会的通知(2015年2月6-9日・珠海)

2014-12-08 Thread 灵创国际交流中心
一、会议背景 2010年6月,根据人才规划纲要和教育规划纲要的部署,教育部启动实施了“卓越工程师教育培养计划”(简称“卓越计划”)。该计划是贯彻落实《国家中长期教育改革和发展规划纲要(2010-2020年)》和《国家中长期人才发展规划纲要(2010-2020年)》的重大改革项目,旨在培养造就一大批创新能力强、适应经济社会发展需要的高质量各类型工程技术人才,对促进高等教育面向社会需求培养人才、全面提高工程教育人才培养质量具有十分重要的示范和引导作用。 “卓越计划”实施三年多来,取得了积极进展。教育部组织制订了总体方案,建立了多部门协同的组织架构,出台了专门的政策措施;行业和企业大力支持,参

Re: [ovs-dev] [PATCH] include/openvswitch/util: Add extern "C" { ... }.

2014-12-08 Thread Thomas Graf
On 12/08/14 at 07:19pm, Ben Pfaff wrote: > Requested-by: Alan Shieh > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] include/openvswitch/util: Add extern "C" { ... }.

2014-12-08 Thread Ben Pfaff
On Tue, Dec 09, 2014 at 06:20:45AM +0100, Thomas Graf wrote: > On 12/08/14 at 07:19pm, Ben Pfaff wrote: > > Requested-by: Alan Shieh > > Signed-off-by: Ben Pfaff > > Acked-by: Thomas Graf Thanks! Applied. ___ dev mailing list dev@openvswitch.org htt