On Fri, Nov 14, 2014 at 07:42:09AM -0500, [email protected] wrote:
> From: Dennis Flynn <[email protected]>
>
> This is the final commit in the series of commits that deliver initial support
> for Auto-Attach. Specifically this commit delivers auto-attach support to the
> OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is
> modified to define the new auto-attach entries. The man pages, unit tests, and
> news and license notice files are also updated.
>
> Signed-off-by: Ludovic Beliveau <[email protected]>
> Signed-off-by: Dennis Flynn <[email protected]>
Thanks for the revision and, again, sorry about the late review.
I think that the code mentioned in NOTICE and debian/copyright.in in
this commit was added in previous commits. Please update these files
in the same patch that adds the related code.
I get the following GCC warnings (it looks like you need to use
"%"PRId64 instead of "%ld"):
../vswitchd/bridge.c: In function 'bridge_configure_aa':
../vswitchd/bridge.c:3787:17: error: format '%ld' expects argument of type
'long int', but argument 4 has type 'int64_t' [-Werror=format]
../vswitchd/bridge.c:3787:17: error: format '%ld' expects argument of type
'long int', but argument 5 has type 'int64_t' [-Werror=format]
../vswitchd/bridge.c:3799:17: error: format '%ld' expects argument of type
'long int', but argument 4 has type 'int64_t' [-Werror=format]
../vswitchd/bridge.c:3799:17: error: format '%ld' expects argument of type
'long int', but argument 5 has type 'int64_t' [-Werror=format]
In ovs-vsctl.8.in, the fragment "Auto Attach configuration." seems out
of place here:
+These commands manage the Auto Attach I-SID/VLAN mappings. Auto Attach
+configuration. The IETF Auto-Attach SPBM draft standard describes a
compact
+method of using IEEE 802.1AB Link Layer Discovery Protocol (LLDP) together
with
A lot of indentation looks out of place in ovs-vsctl.c; it looks like
tabs are used on some lines (all indentation in OVS should be with
spaces only).
I look forward to v3 of this series. It looks like the remaining
needed changes are fairly minor ones. (I'll be out of town
Dec. 13-23, so if you want reviews during that time you'll have to ask
someone else for them.)
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
