On 09/22/14 at 06:36pm, John Fastabend wrote:
> n-tuple has some deficiencies,
>
> - its not possible to get the capabilities to learn what
> fields are supported by the device, what actions, etc.
>
> - its ioctl based so we have to poll the device
>
> - only supports a
On 09/22/14 at 03:40pm, Tom Herbert wrote:
> On Mon, Sep 22, 2014 at 3:17 PM, Thomas Graf wrote:
> > What makes stateful offload interesting to me is that the final
> > desintation of a packet is known at RX and can be redirected to a
> > queue or VF. This allows to build packet batches on shared
I am a former law firm Partner and my legal services business, Contracts 4
Commerce, provides companies with their commercial contracts for a low fixed
fee.
I am writing to inform you that we have produced new Terms and Conditions which
are for use specifically by businesses in your market s
On 09/22/14 at 07:16pm, Tom Herbert wrote:
> Turn on UDP RSS on the device and I bet you'll see those differences
> go away! Once we moved to UDP encapsulation, there's really little
> value in looking at inner headers for RSS or ECMP, this should be
> sufficient. Sure someone might want to parse t
On 09/23/14 at 12:11am, Andy Gospodarek wrote:
> There are clearly some that are most interested in how an eSwitch on an
> SR-IOV capable NIC be controlled can provide traditional forwarding help
> as well as offload the various technologies they hope to terminate
> at/inside their endpoint (host/g
On 09/22/14 21:36, John Fastabend wrote:
n-tuple has some deficiencies,
- its not possible to get the capabilities to learn what
fields are supported by the device, what actions, etc.
- its ioctl based so we have to poll the device
- only supports a single table, where w
Remove the duplicated comment
"/* The following definitions are for users of the vport subsytem: */"
in vport.h
Signed-off-by: Wang Sheng-Hui
---
net/openvswitch/vport.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h
index 35f89d8..5b43010 10
The windows ovs kernel uses an OVS_VPORT_TYPE enum that is incompatible with
the userspace counterpart (enum ovs_vport_type from openvswitch.h). We must use
the same enum type for the netlink communication to work properly.
This patch makes the fix: "typedef enum ovs_vport_type OVS_VPORT_TYPE" and
Help produce better optimized code.
Signed-off-by: Thomas Graf
---
datapath/actions.c | 2 +-
datapath/datapath.c | 4 ++--
datapath/datapath.h | 2 +-
datapath/flow_table.c | 2 +-
datapath/flow_table.h | 2 +-
datapath/vport-netdev.c | 2 +-
datapath/vport.c| 4 ++--
d
All NET_BUFFERs of a NET_BUFFER_LIST must go through the pipeline: extract,
find flow, execute. Previously, only the first NET_BUFFER of a NET_BUFFER_LIST
was going through this pipeline, which was erroneous.
OvsPartialCopyToMultipleNBLs is used to make each NET_BUFFER have its own
NET_BUFFER_LIST
On Fri, Sep 19, 2014 at 01:32:55PM -0700, Alex Wang wrote:
> This commit adds a log message to notify the excessive backlog
> for jsonrpc. Expectedly, this message should never be printed.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
dev mail
Sam, can you please runs VXLAN traffic while the DriverVerifier is enabled on
the driver?
If uninstallation is successful after the test we should be good to go.
Thank you,
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Tuesday, September 23, 2
On 9/23/2014 7:11 AM, Andy Gospodarek wrote:
On Mon, Sep 22, 2014 at 07:16:47PM -0700, Tom Herbert wrote:
[...]
Alexei, I believe you said previously said that SW should not dictate
HW models. I agree with this, but also believe the converse is true--
HW shouldn't dictate SW model. This is real
Hi all,
We have the following immediate tasks on our agenda:
[1] Vport NetLink commands
[2] Port Event notifications (associated with [1])
[3] Flow commands (Ankur is almost done).
[4] Narrow scope of Netdev (only for [1] and [2])
[5] Event and Packet miss (READ IOCTL should be expanded to support
Meeting is in 9/24.
Thanks Ankur.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu
Sent: Tuesday, September 23, 2014 8:33 AM
To: Alin Serdean; Samuel Ghinet; Nithin Raju; Ankur Sharma; Kaushik Guha
Cc: dev@openvswitch.org
Subject: [ovs-dev]
Hello Nithin,
Thanks for the review!
> 2. We'll have to get rid of the OvsDumpVportIoctl() sometime. We need not do
> it in this patch itself.
I think the best time to remove it is when the netlink part is done. We could
add some #ifdef so people know it's not used when the netlink device is us
Oh, I've sent reply with explanations before reading this reply of yours.
Anyway, I wrote explanations there for other things as well.
Regards,
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Friday, September 19, 2014 7:43 PM
To: Samuel Ghinet
Cc: dev@open
On Tue, Sep 23, 2014 at 12:31 AM, Thomas Graf wrote:
> On 09/17/14 at 02:02pm, Thomas Graf wrote:
>> ovs_nla_copy_actions() already frees the allocated actions buffers,
>> ovs_flow_cmd_new() will free it a second time when jumping to
>> err_kfree_acts.
>>
>> Signed-off-by: Thomas Graf
>
> Gentle
On 09/23/14 at 10:57am, Pravin Shelar wrote:
> On Tue, Sep 23, 2014 at 12:31 AM, Thomas Graf wrote:
> > On 09/17/14 at 02:02pm, Thomas Graf wrote:
> >> ovs_nla_copy_actions() already frees the allocated actions buffers,
> >> ovs_flow_cmd_new() will free it a second time when jumping to
> >> err_kf
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Samuel Ghinet
Trimis: Tuesday, September 23, 2014 3:46 PM
Către: dev@openvswitch.org
Cc: nit...@vmware.com; Ankur Sharma; ssaur...@vmware.com; Alin Serdean;
elia...@vmware.com
Subiect: [PATCH v2] datapath-windows: fix OVS_VPORT_TYPE
hi Samuel,
Thanks for the re-spin. I'm afraid, there'll have to be another iteration. I
see a refCounting issue when origNbl->FirstNetBuffer->Next != NULL. I have
noted that down in the code.
Other comments are very minor.
Thanks again for working on this. I'll be on IRC if you want to chat.
t
Thanks, applied to master and backported to branch-2.3
On Mon, Sep 22, 2014 at 6:27 PM, Ben Pfaff wrote:
> On Mon, Sep 22, 2014 at 03:53:31PM -0700, Alex Wang wrote:
> > Commit 9ff33ca7 (ovs-pki: Use SHA-512 instead of MD5 as message
> > digest.) changes the message digest algorithm to SHA-512.
> SKB_GSO_UDP_TUNNEL_CSUM was the right way
> to start splitting overloaded and messy semantics of
> UDP_TUNNEL. I'm still not sure whether you've intended
> it for both rx and tx, since to support tunnel_csum on rx,
> parsing of encap is needed, whereas tx is so much simpler.
> Unless you're assum
On Sep 23, 2014, at 5:45 AM, Samuel Ghinet
wrote:
> The windows ovs kernel uses an OVS_VPORT_TYPE enum that is incompatible with
> the userspace counterpart (enum ovs_vport_type from openvswitch.h). We must
> use
> the same enum type for the netlink communication to work properly.
>
> This pat
On Tue, Sep 23, 2014 at 5:02 AM, Wang Sheng-Hui wrote:
> Remove the duplicated comment
> "/* The following definitions are for users of the vport subsytem: */"
> in vport.h
>
> Signed-off-by: Wang Sheng-Hui
Acked-by: Pravin B Shelar
Thanks.
> ---
> net/openvswitch/vport.h | 1 -
> 1 file cha
On Tue, Sep 23, 2014 at 10:59 AM, Thomas Graf wrote:
> ovs_nla_copy_actions() already frees the allocated actions buffers,
> ovs_flow_cmd_new() will free it a second time when jumping to
> err_kfree_acts.
>
> Signed-off-by: Thomas Graf
Pushed to master.
Thanks.
> ---
> datapath/datapath.c | 2
On Mon, Sep 22, 2014 at 6:39 PM, Andy Zhou wrote:
> Thanks for the fix! Looks good. Also verified it fixes the crash reported.
>
> Acked-by: Andy Zhou
>
I pushed patch to master and 2.1 and 2.3.
Thanks.
> On Sat, Sep 20, 2014 at 9:10 PM, Pravin B Shelar wrote:
>> OVS needs to segments large s
On Tue, Sep 23, 2014 at 7:02 AM, Thomas Graf wrote:
> Help produce better optimized code.
>
I found few more variable to Constify, so I updated patch and pushed to master.
Thanks.
> Signed-off-by: Thomas Graf
> ---
> datapath/actions.c | 2 +-
> datapath/datapath.c | 4 ++--
> datapa
Thx applied to master and backported patch 1 and 3 to branch-2.3.
On Fri, Sep 19, 2014 at 12:42 PM, Flavio Leitner wrote:
> On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote:
> > When ovs is running with large topology (e.g. large number of
> > interfaces), the stats update to ovsdb beco
> Signed-off-by: Ben Pfaff
Acked-by: YAMAMOTO Takashi
> ---
> build-aux/extract-ofp-msgs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/build-aux/extract-ofp-msgs b/build-aux/extract-ofp-msgs
> index 256a6c2..0ccd64e 100755
> --- a/build-aux/extract-ofp-msgs
> ++
> Signed-off-by: Ben Pfaff
Acked-by: YAMAMOTO Takashi
> ---
> utilities/ovs-ofctl.8.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index 64171e7..3f55a72 100644
> --- a/utilities/ovs-ofctl.8.in
> +++ b/utilitie
> A log message has warned that this was going to happen for some time, and
> newer OpenFlow versions require this behavior.
>
> The test updates fix this behavior in our testsuite.
>
> Signed-off-by: Ben Pfaff
Acked-by: YAMAMOTO Takashi
___
dev mail
> Following this change, only meta-flow.c uses any explicit NXM_* or OXM_*
> constants. An upcoming commit will actually remove the definitions of
> these constants, hiding them behind a functional interface, for better
> abstraction.
>
> Signed-off-by: Ben Pfaff
Acked-by: YAMAMOTO Takashi
___
> dp_hash and recirc_id are specific to OVS, but that doesn't mean that we
> shouldn't encode them into flow matches when OXM is used in OpenFlow 1.2
> and later.
>
> Signed-off-by: Ben Pfaff
Acked-by: YAMAMOTO Takashi
___
dev mailing list
dev@openvsw
> This is a first step toward improving the abstraction of OXM and NXM in the
> tree. As an immediate improvement, this commit removes all of the
> definitions of the OXM and NXM constants from the top-level header files,
> because they are no longer used anywhere.
>
> Signed-off-by: Ben Pfaff
> This will acquire its first user in an upcoming commit.
>
> This implementation is not optimized at all but it doesn't matter for the
> purpose for which I intend to initially use it.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/util.c | 29 +
> lib/util.h | 2 ++
> 2
> NXM/OXM are only supposed to put 1-bits in a value if the corresponding bit
> in the mask is a 1-bit, but in the case of cookie matching, e.g.
> ovs-ofctl del-flows br0 cookie=0x3/0x1
> ovs-ofctl would encode a bad OXM. This fixes the problem.
>
> (The test "ofproto - del flows based on coo
> The OpenFlow 1.5 (draft) Copy-Field action has two OXM headers, one after
> the other. Until now, Open vSwitch has implemented these as a pair of
> ovs_be32 membes, which meant that only 32-bit OXM could be supported. This
members
(i haven't reviewed the code as i have no access to OF1.5 draf
> OXM renamed the 'vendor' field from NXM to the 'class', and uses the term
> "experimenter", which OVS usually renders as "vendor" for historical
> reasons, as part of the extended 64-bit OXMs. To reduce confusion, this
> commit adopts the OXM terminology for class.
>
> Signed-off-by: Ben Pfaff
> diff --git a/lib/nx-match.c b/lib/nx-match.c
> index df39b4e..5970e44 100644
> --- a/lib/nx-match.c
> +++ b/lib/nx-match.c
> @@ -1093,8 +1093,11 @@ parse_nxm_field_name(const char *name, int name_len)
> /* Check whether it's a 32-bit field header value as hex.
> * (This isn't ordinaril
> Testing experimenter OXM is tricky because I do not know of any in
> widespread use. Two ONF proposals use experimenter OXMs: EXT-256 and
> EXT-233. EXT-256 is not suitable to implement for testing because its use
> of experimenter OXM is wrong and will be changed. EXT-233 is not suitable
sor
When searching through the valid ids an id should
be used if is not found rather than if it is found.
It appears to me that without this change duplicate recirculation
ids may used in cases where the last recirculation id has
been allocated; selection loops back to the beginning of the pool and;
r
It is add-groups rather than add-group that takes FILE as an argument.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 4a90155..8dcd72c 100644
--- a/utilities/ovs-ofctl.c
On Fri, Sep 19, 2014 at 02:44:49PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > Allow formatting of select group action. This is used
> > when pretty-printing datapath flows. Subsequent patches
> > will add support for the select group action to the datapath
> > and o
On Fri, Sep 19, 2014 at 03:06:38PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > diff --git a/datapath/datapath.h b/datapath/datapath.h
> > index c5d3c86..74a15e6 100644
> > --- a/datapath/datapath.h
> > +++ b/datapath/datapath.h
> > @@ -209,4 +209,9 @@ do {
On Fri, Sep 19, 2014 at 03:05:27PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > +const struct nlattr *bucket_actions(const struct nlattr *attr)
> > +{
> > + const struct nlattr *a;
> > + int rem;
> > +
> > + for (a = nla_data(attr), rem = nla_len(attr); rem > 0;
46 matches
Mail list logo
