On Wed, Aug 13, 2014 at 10:19 PM, Pravin B Shelar wrote:
> Currently on mask delete OVS moves last mask to the deleted
> place to keep compact for per cpu cache. But this generate
> duplicate entries in mask cache array which results in
> multiple flow lookups in case we miss flow cache.
> Followi
On 08/13/14 at 09:56am, Ben Pfaff wrote:
> On Wed, Aug 13, 2014 at 03:34:27PM +0200, Thomas Graf wrote:
> > This makes the following work:
> > add-group br0 group_id=1234,type=all, \
> > bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_IP_SRC[], \
> > bucket=output:11
On 08/14/14 at 10:40am, Thomas Graf wrote:
> On 08/13/14 at 09:56am, Ben Pfaff wrote:
> > On Wed, Aug 13, 2014 at 03:34:27PM +0200, Thomas Graf wrote:
> > > This makes the following work:
> > > add-group br0 group_id=1234,type=all, \
> > > bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_I
If I leave OvsPub.h and OvsDpInterface.h intact, should I also leave
OvsNetlink.h intact?
Sam
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Thursday, August 14, 2014 3:43 AM
To: Samuel Ghinet; Nithin Raju; Ankur Sharma
Cc: dev@openvswitch.org
Subject: Re:
hi,
I just wanted to send out the meeting minutes for any future reference:
Attendees: Alin Serdean, Samuel Ghinet, Ankur Sharma, Saurabh Shah, Ben Pfaff,
Nithin Raju.
1. Netlink implementation discussion - design discussions, status.
---
On Wed, Aug 13, 2014 at 08:57:28PM -0700, Wenyu Zhang wrote:
> Extend IPFIX exporter to export tunnel headers when both input and output
> of the port.
> Add three other_config options in IPFIX table: enable-input-sampling,
> enable-output-sampling and enable-tunnel-sampling, to control whether
> s
On Thu, Aug 14, 2014 at 10:59:53AM +0200, Thomas Graf wrote:
> On 08/14/14 at 10:40am, Thomas Graf wrote:
> > On 08/13/14 at 09:56am, Ben Pfaff wrote:
> > > On Wed, Aug 13, 2014 at 03:34:27PM +0200, Thomas Graf wrote:
> > > > This makes the following work:
> > > > add-group br0 group_id=1234,type=a
On Wed, Aug 13, 2014 at 06:46:17PM -0700, Ethan Jackson wrote:
> This patch reorganizes ofproto-dpif in preparation for future patches
> which allow direct upcall processing from dpif-netdev. The main goals
> are to share as much code as possible between the dpif-linux and
> dpif-netdev upcall pat
On Wed, Aug 13, 2014 at 06:46:18PM -0700, Ethan Jackson wrote:
> This patch avoids the relatively inefficient miss handling processes
> dictated by the dpif process, by calling into ofproto-dpif directly
> through a callback.
>
> Signed-off-by: Ethan Jackson
Should dp_netdev_flow_add() rate-limi
Thx, applied both patches to master and branch-2.3.
On Wed, Aug 13, 2014 at 6:49 PM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Mon, Aug 11, 2014 at 6:34 PM, Alex Wang wrote:
> > This commit adds options for configuring the MAC addresses
> > in BFD state machine. Therein, the "b
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 35a9cd0..1f207f4 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.0.2 - 14 Aug 2014
+--
On Thu, Aug 14, 2014 at 10:50:55AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Justin Pettit
---
NEWS |4 ++--
debian/changelog |6 --
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index 206ddef..27c10f5 100644
--- a/NEWS
+++ b/NEWS
@@ -1,7 +1,7 @@
-v2.1.3 - xx xxx
+v2.1.3 - 14 Aug 2014
--
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 27c10f5..5a1c40e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.1.4 - xx xxx
+--
Yes, that is also shared between um-km.
Thanks!
Saurabh
From: Samuel Ghinet
mailto:sghi...@cloudbasesolutions.com>>
Date: Thursday, August 14, 2014 at 5:10 AM
To: Saurabh Shah mailto:ssaur...@vmware.com>>, Nithin Raju
mailto:nit...@vmware.com>>, Ankur Sharma
mailto:ankursha...@vmware.com>>
Cc:
On Thu, Aug 14, 2014 at 10:55:51AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Aug 14, 2014 at 10:55:52AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This commit adds more explanation for the bfd diagnostic and
bfd remote diagnostic in vswitch and vtep documentation.
Requested-by:Bruce Davie
Signed-off-by: Alex Wang
---
vswitchd/vswitch.xml | 10 ++
vtep/vtep.xml| 10 ++
2 files changed, 12 insertions(+), 8 deleti
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 7d6294d..39c6486 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.3.1 - xx xxx
+--
Signed-off-by: Justin Pettit
---
NEWS |2 +-
debian/changelog |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 6313ec5..7d6294d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-v2.3.0 - xx xxx
+v2.3.0 - 14 Aug 2014
Users should consider a later version of OVS for DPDK support.
Signed-off-by: Justin Pettit
---
INSTALL.DPDK |8
NEWS |3 +--
debian/changelog |2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/INSTALL.DPDK b/INSTALL.DPDK
index 3e0247a..67
On Thu, Aug 14, 2014 at 11:07:25AM -0700, Justin Pettit wrote:
> Users should consider a later version of OVS for DPDK support.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
On Thu, Aug 14, 2014 at 11:07:26AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Aug 14, 2014 at 11:07:27AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Ben Pfaff
---
debian/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/.gitignore b/debian/.gitignore
index b612eec..e8d9d31 100644
--- a/debian/.gitignore
+++ b/debian/.gitignore
@@ -17,5 +17,6 @@
/openvswitch-switch.copyright
/openvswitch-test
/openvswitch-
mininet uses the Open vSwitch controller by default, for testing.
CC: 757...@bugs.debian.org
Reported-at: https://bugs.debian.org/757761
Requested-by: Tomasz Buchert
Requested-by: Dariusz Dwornikowski
Signed-off-by: Ben Pfaff
---
FAQ| 7 +-
INS
The recent mailing list thread about MPLS reminded me that the FAQ needs an
update.
CC: Simon Horman
Signed-off-by: Ben Pfaff
---
FAQ | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/FAQ b/FAQ
index 3470983..d98c091 100644
--- a/FAQ
+++ b/FAQ
@@ -1239,12 +1239,
On Tue, Aug 12, 2014 at 01:37:07PM +0200, Tomasz Buchert wrote:
> On 11/08/14 14:28, Ben Pfaff wrote:
> > On Mon, Aug 11, 2014 at 08:17:19PM +0200, Dariusz Dwornikowski wrote:
> > > -BEGIN PGP SIGNED MESSAGE-
> > > Hash: SHA256
> > >
> > > On 11.08.2014 17:38, Ben Pfaff wrote:
> > > > On M
Hi Nithin,
I saw that Ben already applied this patch yesterday. However, I just have one
comment below.
> -Original Message-
> From: Nithin Raju [mailto:nit...@vmware.com]
> Sent: Tuesday, August 12, 2014 10:59 PM
> To: dev@openvswitch.org; Saurabh Shah
> Cc: Nithin Raju
> Subject: [PATC
These are 64-bit, not 32-bit, registers.
Signed-off-by: Ben Pfaff
---
lib/meta-flow.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/meta-flow.h b/lib/meta-flow.h
index 0af3888..c11f7ab 100644
--- a/lib/meta-flow.h
+++ b/lib/meta-flow.h
@@ -61,10 +61,10 @@ enum O
Acked-by: Jarno Rajahalme
> On Aug 14, 2014, at 11:47 AM, Ben Pfaff wrote:
>
> These are 64-bit, not 32-bit, registers.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/meta-flow.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/meta-flow.h b/lib/meta-flow.h
> ind
Thanks! Applied.
On Thu, Aug 14, 2014 at 11:55:44AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> > On Aug 14, 2014, at 11:47 AM, Ben Pfaff wrote:
> >
> > These are 64-bit, not 32-bit, registers.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/meta-flow.h | 8
> > 1
The README was not clear on whether the steps are for attaching physical
or virtual machines to the emulated VTEP. This adds more detail to the
README so that readers will know what to do if they want to attach physical
machines or otherwise.
Signed-off-by: Mark Maglana
---
vtep/README.ovs-vtep
On Thu, Aug 14, 2014 at 11:17 AM, Ben Pfaff wrote:
> The recent mailing list thread about MPLS reminded me that the FAQ needs an
> update.
>
> CC: Simon Horman
> Signed-off-by: Ben Pfaff
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
On August 14, 2014 at 10:52:20 AM, Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Aug 14, 2014 at 10:50:55AM -0700, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. Pushed.
--Justin
___
dev mailing list
dev@
On August 14, 2014 at 10:59:27 AM, Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Aug 14, 2014 at 10:55:52AM -0700, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed the series.
--Justin
___
dev mail
On August 14, 2014 at 11:11:15 AM, Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Aug 14, 2014 at 11:07:27AM -0700, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed the series.
--Justin
___
dev mail
On Thu, Aug 14, 2014 at 12:06 AM, Andy Zhou wrote:
> On Wed, Aug 13, 2014 at 10:19 PM, Pravin B Shelar wrote:
>> Currently on mask delete OVS moves last mask to the deleted
>> place to keep compact for per cpu cache. But this generate
>> duplicate entries in mask cache array which results in
>> m
On 08/14/14 at 09:22am, Ben Pfaff wrote:
> The real issue here is that you'd like to allow OFPACT_REG_MOVE to be
> part of an action set. That's fine. I have no objection. The only
> task is to decide where reg_move actions go in the ordering. Where do
> you want it? I get the impression that
On Thu, Aug 14, 2014 at 09:42:13PM +0200, Thomas Graf wrote:
> On 08/14/14 at 09:22am, Ben Pfaff wrote:
> > The real issue here is that you'd like to allow OFPACT_REG_MOVE to be
> > part of an action set. That's fine. I have no objection. The only
> > task is to decide where reg_move actions go
On August 14, 2014 at 11:16:51 AM, Ben Pfaff (b...@nicira.com) wrote:
> diff --git a/FAQ b/FAQ
> index 3470983..7fbf9a9 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -89,9 +89,10 @@ A: Distributed vswitch applications (e.g., VMware vNetwork
> distributed
> environments: OpenFlow, which exposes flow-based
On August 14, 2014 at 12:59:07 PM, Justin Pettit (jpet...@nicira.com) wrote:
> On August 14, 2014 at 11:16:51 AM, Ben Pfaff (b...@nicira.com) wrote:
>
> I assume this should be "ovs-\testcontroller".
Obviously, I meant that this should be "ovs\-testcontroller".
--Justin
__
Signed-off-by: Justin Pettit
---
INSTALL |2 +-
lib/ofp-msgs.c |2 +-
utilities/ovs-ctl.8 |6 +++---
utilities/ovs-save |2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/INSTALL b/INSTALL
index ede5488..7e0097b 100644
--- a/INSTALL
+++ b/INSTA
Signed-off-by: Justin Pettit
---
FAQ |2 +-
INSTALL.KVM |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/FAQ b/FAQ
index 3470983..e3085e8 100644
--- a/FAQ
+++ b/FAQ
@@ -591,7 +591,7 @@ A: A physical Ethernet device that is part of an Open
vSwitch bridge
v
On Thu, Aug 14, 2014 at 01:14:13PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Aug 14, 2014 at 01:14:12PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On August 14, 2014 at 1:15:25 PM, Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Aug 14, 2014 at 01:14:13PM -0700, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks for the quick reviews of these hard-hitting bugs. Pushed.
--Justin
__
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/OvsActions.c |2 +-
datapath-windows/ovsext/OvsSwitch.h |1 +
datapath-windows/ovsext/OvsUser.c|3 ++-
datapath-windows/ovsext/OvsVport.c | 10 +-
4 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/dat
> I saw that Ben already applied this patch yesterday. However, I just have one
> comment below.
Np. I'll take care of review comments in a followup patch.
>> +/*
>> + * Tx:
>> + * The destination port is a tunnel port. Encapsulation must be
>> + * performed only
On Thu, Aug 14, 2014 at 01:17:04PM -0700, Justin Pettit wrote:
> On August 14, 2014 at 1:15:25 PM, Ben Pfaff (b...@nicira.com) wrote:
> > On Thu, Aug 14, 2014 at 01:14:13PM -0700, Justin Pettit wrote:
> > > Signed-off-by: Justin Pettit
> >
> > Acked-by: Ben Pfaff
>
> Thanks for the quick rev
Treating OFPACT_REG_MOVE as a "set" action preserves the order of loads
and moves and allows a load to overwrite a previous move to the same
register.
This makes the following work:
add-group br0 group_id=1234,type=all, \
bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_IP_SRC[], \
On 08/14/14 at 12:43pm, Ben Pfaff wrote:
> On Thu, Aug 14, 2014 at 09:42:13PM +0200, Thomas Graf wrote:
> > On 08/14/14 at 09:22am, Ben Pfaff wrote:
> > > The real issue here is that you'd like to allow OFPACT_REG_MOVE to be
> > > part of an action set. That's fine. I have no objection. The only
On Thu, Aug 14, 2014 at 10:44:00PM +0200, Thomas Graf wrote:
> Treating OFPACT_REG_MOVE as a "set" action preserves the order of loads
> and moves and allows a load to overwrite a previous move to the same
> register.
>
> This makes the following work:
>
> add-group br0 group_id=1234,type=all, \
Good catch. I've fixed it and will merge soon.
Ethan
On Thu, Aug 14, 2014 at 9:49 AM, Ben Pfaff wrote:
> On Wed, Aug 13, 2014 at 06:46:17PM -0700, Ethan Jackson wrote:
>> This patch reorganizes ofproto-dpif in preparation for future patches
>> which allow direct upcall processing from dpif-netd
On Thu, Aug 14, 2014 at 12:03 PM, Mark Maglana wrote:
> The README was not clear on whether the steps are for attaching physical
> or virtual machines to the emulated VTEP. This adds more detail to the
> README so that readers will know what to do if they want to attach physical
> machines or othe
From: Mark Maglana
The README was not clear on whether the steps are for attaching physical
or virtual machines to the emulated VTEP. This adds more detail to the
README so that readers will know what to do if they want to attach physical
machines or otherwise.
Signed-off-by: Mark Maglana
Signe
Looks good, thanks.
Bruce
On Aug 14, 2014, at 11:02 AM, Alex Wang wrote:
> This commit adds more explanation for the bfd diagnostic and
> bfd remote diagnostic in vswitch and vtep documentation.
>
> Requested-by:Bruce Davie
> Signed-off-by: Alex Wang
> ---
> vswitchd/vswitch.xml | 10 +
On Thu, Aug 14, 2014 at 11:17:30AM -0700, Ben Pfaff wrote:
> The recent mailing list thread about MPLS reminded me that the FAQ needs an
> update.
>
> CC: Simon Horman
> Signed-off-by: Ben Pfaff
Acked-by: Simon Horman
> ---
> FAQ | 14 --
> 1 file changed, 8 insertions(+), 6 del
Thx, applied to master and branch-2.3.
On Thu, Aug 14, 2014 at 1:59 PM, Bruce Davie wrote:
> Looks good, thanks.
>
> Bruce
>
> On Aug 14, 2014, at 11:02 AM, Alex Wang wrote:
>
> > This commit adds more explanation for the bfd diagnostic and
> > bfd remote diagnostic in vswitch and vtep documen
Thank you for the quick feedback and the corrections. This looks good.
On Thu, Aug 14, 2014 at 1:05 PM, Gurucharan Shetty
wrote:
> From: Mark Maglana
>
> The README was not clear on whether the steps are for attaching physical
> or virtual machines to the emulated VTEP. This adds more detail t
Due to a typo, the latest upcall refactoring caused dpif_recv() to be
called on an un-initialized chunk of memory.
Signed-off-by: Ethan Jackson
Reported-by: Justin Pettit
---
ofproto/ofproto-dpif-upcall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-u
On Thu, Aug 14, 2014 at 03:49:55PM -0700, Ethan Jackson wrote:
> Due to a typo, the latest upcall refactoring caused dpif_recv() to be
> called on an un-initialized chunk of memory.
>
> Signed-off-by: Ethan Jackson
> Reported-by: Justin Pettit
Oops.
Acked-by: Ben Pfaff
___
On August 14, 2014 at 3:50:03 PM, Ethan Jackson (et...@nicira.com) wrote:
> Due to a typo, the latest upcall refactoring caused dpif_recv() to be
> called on an un-initialized chunk of memory.
>
> Signed-off-by: Ethan Jackson
> Reported-by: Justin Pettit
> ---
> ofproto/ofproto-dpif-upcall.c | 2
Treating OFPACT_REG_MOVE as a "set" action preserves the order of loads
and moves and allows a load to overwrite a previous move to the same
register.
This makes the following work:
add-group br0 group_id=1234,type=all, \
bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_IP_SRC[], \
Hi Nithin,
Changes look fine to me.
We should wait to see if alin/sam has some inputs on this.
Regards,
Ankur
From: dev on behalf of Nithin Raju
Sent: Wednesday, August 13, 2014 7:11 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/4] Add extenti
Hi Nithin,
Changes are fine (if we want to keep both devices till netlink integration is
done).
Lets wait for alin/sam's comments as well.
Regards,
Ankur
From: dev on behalf of Nithin Raju
Sent: Wednesday, August 13, 2014 7:11 PM
To: dev@openvswitch.o
The naming is a little confusing -
$ grep PORT_NO datapath-windows/include/OvsPub.h
#define OVS_DEFAULT_PORT_NO 0x
Looks good otherwise.
Thanks,
Saurabh
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
> Sent: Thursday, August 14, 2
HI Nithin,
Changes are fine.
Some minor comments on adding new commands.
a. I think we should add the cmd handler installation in following format:
/* Netlink control family: this is a Windows specific family. */
NETLINK_CMD nlControlFamilyCmdOps[] = {
{OVS_CTRL_CMD_WIN_GET_PID, OvsGetPidCm
Hi Nithin,
Changes are good, some minor comments:
a. minor comment: i think we should check for buf_in alloc failure before we
alloc for buf_out in line 79.
b. i think we should be using the library provided APIs for preparing the
netlink message (if possible). for eg: nl_msg_put_nlmsghdr
Rega
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
> Sent: Wednesday, August 13, 2014 7:12 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath
> interface
>
> The datapath interface defined in o
Naming the file OvsIoctl.[ch] seems much clearer to me. I don't know why these
files are being renamed. Also, if these are not going to be shared with the
userspace, you should drop the Ovs prefix from the file name.
Thanks,
Saurabh
> -Original Message-
> From: dev [mailto:dev-boun...@o
On Aug 14, 2014, at 4:41 PM, Ankur Sharma
wrote:
> Changes are fine (if we want to keep both devices till netlink integration
> is done).
> Lets wait for alin/sam's comments as well.
Thanks. I am keeping the 2 devices, since that is what we communicated in the
design document. I'll check wit
Alin,
Thanks for making this change. It is great that we can build via command line
now.
Some comments I had are:
1. Somewhere at the top we should mention that the 'forwarding extension' is a
'kernel driver'. For someone now familiar with Windows, it might make it more
obvious as to which is t
On Aug 14, 2014, at 5:01 PM, Saurabh Shah
wrote:
>> +#define OVS_DEVICE_NAME_USER TEXT(".\\OpenVSwitchDevice")
>> +
>
> Should be "OpenvSwitchDevice".
Sure. I'll change this.
>> +#ifdef _WIN32
>> +#include "OvsDpInterfaceExt.h"
>> +#endif
>
> Since we define & control the dp interface,
On Aug 14, 2014, at 5:56 PM, Nithin Raju
wrote:
>> Since we define & control the dp interface, why not just include
>> OvsDpInterfaceExt.h directly? (Just like what we used to do earlier by
>> including OvsPub.h.)
>
> If we include OvsDpInterfaceExt.h, we'll have to have a #ifdef _WIN32. IMO,
Hi Nithin,
> -Original Message-
> From: Nithin Raju
> Sent: Thursday, August 14, 2014 5:56 PM
> To: Saurabh Shah
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/4] Add extentions to the standard datapath
> interface
>
> On Aug 14, 2014, at 5:01 PM, Saurabh Shah
> wrote:
> >>
On Aug 14, 2014, at 4:46 PM, Saurabh Shah
wrote:
> $ grep PORT_NO datapath-windows/include/OvsPub.h
> #define OVS_DEFAULT_PORT_NO 0x
I named it the way you had suggested initially, then changed it to
OVS_VPORTNO_DEFAULT, since other constants in the file were named like
OVS__DEFAULT_
We should change the name of the class to dpif_netlink_class and rename
dpif-linux to dpif-netlink.
Saurabh
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin
> Serdean
> Sent: Wednesday, August 13, 2014 8:17 AM
> To: dev@openvswitch.org
> Subject: [o
On a related note, while I see the log which says its stamping the local time
in INF file. The actual DriverVer in the INF remains unchanged. Not sure why.
I don't know what the build problem is. But if it fixes your problem. :)
Acked-by: Saurabh Shah
> -Original Message-
> From: dev [m
Can your rename OVS_VPORTNO_DEFAULT to something else? Having two defaults with
similar name, but different value is confusing.
Thanks,
Saurabh
> -Original Message-
> From: Nithin Raju
> Sent: Thursday, August 14, 2014 6:16 PM
> To: Saurabh Shah
> Cc: dev@openvswitch.org
> Subject: Re: [
On Aug 14, 2014, at 4:53 PM, Ankur Sharma
wrote:
> a. I think we should add the cmd handler installation in following format:
>
> /* Netlink control family: this is a Windows specific family. */
> NETLINK_CMD nlControlFamilyCmdOps[] = {
>{OVS_CTRL_CMD_WIN_GET_PID, OvsGetPidCmdHandler, OVS_TR
On Aug 14, 2014, at 5:08 PM, Saurabh Shah
wrote:
> Naming the file OvsIoctl.[ch] seems much clearer to me. I don't know why
> these files are being renamed. Also, if these are not going to be shared with
> the userspace, you should drop the Ovs prefix from the file name.
hi Saurabh,
The legac
The datapath interface defined in odp-netlink.h needs some extensions
that are platform dependent. Some examples are the name of the communication
device on Windows and a set of commands that are specific to Windows.
In this change we define a include/odp-netlink-ext.h to in turn include
any platf
To verify if the netlink support in the kernel works, I updated
the netlink-socket.c code to get the PID for a given device
descriptor.
In the existing code, userspace sets the PID, which will not be
unique across different processes. So, it is better for the
kernel to generate the PID and give it
In this change we create peer to OvsIoctl.[ch] that would interface
with userspace using the netlink interface. The new files are called
Datapath.[ch]. We are not deleting OvsIoctl.[ch] yet. Datapath.[ch]
provides bare minimum functionality to register a pseudo device for
communication with userspa
In this change, we define netlink families and commands supported
by the Windows datapath. Only the control family and one command
is supported today to get the PID.
We also implement the 3 ioctls: read, write and transact. This is
bare minimum and can be used to implement the equivalent of a
recv
On Aug 14, 2014, at 7:03 PM, Saurabh Shah
wrote:
> Can your rename OVS_VPORTNO_DEFAULT to something else? Having two defaults
> with similar name, but different value is confusing.
My bad, I didn't realize that you had pointed me to OVS_DEFAULT_PORT_NO
earlier. New patch will be up on a bit.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/OvsActions.c |2 +-
datapath-windows/ovsext/OvsUser.c|3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/OvsActions.c
b/datapath-windows/ovsext/OvsActions.c
index 635becc..321f53a 100644
Signed-off-by: Joe Stringer
---
datapath/flow_table.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/flow_table.c b/datapath/flow_table.c
index 7046623..f80e889 100644
--- a/datapath/flow_table.c
+++ b/datapath/flow_table.c
@@ -446,7 +446,7 @@ static void flow_tab
This allows future patches to reuse the nla error detection code, by
passing their own definitions for expected attribute lengths and types.
Signed-off-by: Joe Stringer
---
datapath/flow_netlink.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff
Hi Samuel,
Thanks for your patience. I believe all of your concerns are arising due
to a fundamental misunderstanding of the NDIS apis & the buffer management
code. I thought it would useful if I walk you through the
OvsPartialCopyNBL logic by giving an example.
Let's say there is a ca
Signed-off-by: Joe Stringer
---
datapath/flow_netlink.c | 85 ++-
1 file changed, 39 insertions(+), 46 deletions(-)
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 933b2a1..01f6e49 100644
--- a/datapath/flow_netlink.c
+++ b/datap
On 14 August 2014 10:22, Pravin Shelar wrote:
>
> Can you move this definition next to ovs_key_lens definition.
>
> otherwise looks good.
> Acked-by: Pravin B Shelar
Thanks, I made this change and pushed this to master.
___
dev mailing list
dev@openvs
93 matches
Mail list logo
