On Aug 14, 2014, at 5:01 PM, Saurabh Shah <ssaur...@vmware.com>
wrote:
>> +#define OVS_DEVICE_NAME_USER TEXT("\\\\.\\OpenVSwitchDevice")
>> +
>
> Should be "OpenvSwitchDevice".
Sure. I'll change this.
>> +#ifdef _WIN32
>> +#include "OvsDpInterfaceExt.h"
>> +#endif
>
> Since we define & control the dp interface, why not just include
> OvsDpInterfaceExt.h directly? (Just like what we used to do earlier by
> including OvsPub.h.)
If we include OvsDpInterfaceExt.h, we'll have to have a #ifdef _WIN32. IMO, it
is neater to not do this. One more reason is that, we'll want to generate a
odp-netlink-ext.h in the future from OvsDpInterfaceExt.h, similar to how we
generate odp-netlink.h from openvswitch.h.
thanks,
Nithin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
