Re: [ovs-dev] [PATCH] ofproto-dpif: Remove unneeded bundle_remove() from port_del().

2013-10-27 Thread Alex Wang
Have few questions, >From my understanding, after the "port_del()" is executed, the following function invocation sequence is: "ofproto_port_del()" -> "update_port()" ->"ofport_remove_with_name()" -> "ofport_remove()" -> "ofport_destroy()" -> "port_destruct()" And in "port_destruct()", the "bundl

Re: [ovs-dev] [PATCH v2.45 1/4] odp: Allow VLAN actions after MPLS actions

2013-10-27 Thread Simon Horman
On Fri, Oct 25, 2013 at 03:34:41PM +0100, Simon Horman wrote: > From: Joe Stringer > > OpenFlow 1.1 and 1.2, and 1.3 differ in their handling of MPLS actions in the > presence of VLAN tags. To allow correct behaviour to be committed in > each situation, this patch adds a second round of VLAN tag

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: Implement group callbacks

2013-10-27 Thread Simon Horman
On Mon, Oct 21, 2013 at 01:59:12PM -0700, Ben Pfaff wrote: > On Tue, Oct 15, 2013 at 05:17:48PM +0900, Simon Horman wrote: > > This is a first step towards implementing the dpif side of groups. > > > > In order to be useful the action translation code needs > > to be taught about groups. > > > >

Re: [ovs-dev] [PATCH v7 2/3] Translation of indirect and all groups

2013-10-27 Thread Simon Horman
On Mon, Oct 21, 2013 at 02:46:15PM -0700, Ben Pfaff wrote: > On Tue, Oct 15, 2013 at 05:17:49PM +0900, Simon Horman wrote: > > Allow translation of indirect and all groups. Also allow insertion of > > indirect and all groups by changing the maximum permitted number in the > > groups table from 0 t

Re: [ovs-dev] [PATCH v7 3/3] Translation of fast failover groups

2013-10-27 Thread Simon Horman
On Mon, Oct 21, 2013 at 03:04:25PM -0700, Ben Pfaff wrote: > On Tue, Oct 15, 2013 at 05:17:50PM +0900, Simon Horman wrote: > > Fast failover groups use the actions in > > the first bucket that is alive. > > > > Signed-off-by: Simon Horman > > Please make bucket_is_alive() log a rate-limited warn

Re: [ovs-dev] [PATCH] classifier: Update thread safety notes.

2013-10-27 Thread Alex Wang
LGTM On Wed, Sep 25, 2013 at 3:38 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/classifier.h |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/classifier.h b/lib/classifier.h > index a795b4a..8c77a93 100644 > --- a/lib/classifier.h > +++ b/lib

Re: [ovs-dev] [PATCH v2 0/2] Give miss handler threads unique names.

2013-10-27 Thread Alex Wang
Just reminder, I think this series is ready to be applied, LGTM as well, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v7 3/3] Translation of fast failover groups

2013-10-27 Thread P Balaji-B37839
Hi Simon, Can I take HEAD and start exploring on groups. I want to try this for VXLAN and 'flow based tunneling'. Regards, Balaji.P > -Original Message- > From: Simon Horman [mailto:ho...@verge.net.au] > Sent: Monday, October 28, 2013 8:19 AM > To: Ben Pfaff > Cc: dev@openvswitch.org; N

Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel structures (for GRE, VXLAN etc.)

2013-10-27 Thread Neil Mckee
On Oct 25, 2013, at 3:31 PM, Jesse Gross wrote: > On Fri, Oct 25, 2013 at 10:49 AM, Romain Lenglet wrote: >> On Oct 24, 2013, at 5:46 PM, Jesse Gross wrote: >> >>> On Thu, Oct 24, 2013 at 3:39 PM, Romain Lenglet wrote: - Original Message - > From: "Jesse Gross" > To: "Ro