[ovs-dev] [PATCH 0/9 v2.8] Basic MPLS actions and matches

2012-11-28 Thread Simon Horman
Hi, This series implements basic MPLS actions and matches based on work by Ravi K, Leo Alterman and Yamahata-san. The main limitation of this implementation is that it only supports manipulating the outer-most MPLS label. Key difference between the previous post, v2.8: * Rebase to allow compila

[ovs-dev] [PATCH 6/6] Add support for copy_ttl_in action

2012-11-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ copy_ttl_in action. And also adds an NX copy_ttl_out action. The implementation does not support copying in the case where the outermost header is IP as it is unclear to me that Open vSwtich has a notion of an inner IP header to copy the TLL from. The imple

[ovs-dev] [PATCH 5/6] Add support for copy_ttl_out action

2012-11-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ copy_ttl_out action. And also adds an NX copy_ttl_out action. The implementation does not support copying in the case where the outermost header is IP as it is unclear to me that Open vSwtich has a notion of an inner IP header to copy the TLL from. The hand

[ovs-dev] [PATCH 1/6] datapath: Add basic MPLS support to kernel

2012-11-28 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.9 * datapath: Alway

[ovs-dev] [PATCH 4/6] Add support for set_mpls_ttl action

2012-11-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ set_mpls_ttl action. And also adds an NX set_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.9 * Update tests for upstream changes v2.8 * No change

[ovs-dev] [PATCH 3/6] Add support for dec_mpls_ttl action

2012-11-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. And also adds an NX dec_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.9 * Update tests for upstream changes v2.8 * No change

[ovs-dev] Adding STP option support for RHEL ovs-ifup

2012-11-28 Thread Andres Toomsalu
Hi, Here is a small patch for adding STP option support for RHEL ovs-ifup script. Follows RHEL device STP option as it worked before with standard linux bridge - eg bridge ifcfg-brX should contain STP=on | off | yes | no | true | false rhel_stp_option.patch Description: Binary data Regards, --

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 5:13 PM, Jesse Gross wrote: > On Tue, Nov 27, 2012 at 12:19 PM, Kyle Mestery wrote: >> Note: v4 of this patch removes VXLAN over IPSEC support, >> per an offline conversation with Jesse. >> >> Add support for VXLAN tunnels to Open vSwitch. Add support >> for setting the des

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > * Kyle Mestery (kmest...@cisco.com) wrote: >> @@ -23,6 +23,7 @@ >> /kmemdup.c >> /loop_counter.c >> /modules.order >> +/net_namespace.c >> /netdevice.c >> /net_namespace.c >> /random32.c > > spurious change? > >> @@ -39,5 +40,6 @@ >> /vport-in

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > > * Kyle Mestery (kmest...@cisco.com) wrote: > >> + > >> + vxlan_port->port = dst_port; > >> + vxlan_port->count++; > >> + hlist_add_head(&vxlan_port->hash_node, > >> + vxl

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 28, 2012, at 10:34 AM, Chris Wright wrote: > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: >> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: >>> * Kyle Mestery (kmest...@cisco.com) wrote: + + vxlan_port->port = dst_port; + vxlan_port->count++; + hlist_add_

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 28, 2012, at 10:34 AM, Chris Wright > wrote: > > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > >> On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > >>> * Kyle Mestery (kmest...@cisco.com) wrote: > + > +vx

[ovs-dev] [PATCH net 1/2] openvswitch: Print device when warning about over MTU packets.

2012-11-28 Thread Jesse Gross
If an attempt is made to transmit a packet that is over the device's MTU then we log it using the datapath's name. However, it is much more helpful to use the device name instead. Signed-off-by: Jesse Gross --- net/openvswitch/vport-netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[ovs-dev] [GIT net] Open vSwitch

2012-11-28 Thread Jesse Gross
These two small bug fixes are intended for 3.7/net if there is still time. The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openv

[ovs-dev] [PATCH net 2/2] openvswitch: Store flow key len if ARP opcode is not request or reply.

2012-11-28 Thread Jesse Gross
From: Mehak Mahajan We currently only extract the ARP payload if the opcode indicates that it is a request or reply. However, we also only set the key length in these situations even though it should still be possible to match on the opcode. There's no real reason to restrict the ARP opcode sin

Re: [ovs-dev] [GIT net] Open vSwitch

2012-11-28 Thread David Miller
Date: Tue, 27 Nov 2012 10:37:01 -0800 Is it really Tuesday morning where you are? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [GIT net] Open vSwitch

2012-11-28 Thread Jesse Gross
On Wed, Nov 28, 2012 at 10:48 AM, David Miller wrote: > > Date: Tue, 27 Nov 2012 10:37:01 -0800 > > Is it really Tuesday morning where you are? Unfortunately, no. It's VM clock slew, which I've fixed now. ___ dev mailing list dev@openvswitch.org http:/

[ovs-dev] [PATCH] datapath: Use RCU callback when detaching netdevices.

2012-11-28 Thread Jesse Gross
Currently, each time a device is detached from an OVS datapath we call synchronize RCU before freeing associated data structures. However, if a bridge is deleted (which detaches all ports) when many devices are connected then there can be a long delay. This switches to use call_rcu() to group the

[ovs-dev] Google: Top 10 Free Tools (SEO techniques to improve your ranking)

2012-11-28 Thread J. McDonald
Hi, I'd like to invite you to our upcoming free webcast on the "Top 10 Free Tools for SEO / Google Rank" being held online in the next few weeks. Register for this no cost web event on Google / SEO - http://www.s-e-o-webinar-online.net/1/nov28.html?dev@openvswitch.org Google is by far the #1 w

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 28, 2012, at 11:01 AM, Chris Wright wrote: > * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: >> On Nov 28, 2012, at 10:34 AM, Chris Wright >> wrote: >>> * Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > * Kyle Mestery

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 28, 2012, at 11:01 AM, Chris Wright wrote: > > Right. OTV is commonly, but not exclusively, used now. Post draft > > we should expect a final port number. But it's a relatively small set > > of functionality to maintain to keep the

[ovs-dev] Здравейте,

2012-11-28 Thread Sonia Luv
Приятен ден за вас, Аз съм Соня. Аз съм късметлия да влезем в контакт с вас чрез вашия имейл адрес, за хора, естествено се стремят да бъдат изпълнени с радост. Това е наистина голям, искам да бъда твой приятел ... моля, моля напишете обратно към мен за по-нататъшно общуване, имат приятен ден! Тъй

Re: [ovs-dev] [PATCH] datapath: Use RCU callback when detaching netdevices.

2012-11-28 Thread Ben Pfaff
On Wed, Nov 28, 2012 at 12:25:07PM -0800, Jesse Gross wrote: > Currently, each time a device is detached from an OVS datapath > we call synchronize RCU before freeing associated data structures. > However, if a bridge is deleted (which detaches all ports) when > many devices are connected then ther

Re: [ovs-dev] [PATCH] datapath: Use RCU callback when detaching netdevices.

2012-11-28 Thread Jesse Gross
On Wed, Nov 28, 2012 at 1:43 PM, Ben Pfaff wrote: > On Wed, Nov 28, 2012 at 12:25:07PM -0800, Jesse Gross wrote: >> Currently, each time a device is detached from an OVS datapath >> we call synchronize RCU before freeing associated data structures. >> However, if a bridge is deleted (which detache

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery (kmestery)
On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > * Kyle Mestery (kmest...@cisco.com) wrote: >> @@ -23,6 +23,7 @@ >> /kmemdup.c >> /loop_counter.c >> /modules.order >> +/net_namespace.c >> /netdevice.c >> /net_namespace.c >> /random32.c > > spurious change? > >> @@ -39,5 +40,6 @@ >> /vport-in

[ovs-dev] [PATCH v5] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Kyle Mestery
Note: v5 of this patch addresses comments from Jesse and Chris. Note: v4 of this patch removes VXLAN over IPSEC support, per an offline conversation with Jesse. Add support for VXLAN tunnels to Open vSwitch. Add support for setting the destination UDP port on a per-port basis. This is done by add

Re: [ovs-dev] [GIT net] Open vSwitch

2012-11-28 Thread David Miller
From: Jesse Gross Date: Tue, 27 Nov 2012 10:37:01 -0800 > These two small bug fixes are intended for 3.7/net if there is still time. Pulled, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Chris Wright
* Kyle Mestery (kmestery) (kmest...@cisco.com) wrote: > On Nov 27, 2012, at 9:24 PM, Chris Wright wrote: > > * Kyle Mestery (kmest...@cisco.com) wrote: > >> + udp_encap_enable(); > > > > This is a new function, did you provide a fallback/noop (since it looks > > like it's meant to build back to

Re: [ovs-dev] Possible user-space datapath regression

2012-11-28 Thread Simon Horman
Thanks, let me know if you need any more information from me. On Tue, Nov 27, 2012 at 10:31:17PM -0600, Justin Pettit wrote: > Hi, Simon. I've confirmed the problem you found and am looking into it. > Unfortunately, I'm traveling this week for work, so I may have limited time > to look at it u

[ovs-dev] [PATCH] bridge: Lower default address message to INFO.

2012-11-28 Thread Ethan Jackson
This message occurs during normal operation of the switch and shouldn't be cause for alarm. There's no reason for it to be at warn level and needlessly alarm users. Signed-off-by: Ethan Jackson --- vswitchd/bridge.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd

Re: [ovs-dev] [PATCH] bridge: Lower default address message to INFO.

2012-11-28 Thread Ben Pfaff
On Wed, Nov 28, 2012 at 05:06:41PM -0800, Ethan Jackson wrote: > This message occurs during normal operation of the switch and > shouldn't be cause for alarm. There's no reason for it to be at > warn level and needlessly alarm users. > > Signed-off-by: Ethan Jackson I believe that this conflict

Re: [ovs-dev] [tests 05/22] bridge: Drop warning about the default bridge Ethernet address.

2012-11-28 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Oct 25, 2012 at 5:02 PM, Ben Pfaff wrote: > This information is also available via ovs-ofctl and through other means, > and it's not really anything we need to warn about anyhow. > > Signed-off-by: Ben Pfaff > --- > vswitchd/bridge.c | 10 -- > 1 fi

Re: [ovs-dev] [PATCH] bridge: Lower default address message to INFO.

2012-11-28 Thread Ethan Jackson
Indeed, sorry we're so far behind on reviewing. Ethan On Wed, Nov 28, 2012 at 5:13 PM, Ben Pfaff wrote: > On Wed, Nov 28, 2012 at 05:06:41PM -0800, Ethan Jackson wrote: > > This message occurs during normal operation of the switch and > > shouldn't be cause for alarm. There's no reason for it

Re: [ovs-dev] [PATCH v5] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-28 Thread Jesse Gross
On Wed, Nov 28, 2012 at 2:53 PM, Kyle Mestery wrote: > Note: v5 of this patch addresses comments from Jesse > and Chris. > > Note: v4 of this patch removes VXLAN over IPSEC support, > per an offline conversation with Jesse. > > Add support for VXLAN tunnels to Open vSwitch. Add support > for setti

[ovs-dev] [of1.2 0/9] OF1.2 series (based on Simon's)

2012-11-28 Thread Ben Pfaff
Simon, here's a revision of the remaining patches in your most recent posting of your OpenFlow 1.2 series. Will you please look it over, especially the patches that I added? If you think it's good, then I'm ready to push it to master. I think these are the only outstanding patches that you're wa

[ovs-dev] [of1.2 1/9] ofp-version-opt: Fix wrong information in usage message.

2012-11-28 Thread Ben Pfaff
This is my fault; I introduced this inconsistency when I modified Simon's correct patch. Signed-off-by: Ben Pfaff --- lib/ofp-version-opt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-version-opt.c b/lib/ofp-version-opt.c index 1801e9f..0aa2930 100644 --- a/lib

[ovs-dev] [of1.2 2/9] ovs-ofctl: Add option to set allowed OpenFlow versions

2012-11-28 Thread Ben Pfaff
From: Simon Horman --allowed-ofp-versions allows configuration of the versions that may be used when establishing an OpenFlow connection. The default is 'OpenFlow10' which is consistent with the behaviour prior to this patch. The useful values at this time are: 'OpenFlow10', 'OpenFlow12' and 'O

[ovs-dev] [of1.2 4/9] ofp-util: Make "OXM" flow format name include both OpenFlow 1.2 and 1.3.

2012-11-28 Thread Ben Pfaff
To my mind, it makes sense, when a user requests OXM as the flow format, to allow any protocol based on the OXM flow format to be used. Until this commit, however, "OXM" was specifically OpenFlow 1.2, and "OpenFlow13" was required to request OXM on OpenFlow 1.3. This doesn't affect the behavior o

[ovs-dev] [of1.2 5/9] ofp-util: New functions for converting protocols to and from versions.

2012-11-28 Thread Ben Pfaff
The values of enum ofputil_protocol have meanings that overlap with OpenFlow version numbers. These new functions provide ways to figure out these overlaps. These functions will be used for the first time in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 56 +++

[ovs-dev] [of1.2 3/9] ofp-util: Style fixes.

2012-11-28 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-util.c |2 +- lib/ofp-util.h |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 0b96eb6..edac120 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -583,7 +583,7 @@ struct proto_abbrev { stati

[ovs-dev] [of1.2 6/9] ovs-ofctl: Reject impossible protocols configurations at startup.

2012-11-28 Thread Ben Pfaff
The -O and -F options interact, so that it's possible to select only flow formats that are not supported on a given OpenFlow version. It seems best to report these problems up front rather than failing in a more mysterious way later. Signed-off-by: Ben Pfaff --- lib/ofp-version-opt.c |6 +++

[ovs-dev] [of1.2 7/9] ovs-controller: Allow setting of allowed OpenFlow versions

2012-11-28 Thread Ben Pfaff
From: Simon Horman --allowed-ofp-versions allows configuration of the versions that may be used when establishing an OpenFlow connection. The default is 'OpenFlow10' which is consistent with the behaviour prior to this patch. The useful values at this time are: 'OpenFlow10', 'OpenFlow12' and 'O

[ovs-dev] [of1.2 9/9] test: add ofproto OpenFlow1.2 tests

2012-11-28 Thread Ben Pfaff
From: Simon Horman These were useful in isolating a number of bugs. Signed-off-by: Simon Horman Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at |2 +- tests/ofproto.at| 595 --- 2 files changed, 562 insertions(+), 35 deletions(-)

[ovs-dev] [of1.2 8/9] ovs-ofctl: By default, do not set flow format for OpenFlow 1.1+

2012-11-28 Thread Ben Pfaff
From: Simon Horman Only set the default format for ovs-ofctl monitor if OpenFlow 1.0 is the prevailing version. IMHO that is the only case where it makes sense. Signed-off-by: Simon Horman Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c | 39 ++- 1 fil

Re: [ovs-dev] [of1.2 0/9] OF1.2 series (based on Simon's)

2012-11-28 Thread Simon Horman
On Wed, Nov 28, 2012 at 11:06:47PM -0800, Ben Pfaff wrote: > Simon, here's a revision of the remaining patches in your most > recent posting of your OpenFlow 1.2 series. Will you please > look it over, especially the patches that I added? If you think > it's good, then I'm ready to push it to mas

[ovs-dev] [PATCH] ofp-actions: Add OpenFlow1.1+ Set Queue action

2012-11-28 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/ofp-actions.c |5 + lib/ofp-parse.c |5 + lib/ofp-util.def |2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 170e796..efb2502 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-act

Re: [ovs-dev] [of1.2 1/9] ofp-version-opt: Fix wrong information in usage message.

2012-11-28 Thread Simon Horman
On Wed, Nov 28, 2012 at 11:06:48PM -0800, Ben Pfaff wrote: > This is my fault; I introduced this inconsistency when I modified Simon's > correct patch. > > Signed-off-by: Ben Pfaff Acked-by: Simon Horman > --- > lib/ofp-version-opt.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [ovs-dev] [of1.2 3/9] ofp-util: Style fixes.

2012-11-28 Thread Simon Horman
On Wed, Nov 28, 2012 at 11:06:50PM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Simon Horman > --- > lib/ofp-util.c |2 +- > lib/ofp-util.h |3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/ofp-util.c b/lib/ofp-util.c > index 0b96eb6..edac

Re: [ovs-dev] [of1.2 2/9] ovs-ofctl: Add option to set allowed OpenFlow versions

2012-11-28 Thread Simon Horman
On Wed, Nov 28, 2012 at 11:06:49PM -0800, Ben Pfaff wrote: > From: Simon Horman > > --allowed-ofp-versions allows configuration of the versions > that may be used when establishing an OpenFlow connection. > > The default is 'OpenFlow10' which is consistent with > the behaviour prior to this patc