[ovs-dev] [PATCH] ofproto: Add del-flow based on table-id tests

2012-10-01 Thread Simon Horman
Signed-off-by: Simon Horman --- tests/ofproto.at | 32 1 file changed, 32 insertions(+) diff --git a/tests/ofproto.at b/tests/ofproto.at index fb82e01..455077b 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -362,6 +362,38 @@ NXST_FLOW reply: OVS_VSWIT

[ovs-dev] [PATCH] ofp-util: Use table_id in OF1.2 Flow Remove Messages

2012-10-01 Thread Simon Horman
Previously this field was ignored on decode and set to zero on encode Also add OFPTT_ALL and OFPTT_MAX and use OFPTT_ALL in the one location where it seems appropriate. Signed-off-by: Simon Horman --- include/openflow/openflow-1.1.h |9 + lib/ofp-print.c |4

[ovs-dev] [PATCH] vswitch: allow to specify ofport when creating port

2012-10-01 Thread Isaku Yamahata
For stable bridge configuration, sometimes it is desirable to be able to add-port with port number specified. This patch implements it and it can be done by setting ofport column of Interface table like ovs-vsctl add-port s1 eth2 -- set Interface eth2 ofport=10 Signed-off-by: Isaku Yamahata -

Re: [ovs-dev] [PATCH 2/4] dpif-netdev: Add SCTP support

2012-10-01 Thread Joe Stringer
On 28 September 2012 04:53, Ben Pfaff wrote: > "sparse" reports a potential byte-swapping error: I would imagine this is because the CRC32C implementation I introduced in patch #1 purports to calculate checksums in HBO. Perhaps that should be modified to use ovs_be32? > It looks to me like the S

Re: [ovs-dev] [PATCH 3/4] dpif-linux: Add SCTP support

2012-10-01 Thread Joe Stringer
On 28 September 2012 04:53, Ben Pfaff wrote: > On Fri, Aug 31, 2012 at 10:44:28PM +1200, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > I think this one needs a review from Jesse. This will have the same checksum calculation errors as patch #2: http://openvswitch.org/pipermail/dev/2012-S

Re: [ovs-dev] [PATCH 4/4] ofp-util: Support matching on SCTP src, dst ports

2012-10-01 Thread Joe Stringer
Cheers. This patch no longer applies cleanly on master, so I'll tidy that up and update NEWS when I repost the set. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] "brctl show" doesn't list attached interfaces

2012-10-01 Thread Tadaaki Nagao
Hi Pravin, In "Re: [ovs-dev] "brctl show" doesn't list attached interfaces", Pravin Shelar wrote: > On Thu, Sep 27, 2012 at 8:18 PM, Tadaaki Nagao > wrote: > > Hi, > > > > In "Re: [ovs-dev] "brctl show" doesn't list attached interfaces", > > Jesse Gross wrote: > >> I think it's the opp

[ovs-dev] Check out my music

2012-10-01 Thread HUSTLEMANN
http://cache.reverbnation.com/widgets/swf/48/pro_widget.swf?id=artist_2782324&posted_by=artist_2782324&skin_id=PWFS5010&background_color=EE&border_color=00&auto_play=false&shuffle=false";>http://cache.reverbnation.com/widgets/swf/48/pro_widget.swf?id=artist_2782324&posted_by=artist_2782324

[ovs-dev] [PATCH 0/2] Add flow-based tunneling support

2012-10-01 Thread Kyle Mestery
These patches build on the first two patches which Simon Horman sent out in May to move Open vSwitch towards flow-based tunneling. The first patche adds a tun_key, deprecating the tun_id member of the ovs_skb_cb struct. This patche retain compatibilty with existing tunneling, but once the userspace

[ovs-dev] [PATCH 2/2] Add flow matching for tunnel keys

2012-10-01 Thread Kyle Mestery
Move struct ovs_key_ipv4_tunnel out of struct sw_flow_key and into struct sw_flow. This allows it to "float" and be used for matching only when needed. Modify the matching code in ovs_flow_tbl_lookup() to match on the tunnel header if it's set. --- V2: Remove lib/odp-util.c changes in favor of usi

[ovs-dev] [PATCH 1/2] Add support for tun_key to OVS datapath

2012-10-01 Thread Kyle Mestery
This is a first pass at providing a tun_key which can be used as the basis for flow-based tunnelling. The tun_key includes and replaces the tun_id in both struct ovs_skb_cb and struct sw_tun_key. This patch allows all existing tun_id behaviour to still work. Existing users of tun_id are redirected

Re: [ovs-dev] [PATCH] ofproto: Add del-flow based on table-id tests

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 04:24:21PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Applied to master, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofp-util: Use table_id in OF1.2 Flow Remove Messages

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 04:51:49PM +0900, Simon Horman wrote: > Previously this field was ignored on decode and > set to zero on encode > > Also add OFPTT_ALL and OFPTT_MAX and use OFPTT_ALL in the one location > where it seems appropriate. > > Signed-off-by: Simon Horman Thanks for adding this

Re: [ovs-dev] [PATCH] vswitch: allow to specify ofport when creating port

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 05:35:19PM +0900, Isaku Yamahata wrote: > For stable bridge configuration, sometimes it is desirable to be able to > add-port with port number specified. > This patch implements it and it can be done by setting ofport column of > Interface > table like > > ovs-vsctl add-

Re: [ovs-dev] [PATCH 2/4] dpif-netdev: Add SCTP support

2012-10-01 Thread Ben Pfaff
On Tue, Oct 02, 2012 at 12:44:53AM +1300, Joe Stringer wrote: > On 28 September 2012 04:53, Ben Pfaff wrote: > > "sparse" reports a potential byte-swapping error: > > I would imagine this is because the CRC32C implementation I introduced > in patch #1 purports to calculate checksums in HBO. Perha

[ovs-dev] [PATCH 1/2] ovs-ctl: Add support for glibc malloc debugging.

2012-10-01 Thread Ben Pfaff
Unlike valgrind, glibc's built-in features for malloc debugging are cheap enough that one can run with them enabled all the time, at least in test scenarios. Signed-off-by: Ben Pfaff --- utilities/ovs-ctl.8 |8 +++- utilities/ovs-lib.in |3 +++ 2 files changed, 10 insertions(+), 1 d

[ovs-dev] [PATCH 2/2] tests: Enable glibc malloc debugging features in testsuite.

2012-10-01 Thread Ben Pfaff
I don't know of a reason not to use these features for testing. Signed-off-by: Ben Pfaff --- tests/atlocal.in |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index 5360225..8d0f59d 100644 --- a/tests/atlocal.in +++ b/tests/atlocal

Re: [ovs-dev] [PATCH 2/2] tests: Enable glibc malloc debugging features in testsuite.

2012-10-01 Thread Kyle Mestery (kmestery)
On Oct 1, 2012, at 1:03 PM, Ben Pfaff wrote: > I don't know of a reason not to use these features for testing. > > Signed-off-by: Ben Pfaff Both of these look good to me Ben. As a style nit, any reason not to combine setting and exporting the variables on the same line? Acked-by: Kyle Mestery

[ovs-dev] Fedora RPM specfile changes

2012-10-01 Thread Kyle Mestery (kmestery)
I'm looking at adding support for building RPMs from the upstream OVS for Fedora systems now. One question I have, and this may apply more to the Fedora folks who lurk on this list than the OVS folks, is how much does it matter how close the RPM build of upstream OVS matches the one in the Fedora p

[ovs-dev] [PATCH] FAQ: Describe how bonded ports interact with OpenFlow.

2012-10-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- FAQ | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/FAQ b/FAQ index a98739c..b14bfa4 100644 --- a/FAQ +++ b/FAQ @@ -747,6 +747,27 @@ A: ovs-dpctl queries a kernel datapath, not an OpenFlow switch. It won't display th

Re: [ovs-dev] [PATCH] FAQ: Describe how bonded ports interact with OpenFlow.

2012-10-01 Thread Kyle Mestery (kmestery)
On Oct 1, 2012, at 3:18 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Nice explanation, this is something interesting to work on, if I have time, I may take this up. Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch

Re: [ovs-dev] [PATCH] FAQ: Describe how bonded ports interact with OpenFlow.

2012-10-01 Thread Ethan Jackson
Acked-by: Ethan Jackson On Mon, Oct 1, 2012 at 1:18 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > FAQ | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/FAQ b/FAQ > index a98739c..b14bfa4 100644 > --- a/FAQ > +++ b/FAQ > @@ -747,6 +747

Re: [ovs-dev] [PATCH] FAQ: Describe how bonded ports interact with OpenFlow.

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 08:20:15PM +, Kyle Mestery (kmestery) wrote: > On Oct 1, 2012, at 3:18 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > > Nice explanation, this is something interesting to work on, if I have time, I > may take this up. > > Acked-by: Kyle Mestery Kyle and Etha

Re: [ovs-dev] [PATCH 1/2] ovs-ctl: Add support for glibc malloc debugging.

2012-10-01 Thread Justin Pettit
On Oct 1, 2012, at 11:03 AM, Ben Pfaff wrote: > +glibc) > +set env MALLOC_CHECK_=2 MALLOC_PERTURB_=165 "$@" It may be worth mentioning in the man page that this configuration of MALLOC_CHECK_ may cause the system to crash if there are memory problems. --Justin ___

Re: [ovs-dev] [PATCH 1/2] ovs-ctl: Add support for glibc malloc debugging.

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 01:28:40PM -0700, Justin Pettit wrote: > On Oct 1, 2012, at 11:03 AM, Ben Pfaff wrote: > > > +glibc) > > +set env MALLOC_CHECK_=2 MALLOC_PERTURB_=165 "$@" > > It may be worth mentioning in the man page that this configuration > of MALLOC_CHECK_ may cau

Re: [ovs-dev] [PATCH 2/2] tests: Enable glibc malloc debugging features in testsuite.

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 06:11:24PM +, Kyle Mestery (kmestery) wrote: > On Oct 1, 2012, at 1:03 PM, Ben Pfaff wrote: > > I don't know of a reason not to use these features for testing. > > > > Signed-off-by: Ben Pfaff > > > Both of these look good to me Ben. Thanks. > As a style nit, any r

[ovs-dev] [PATCH] tests: Also enable FreeBSD libc debugging

2012-10-01 Thread Ed Maste
Signed-off-by: Ed Maste --- There should probably be an OS check to set only the appropriate environment variables. I'm not sure if there's a generic autotest way to do that while building atlocal from atlocal.in though (vs. a switch on $(uname) in the generated file). Perhaps not worth addressi

Re: [ovs-dev] [PATCH] tests: Also enable FreeBSD libc debugging

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 09:11:31PM +, Ed Maste wrote: > Signed-off-by: Ed Maste Applied, thanks. > There should probably be an OS check to set only the appropriate environment > variables. I'm not sure if there's a generic autotest way to do that while > building atlocal from atlocal.in tho

[ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-01 Thread Kyle Mestery
Add RPM specfiles for building OVS for Fedora Linux. This allows users of the upstream project the ability to generate RPMs for their Open vSwitch needs. Signed-off-by: Kyle Mestery --- INSTALL.Fedora | 53 + rhel/.gitignore | 2 + rhel/autom

Re: [ovs-dev] [PATCH] tests: Also enable FreeBSD libc debugging

2012-10-01 Thread Ed Maste
On 1 October 2012 17:19, Ben Pfaff wrote: > On Mon, Oct 01, 2012 at 09:11:31PM +, Ed Maste wrote: >> Signed-off-by: Ed Maste > > Applied, thanks. > >> There should probably be an OS check to set only the appropriate environment >> variables. I'm not sure if there's a generic autotest way to

Re: [ovs-dev] [PATCH] tests: Also enable FreeBSD libc debugging

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 05:40:29PM -0400, Ed Maste wrote: > On 1 October 2012 17:19, Ben Pfaff wrote: > > On Mon, Oct 01, 2012 at 09:11:31PM +, Ed Maste wrote: > >> Signed-off-by: Ed Maste > > > > Applied, thanks. > > > >> There should probably be an OS check to set only the appropriate > >>

[ovs-dev] Máquina de afeitar corporal / Redutor de papada / Evádete del estres en el Albaicín de Granada

2012-10-01 Thread GlobalBono
Cabestan. Layout Simple Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu lista de contactos. Si no ves correctamente las imágenes, pulsa [ http://email.globalbono.com/E01102012143248.cfm?WL=1671&WS=208833_8707685&WA=859 ] aquí [ http://email.globalbono.com/Go/index.c

[ovs-dev] Willing to help?

2012-10-01 Thread Ben Kossi
My dear One, My name is Mr. Ben Kossi, the Secretary to the former Government Mr.Laurent Gbagbo president of Cote d Ivory in West Africa, I have funds 800,000.00 US dollars, in my possession which the president handed over tome to pay inn before the political crises. I want to move this fund(s

Re: [ovs-dev] Threaded userspace datapath

2012-10-01 Thread Jesse Gross
On Sat, Sep 29, 2012 at 7:05 AM, Luigi Rizzo wrote: > jumping in the conversation: last year when Gaetano and I worked on > this code, the main loop had multiple performance issues, including > a) rebuilding from scratch the list of file descriptors on each iteration, > b) ignoring the response fr

Re: [ovs-dev] Threaded userspace datapath

2012-10-01 Thread Jesse Gross
On Sat, Sep 29, 2012 at 12:17 AM, Giuseppe Lettieri wrote: > > Il giorno 29/set/2012, alle ore 01:44, Jesse Gross ha > scritto: > >> Does this actually require changing the main loop? If it really is >> the poll related changes that you mention it seems like they could be >> contained to the ne

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 05:20:32PM -0400, Kyle Mestery wrote: > Add RPM specfiles for building OVS for Fedora Linux. This > allows users of the upstream project the ability to > generate RPMs for their Open vSwitch needs. > > Signed-off-by: Kyle Mestery Thanks. I have only a few comments. The

Re: [ovs-dev] [PATCH] vswitch: allow to specify ofport when creating port

2012-10-01 Thread Justin Pettit
On Oct 1, 2012, at 10:08 AM, Ben Pfaff wrote: > But there's another issue too. As part of the ongoing effort to > upstream tunneling to the Linux kernel, Justin is currently reworking > how ports are assigned to datapaths. That work is going to change a > lot of the code in this area, and we've

Re: [ovs-dev] [PATCH] vswitch: allow to specify ofport when creating port

2012-10-01 Thread Isaku Yamahata
On Mon, Oct 01, 2012 at 11:42:36PM -0700, Justin Pettit wrote: > On Oct 1, 2012, at 10:08 AM, Ben Pfaff wrote: > > > But there's another issue too. As part of the ongoing effort to > > upstream tunneling to the Linux kernel, Justin is currently reworking > > how ports are assigned to datapaths.