On Mon, Oct 01, 2012 at 06:11:24PM +0000, Kyle Mestery (kmestery) wrote:
> On Oct 1, 2012, at 1:03 PM, Ben Pfaff wrote:
> > I don't know of a reason not to use these features for testing.
> > 
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> 
> 
> Both of these look good to me Ben.

Thanks.

> As a style nit, any reason not to combine setting and exporting the
> variables on the same line?

Just that the other assignments in atlocal.in use two lines.  If you
really like the single-line style, I'd take a patch to convert the
whole file.

> Acked-by: Kyle Mestery <kmest...@cisco.com>

Added and pushed, thank you.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to