Re: [ovs-dev] [threaded-put 07/21] netflow: Make thread safe.

2013-12-12 Thread Ben Pfaff
Yeah, if you want clang to catch that then you would need to add a redundant prototype near the top of the C file (not actually a bad idea). On Dec 12, 2013 5:12 PM, "Ethan Jackson" wrote: > Annoying that clang didn't catch that . . . I suppose it's cause > 'mutex' doesn't exist where we define

Re: [ovs-dev] [threaded-put 07/21] netflow: Make thread safe.

2013-12-12 Thread Ethan Jackson
Annoying that clang didn't catch that . . . I suppose it's cause 'mutex' doesn't exist where we define netflow_run()'s protoype and we have to annotate in both places. At any rate. I'll make a netflow_run__() function which doesn't require the mutex. On Thu, Dec 12, 2013 at 2:56 PM, Ben Pfaff

Re: [ovs-dev] [threaded-put 07/21] netflow: Make thread safe.

2013-12-12 Thread Ben Pfaff
On Sun, Dec 08, 2013 at 06:45:13PM -0800, Ethan Jackson wrote: > In future patches upcall handler threads will need to update netflow. > > Signed-off-by: Ethan Jackson I think I see a deadlock. gen_netflow_rec() requires 'mutex', netflow_run() excludes it, but the former calls the latter. Mayb