Thanks for the review, I pushed the patch.
On Mon, Oct 29, 2012 at 02:21:52PM -0700, Justin Pettit wrote:
> Huh, somehow I missed it in that 22 patch series. I just reviewed
> that one patch.
>
> Thanks,
>
> --Justin
>
>
> On Oct 29, 2012, at 2:14 PM, Ben Pfaff wrote:
>
> > On Mon, Oct 29,
On Oct 22, 2012, at 3:24 PM, Ben Pfaff wrote:
> On Thu, Oct 18, 2012 at 12:51:49PM -0700, Justin Pettit wrote:
>> @@ -89,7 +91,7 @@ struct flow {
>> uint8_t arp_tha[6]; /* ARP/ND target hardware address. */
>> uint8_t nw_ttl; /* IP TTL/Hop Limit. */
>> uint8_t nw_f
Huh, somehow I missed it in that 22 patch series. I just reviewed that one
patch.
Thanks,
--Justin
On Oct 29, 2012, at 2:14 PM, Ben Pfaff wrote:
> On Mon, Oct 29, 2012 at 02:11:51PM -0700, Justin Pettit wrote:
>> On Thu, Oct 18, 2012 at 4:42 PM, Ben Pfaff wrote:
>>> In ofproto_unixctl_trac
On Mon, Oct 29, 2012 at 02:11:51PM -0700, Justin Pettit wrote:
> On Thu, Oct 18, 2012 at 4:42 PM, Ben Pfaff wrote:
> > In ofproto_unixctl_trace(), it looks very much to me like the conversion
> > to an ODP port in the argc == 6 case should not be happening, that is,
> > that the ofp_port_to_odp_po
On Thu, Oct 18, 2012 at 4:42 PM, Ben Pfaff wrote:
> On Thu, Oct 18, 2012 at 12:51:49PM -0700, Justin Pettit wrote:
> > The current code has a simple mapping between datapath and OpenFlow port
> > numbers (1-to-1 other than the local port).
>
> The important fact is not really that the mapping is
On Thu, Oct 18, 2012 at 12:51:49PM -0700, Justin Pettit wrote:
> @@ -89,7 +91,7 @@ struct flow {
> uint8_t arp_tha[6]; /* ARP/ND target hardware address. */
> uint8_t nw_ttl; /* IP TTL/Hop Limit. */
> uint8_t nw_frag;/* FLOW_FRAG_* flags. */
> -uin
On Thu, Oct 18, 2012 at 12:51:49PM -0700, Justin Pettit wrote:
> The current code has a simple mapping between datapath and OpenFlow port
> numbers (1-to-1 other than the local port).
The important fact is not really that the mapping is one-to-one, it's
that the port numbers are actually *the sa
