On Oct 22, 2012, at 3:24 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Thu, Oct 18, 2012 at 12:51:49PM -0700, Justin Pettit wrote:
>> @@ -89,7 +91,7 @@ struct flow {
>> uint8_t arp_tha[6]; /* ARP/ND target hardware address. */
>> uint8_t nw_ttl; /* IP TTL/Hop Limit. */
>> uint8_t nw_frag; /* FLOW_FRAG_* flags. */
>> - uint8_t zeros[2]; /* Must be zero. */
>> + uint8_t zeros[0]; /* Must be zero. */
>
> I'd get rid of this zeros[] member entirely. It looks weird and it
> causes various "sparse" warnings:
>
> ../lib/flow.c:595:11: warning: memset with byte count of 0
> ../tests/test-bundle.c:139:15: warning: memset with byte count of 0
> ../tests/test-multipath.c:63:19: warning: memset with byte count of 0
Okay. Done.
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
