Thanks for the review, I pushed the patch.
On Mon, Oct 29, 2012 at 02:21:52PM -0700, Justin Pettit wrote: > Huh, somehow I missed it in that 22 patch series. I just reviewed > that one patch. > > Thanks, > > --Justin > > > On Oct 29, 2012, at 2:14 PM, Ben Pfaff <b...@nicira.com> wrote: > > > On Mon, Oct 29, 2012 at 02:11:51PM -0700, Justin Pettit wrote: > >> On Thu, Oct 18, 2012 at 4:42 PM, Ben Pfaff <b...@nicira.com> wrote: > >>> In ofproto_unixctl_trace(), it looks very much to me like the conversion > >>> to an ODP port in the argc == 6 case should not be happening, that is, > >>> that the ofp_port_to_odp_port call should be omitted here: > >>> uint32_t in_port = ofp_port_to_odp_port(atoi(in_port_s)); > >>> > >> > >> Fixed. Isn't this a bug in the existing code? Should I do a separate > >> patch to fix this in existing branches? > > > > I've had a fix for this on a local branch forever and I finally sent > > it out on Friday, so you can just review it here: > > http://openvswitch.org/pipermail/dev/2012-October/022319.html > > > > Thanks, > > > > Ben. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
