Re: [ovs-dev] [PATCH v2 2/3] datapath-windows: Release WFP allocated objects

2015-01-01 Thread Ben Pfaff
On Mon, Dec 22, 2014 at 03:06:34PM +, Sorin Vinturis wrote: > Filter and sublayer WFP objects are created when the filter attach routine > is called and the tunnel filter is initialized, and they are released > in the uninitialize part. But the release part is done indirectly, through > the Fwp

Re: [ovs-dev] [PATCH v2 2/3] datapath-windows: Release WFP allocated objects

2014-12-30 Thread Nithin Raju
On Dec 23, 2014, at 10:54 PM, Sorin Vinturis wrote: > Hi Nithin, > > The callout is not deleted after the session to the engine is closed, i.e. > FwpmEngineClose. As you can see, the engine handle is not necessary for > unregistering the callout. So it's OK to unregister the callout after th

Re: [ovs-dev] [PATCH v2 2/3] datapath-windows: Release WFP allocated objects

2014-12-23 Thread Sorin Vinturis
ginal Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 23 December, 2014 21:18 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/3] datapath-windows: Release WFP allocated objects hi Sorin, Thanks for making the change. I had a couple of minor com

Re: [ovs-dev] [PATCH v2 2/3] datapath-windows: Release WFP allocated objects

2014-12-23 Thread Nithin Raju
hi Sorin, Thanks for making the change. I had a couple of minor comments. > @@ -288,12 +346,13 @@ Exit: > VOID > OvsTunnelUnregisterCallouts(VOID) > { > +OvsTunnelRemoveFilter(&OVS_TUNNEL_FILTER_KEY, > + &OVS_TUNNEL_SUBLAYER); > FwpmEngineClose(gEngineHandle); >