Hi Nithin, The callout is not deleted after the session to the engine is closed, i.e. FwpmEngineClose. As you can see, the engine handle is not necessary for unregistering the callout. So it's OK to unregister the callout after the engine session is closed.
Thanks, Sorin -----Original Message----- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 23 December, 2014 21:18 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/3] datapath-windows: Release WFP allocated objects hi Sorin, Thanks for making the change. I had a couple of minor comments. > @@ -288,12 +346,13 @@ Exit: > VOID > OvsTunnelUnregisterCallouts(VOID) > { > + OvsTunnelRemoveFilter(&OVS_TUNNEL_FILTER_KEY, > + &OVS_TUNNEL_SUBLAYER); > FwpmEngineClose(gEngineHandle); > gEngineHandle = NULL; > FwpsCalloutUnregisterById(gCalloutIdV4); This is not related to your change - but should we be doing FwpmEngineClose() after FwpsCalloutUnregisterById()? ie. shouldn't we be closing the handle to the engine after all the callouts and filters have been removed? You can address this in a new change if we need to patch this. Acked-by: Nithin Raju <nit...@vmware.com> thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
