Re: [ovs-dev] [PATCH 1/4] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

2013-01-17 Thread Ben Pfaff
On Thu, Jan 17, 2013 at 01:27:21PM -0800, Ben Pfaff wrote: > On Fri, Jan 11, 2013 at 09:55:41AM -0800, Romain Lenglet wrote: > > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding > > OFPACT_SAMPLE_IPFIX OVS action. > > > > Signed-off-by: Romain Lenglet > > Here, I think that

Re: [ovs-dev] [PATCH 1/4] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

2013-01-17 Thread Ben Pfaff
On Fri, Jan 11, 2013 at 09:55:41AM -0800, Romain Lenglet wrote: > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding > OFPACT_SAMPLE_IPFIX OVS action. > > Signed-off-by: Romain Lenglet Here, I think that a default sampling probability of 0 is likely to be surprising. I'd sug

Re: [ovs-dev] [PATCH 1/4] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

2013-01-04 Thread Ben Pfaff
On Tue, Dec 18, 2012 at 11:52:09AM -0800, Romain Lenglet wrote: > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding > OFPACT_SAMPLE_IPFIX OVS action. > > Signed-off-by: Romain Lenglet ... > +/* Action structure for NXAST_SAMPLE_IPFIX. > + * > + * Samples matching packets wi