On Fri, Jan 11, 2013 at 09:55:41AM -0800, Romain Lenglet wrote: > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding > OFPACT_SAMPLE_IPFIX OVS action. > > Signed-off-by: Romain Lenglet <rleng...@vmware.com>
Here, I think that a default sampling probability of 0 is likely to be surprising. I'd suggest that either we change it to something nonzero or make specifying the probability mandatory rather than having any default: > +.IP "\fBprobability=\fIpackets\fR" > +The number of sampled packets out of 65535. Defaults to 0. If 0, > +this action does nothing. This should read 1.9.90: > +This action was added in Open vSwitch 1.9.1. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
