On Tue, Dec 18, 2012 at 11:52:09AM -0800, Romain Lenglet wrote: > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding > OFPACT_SAMPLE_IPFIX OVS action. > > Signed-off-by: Romain Lenglet <rleng...@vmware.com>
... > +/* Action structure for NXAST_SAMPLE_IPFIX. > + * > + * Samples matching packets with the given probability and send them s/send/sends/ > + * using the IPFIX protocol. The probability is expressed as a number > + * of packets to be sampled out of USHRT_MAX packets. Every sampled > + * packet is associated the given observation point ID. Missing "with" after "associated" here. > +Refer to \fBovs\-vswitchd.conf.db (8)\fR for more details on > +configuring IPFIX. The customary formatting for a manpage reference is to put the section number in Roman font without a space, like this: \fBovs\-vswitchd.conf.db\fR(8) (But because of the syntactical weirdness of nroff, this appears correctly in the output: > +.BR ovs\-vswitchd.conf.db (8) ) So, I don't see any problems with the changes proposed in this patch, but it's unusual to introduce user-visible functionality that doesn't do anything, so it might ultimately make sense to squash this with other patches in the series. I'll look at those now. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
