Thanks a lot for the patch.
All in all the patch looks good. Just please move informations to Product.wxs
(i.e.
https://github.com/cloudbase/openvswitch-hyperv-installer/commit/4a0a0b90d278d4e11e84d8f83ff28ff58ae0934f).
> +
> +
Are not needed. We already check for windows version whe
I kept this as ‘6.3.9600.17298’ to keep it similar with ovsext.rc file.
Makes it
easier to track and replace them all.
This value will end up changing for every OVS branch. We should make this
configurable as part of make.
Thanks,
Sairam
On 9/8/16, 11:32 AM, "Nithin Raju" wrote:
>LGTM. One q
LGTM. One quick question:
> +
Is this because we are using NDIS 6.30? Otherwise, we should keep it
closer to the OVS version.
Acked-by: Nithin Raju
-- Nithin
-Original Message-
From: dev on behalf of Sairam Venugopal
Date: Wednesday, September 7, 2016 at 11:55 PM
To: "dev@openvsw