LGTM. One quick question: > + <Property Id="DriverVersion" Value="6.3.9600.17298" /> Is this because we are using NDIS 6.30? Otherwise, we should keep it closer to the OVS version.
Acked-by: Nithin Raju <nit...@vmware.com> -- Nithin -----Original Message----- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, September 7, 2016 at 11:55 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [ovs-dev] [PATCH] Windows: Update the Driver and MSI properties >Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to >include the properties mentioned in MSDN - 'Extension driver MSI packaging >requirements' section - >https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_wi >ndows_hardware_drivers_network_extension-2Ddriver-2Dmsi-2Dpackaging-2Drequ >irements&d=CwIDaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7 >B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=te_VudSnncTlArUDlqRfpCxCP-VdRxr5Gh7b >DDo9Y9U&s=cqJ5fXOM5FCo8lNYL6RMqQu_lnIAAKVFkkCZoQbB32Q&e= > >Signed-off-by: Sairam Venugopal <vsai...@vmware.com> >--- > datapath-windows/ovsext/ovsext.rc | 2 +- > windows/ovs-windows-installer/UI.wxs | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > >diff --git a/datapath-windows/ovsext/ovsext.rc >b/datapath-windows/ovsext/ovsext.rc >index 8dc6882..0b92e2e 100644 >--- a/datapath-windows/ovsext/ovsext.rc >+++ b/datapath-windows/ovsext/ovsext.rc >@@ -34,7 +34,7 @@ BEGIN > VALUE "FileDescription", "Open vSwitch Extension" > VALUE "FileVersion", "6.3.9600.17298" > VALUE "InternalName", "OVSExt.SYS" >- VALUE "LegalCopyright", "ï¿1Ž2 Licensed under the Apache >License, Version 2.0 (the ""License"")" >+ VALUE "LegalCopyright", "Licensed under the Apache License, >Version 2.0 (the ""License"")" > VALUE "OriginalFilename", "OVSExt.SYS" > VALUE "ProductName", "Open vSwitch 8/8.1 DDK driver" > VALUE "ProductVersion", "6.3.9600.17298" >diff --git a/windows/ovs-windows-installer/UI.wxs >b/windows/ovs-windows-installer/UI.wxs >index 5df4f4f..a2d36ae 100644 >--- a/windows/ovs-windows-installer/UI.wxs >+++ b/windows/ovs-windows-installer/UI.wxs >@@ -25,6 +25,12 @@ > > <Property Id="DefaultUIFont" Value="WixUI_Font_Normal" /> > <Property Id="WixUI_Mode" Value="FeatureTree" /> >+ <Property Id="Description" Value="Open vSwitch Extension" /> >+ <Property Id="DriverID" >Value="{583CC151-73EC-4A6A-8B47-578297AD7623}" /> >+ <Property Id="DriverVersion" Value="6.3.9600.17298" /> >+ <Property Id="ExtensionType" Value="Forwarding" /> >+ <Property Id="DriverInstallParams" Value="/q" /> >+ <Property Id="MinApplicableOSVersion" Value="6.2" /> > > <DialogRef Id="ErrorDlg" /> > <DialogRef Id="FatalError" /> >-- >2.9.0.windows.1 > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
