Thanks a lot for the patch.

All in all the patch looks good. Just please move informations to Product.wxs 
(i.e. 
https://github.com/cloudbase/openvswitch-hyperv-installer/commit/4a0a0b90d278d4e11e84d8f83ff28ff58ae0934f).
> +      <Property Id="DriverInstallParams" Value="/q" />
> +      <Property Id="MinApplicableOSVersion" Value="6.2" />
Are not needed. We already check for windows version when the installer is 
launched and install parameters are already defined.

We also should start to see how we can propagate the OVS version to the rest of 
the project settings via make.

Thanks,
Alin.

> -----Original Message-----
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam
> Venugopal
> Sent: Thursday, September 8, 2016 9:56 AM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH] Windows: Update the Driver and MSI properties
> 
> Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to
> include the properties mentioned in MSDN - 'Extension driver MSI packaging
> requirements' section -
> https://msdn.microsoft.com/windows/hardware/drivers/network/extensio
> n-driver-msi-packaging-requirements
> 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to