On Tue, Jan 26, 2016 at 12:13:08AM +0800, Huanle Han wrote:
> 2016-01-25 1:00 GMT+08:00 Ben Pfaff :
>
> > On Sun, Jan 24, 2016 at 11:59:57PM +0800, Huanle Han wrote:
> > > I think a more line "mirrors &= ~ctx->mirrors;" is needed at the end of
> > the
> > > "while" loop.
> > > Otherwise, duplicate
2016-01-25 1:00 GMT+08:00 Ben Pfaff :
> On Sun, Jan 24, 2016 at 11:59:57PM +0800, Huanle Han wrote:
> > I think a more line "mirrors &= ~ctx->mirrors;" is needed at the end of
> the
> > "while" loop.
> > Otherwise, duplicated mirror action may be applied in recursive
> > mirror_packet called by ou
On Sun, Jan 24, 2016 at 11:59:57PM +0800, Huanle Han wrote:
> I think a more line "mirrors &= ~ctx->mirrors;" is needed at the end of the
> "while" loop.
> Otherwise, duplicated mirror action may be applied in recursive
> mirror_packet called by output_normal.
Did you arrive at that conclusion fro
Hi, Ben,
I think a more line "mirrors &= ~ctx->mirrors;" is needed at the end of the
"while" loop.
Otherwise, duplicated mirror action may be applied in recursive
mirror_packet called by output_normal.
Here are the test cases:
Test case for the bug I mentioned in previous mail:
1. setup port: v
On Sat, Jan 16, 2016 at 02:21:03PM +0800, hanxueluo wrote:
> Hi, guys I have a question about the code below in function
> "mirror_packet". Some mirrors in "mirrors" may be skipped because the
> select_vlan doesn't match ("if (vlans && !bitmap_is_set(vlans,
> vlan)"), but they may be useful for nex
Hi, guys I have a question about the code below in function "mirror_packet".
Some mirrors in "mirrors" may be skipped because the select_vlan doesn't match
("if (vlans && !bitmap_is_set(vlans, vlan)"), but they may be useful for next
xbundle. So I think we should record only the mirrors which ar
