On Sat, Jan 16, 2016 at 02:21:03PM +0800, hanxueluo wrote:
> Hi, guys I have a question about the code below in function
> "mirror_packet". Some mirrors in "mirrors" may be skipped because the
> select_vlan doesn't match ("if (vlans && !bitmap_is_set(vlans,
> vlan)"), but they may be useful for next xbundle. So I think we should
> record only the mirrors which are truely applied, not all of them. am
> I right? The code doesn't exist in old version. I'm not sure whether
> it's added on purpose. /* Record these mirrors so that we don't mirror
> to them again. */ ctx->mirrors |= mirrors;

I think you're right.  Do you have a test case?  Will you take a look at
this patch?
        http://openvswitch.org/pipermail/dev/2016-January/064625.html

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to