nd Regards,
> Alin.
>
> From: Alin Serdean
> Sent: Tuesday, December 03, 2013 10:45 PM
> To: Gurucharan Shetty; Alessandro Pilotti
> Cc: Ben Pfaff; dev@openvswitch.org
>
> Subject: RE: [ovs-dev] Windows port status
>
>> #ifdef _WIN32
&g
erdean
Sent: Tuesday, December 03, 2013 10:45 PM
To: Gurucharan Shetty; Alessandro Pilotti
Cc: Ben Pfaff; dev@openvswitch.org
Subject: RE: [ovs-dev] Windows port status
> #ifdef _WIN32
> #include <../include/string.h>
> #else
> #include_next
> #endif
The bold include is to
Shetty [shet...@nicira.com]
Sent: Tuesday, December 03, 2013 8:29 PM
To: Alin Serdean
Cc: Ben Pfaff; dev@openvswitch.org
Subject: Re: [ovs-dev] Windows port status
On Mon, Dec 2, 2013 at 2:20 PM, Alin Serdean
wrote:
> Hey,
>
> Continuing patches for the windows build.
>
> The ne
On Mon, Dec 2, 2013 at 2:20 PM, Alin Serdean
wrote:
> Hey,
>
> Continuing patches for the windows build.
>
> The next problem that we are facing is that the include_next directive is
> missing from the VStudio compiler.
>
> The affected files will be:
> include/linux/types.h
> #include
> #ifndef
Hey,
Continuing patches for the windows build.
The next problem that we are facing is that the include_next directive is
missing from the VStudio compiler.
The affected files will be:
include/linux/types.h
#include
#ifndef _WIN32
#include_next
#endif
lib/string.h
#ifdef _WIN32
#include <../
Sure :).
Signed-off-by: Alin Serdean
---
CodingStyle |2 +-
Makefile.am | 13
lib/bundle.c |4 +-
lib/coverage.c|2 +-
lib/hmap.c|2 +-
lib/multipath.c |2 +-
On Sun, Nov 24, 2013 at 09:39:12PM +, Alin Serdean wrote:
> Bellow is the patch for the %z modifier.
>
> Please take a closer look over the Makefile and comments (I hope they are
> inline with your previous ones :) ).
That's much better, thanks.
Can you provide a Signed-off-by line? Submi
Hey,
Bellow is the patch for the %z modifier.
Please take a closer look over the Makefile and comments (I hope they are
inline with your previous ones :) ).
diff --git a/CodingStyle b/CodingStyle
index 2f24ee3..1597302 100644
--- a/CodingStyle
+++ b/CodingStyle
@@ -394,7 +394,7 @@ from .
inte
As you wish.
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Saturday, November 23, 2013 4:27 AM
To: Alin Serdean
Cc: Alessandro Pilotti; dev@openvswitch.org
Subject: Re: [ovs-dev] Windows port status
On Sat, Nov 23, 2013 at 12:23:41AM +, Alin Serdean
On Sat, Nov 23, 2013 at 12:23:41AM +, Alin Serdean wrote:
> > That reads like a non sequitur, I don't see how it responds to my
> > comments.
>
> My problem is where to insert the macro exactly.
util.h perhaps?
___
dev mailing list
dev@openvswitch.o
ilotti; dev@openvswitch.org
Subject: Re: [ovs-dev] Windows port status
On Fri, Nov 22, 2013 at 07:25:14PM +, Alin Serdean wrote:
>
> > PRI_ZU is a bad name because it doesn't follow the existing pattern.
> > The name PRIuSIZE fits the pattern, so that is what I would
d use the fact is
> > included in every file)
> > 2. We define a header that is included in every source file
> > 3. We define a wrapper over the (like the ./lib/string.h) and
> > whenever they want to use the PRIuSIZE macro they have to include in
> > .
> >
On Fri, Nov 22, 2013 at 07:25:14PM +, Alin Serdean wrote:
>
> > PRI_ZU is a bad name because it doesn't follow the existing pattern.
> > The name PRIuSIZE fits the pattern, so that is what I would suggest.
>
> > The existing PRI* macros only include a type modifier, not the format
> > specifi
> .
>
> Kind Regards,
> Alin.
> ________________
> From: Ben Pfaff [b...@nicira.com]
> Sent: Friday, November 22, 2013 4:33 AM
> To: Alin Serdean
> Cc: Alessandro Pilotti; dev@openvswitch.org
> Subject: Re: [ovs-dev] Windows port status
>
>
a.com]
Sent: Friday, November 22, 2013 4:33 AM
To: Alin Serdean
Cc: Alessandro Pilotti; dev@openvswitch.org
Subject: Re: [ovs-dev] Windows port status
On Fri, Nov 22, 2013 at 02:23:11AM +, Alin Serdean wrote:
> Bellow the whole patch required for the PRI_ZU macro:
PRI_ZU is a bad name because it do
On Fri, Nov 22, 2013 at 02:23:11AM +, Alin Serdean wrote:
> Bellow the whole patch required for the PRI_ZU macro:
PRI_ZU is a bad name because it doesn't follow the existing pattern.
The name PRIuSIZE fits the pattern, so that is what I would suggest.
The existing PRI* macros only include a t
Bellow the whole patch required for the PRI_ZU macro:
diff --git a/CodingStyle b/CodingStyle
index 2f24ee3..a9417de 100644
--- a/CodingStyle
+++ b/CodingStyle
@@ -394,7 +394,7 @@ from .
integer types. Use the PRId, PRIu, and PRIx macros from
for formatting them with printf() and related functi
OK, I look forward to patches.
On Wed, Nov 20, 2013 at 07:07:23AM +, Alessandro Pilotti wrote:
> +1
>
>
> > On 20.11.2013, at 00:17, "Ethan Jackson" wrote:
> >
> > Ben's the authority on this, but FWIW a macro sounds fine to me.
> > We've already got PRI_U32 etc, adding a PRI_ZU seems reas
+1
> On 20.11.2013, at 00:17, "Ethan Jackson" wrote:
>
> Ben's the authority on this, but FWIW a macro sounds fine to me.
> We've already got PRI_U32 etc, adding a PRI_ZU seems reasonable.
>
> Ethan
>
>
>
> On Tue, Nov 19, 2013 at 1:57 PM, Alessandro Pilotti
> wrote:
>> Talking about %zu,
On Tue, Nov 19, 2013 at 03:33:30PM -0800, Saurabh Shah wrote:
> The Makefile rule would probably do the job in this case, but for a
> more generic use case we probably need some sort of a pre-checkin
> build sanitizer. For e.g. how will we prevent unix system calls from
> being introduced (assuming
On Tue, Nov 19, 2013 at 02:16:43PM -0800, Ethan Jackson wrote:
Ben's the authority on this, but FWIW a macro sounds fine to me.
We've already got PRI_U32 etc, adding a PRI_ZU seems reasonable.
I don't object to that, I just want to make sure that there's some
Makefile rule to blacklist %zu so tha
On Tue, Nov 19, 2013 at 02:16:43PM -0800, Ethan Jackson wrote:
> Ben's the authority on this, but FWIW a macro sounds fine to me.
> We've already got PRI_U32 etc, adding a PRI_ZU seems reasonable.
I don't object to that, I just want to make sure that there's some
Makefile rule to blacklist %zu so
Ben's the authority on this, but FWIW a macro sounds fine to me.
We've already got PRI_U32 etc, adding a PRI_ZU seems reasonable.
Ethan
On Tue, Nov 19, 2013 at 1:57 PM, Alessandro Pilotti
wrote:
> Talking about %zu, we solved it with a brutal macro. Do you have any
> suggestion for a better a
On Tue, Nov 19, 2013 at 09:57:43PM +, Alessandro Pilotti wrote:
> Talking about %zu, we solved it with a brutal macro. Do you have any
> suggestion for a better approach?
I have thought of two viable approaches:
1. Use a macro plus add a makefile rule to scan the tree for use of
'z
Talking about %zu, we solved it with a brutal macro. Do you have any suggestion
for a better approach?
On 19 Nov 2013, at 18:51 , Gurucharan Shetty wrote:
> On Tue, Nov 19, 2013 at 8:37 AM, Ben Pfaff wrote:
>> On Tue, Nov 19, 2013 at 12:22:40PM +, Alessandro Pilotti wrote:
>>> The freshl
"
mailto:dev@openvswitch.org>>, Saurabh Shah
mailto:ssaur...@nicira.com>>, Gurucharan Shetty
mailto:gshe...@nicira.com>>
Subject: Re: [ovs-dev] Windows port status
We started working on this project using Visual Studio 2013 RC and made the
finishing touches the moment the fina
:dev@openvswitch.org>>, Saurabh Shah
mailto:ssaur...@nicira.com>>, Gurucharan Shetty
mailto:gshe...@nicira.com>>
Subject: Re: [ovs-dev] Windows port status
We started working on this project using Visual Studio 2013 RC and made the
finishing touches the moment the final release
@openvswitch.org; Alessandro Pilotti; Alin Serdean;
Saurabh Shah
Subject: Re: [ovs-dev] Windows port status
On Tue, Nov 19, 2013 at 8:37 AM, Ben Pfaff wrote:
> On Tue, Nov 19, 2013 at 12:22:40PM +, Alessandro Pilotti wrote:
>> The freshly released Visual Studio 2013 is the minimum supported
>&
On Tue, Nov 19, 2013 at 8:37 AM, Ben Pfaff wrote:
> On Tue, Nov 19, 2013 at 12:22:40PM +, Alessandro Pilotti wrote:
>> The freshly released Visual Studio 2013 is the minimum supported
>> version due to its improved C99 support that avoided us a few
>> headaches.
>
> Guru, have you been using t
On Tue, Nov 19, 2013 at 12:22:40PM +, Alessandro Pilotti wrote:
> The freshly released Visual Studio 2013 is the minimum supported
> version due to its improved C99 support that avoided us a few
> headaches.
Guru, have you been using the compiler from VS2013? I see that it still
does not impl
Hi guys,
My company, Cloudbase Solutions, as part of our effort in integrating OpenStack
with Windows and Hyper-V is currently involved in porting Open vSwitch to
Windows.
We are currently revieweing the first Windows patches that have been posted to
this ML and we will gladly start to contrib
31 matches
Mail list logo
