On Thu, Jun 23, 2016 at 12:01:11PM +, André Mantas wrote:
> Hi again.
>
> I've sent an email with the patch using git send-email, I hope it reaches
> the mailing list. Here is the git send-email output:
It reached the mailing list successfully.
___
Hi again.
I've sent an email with the patch using git send-email, I hope it reaches
the mailing list. Here is the git send-email output:
OK. Log says:
Server: smtp.googlemail.com
MAIL FROM:
RCPT TO:
RCPT TO:
From: Andre Mantas
To: dev@openvswitch.org
Cc: Andre Mantas
Subject: [PATCH] ofproto: o
I'm just behind on reviews, as usual.
Pull requests always get reviewed more slowly than patches emailed to
the ovs-dev, by the way, since they're off to the side and not visible
in patchwork or the email list. For prompt (or more prompt, at least)
reviews, I always recommend emailing patches.
O
Any news on this?
Ben Pfaff escreveu no dia terça, 19/04/2016 às 00:33:
> Thanks. I see the pull request.
>
> We'd be happy to have support for additional OpenFlow request in
> bundles.
>
> On Mon, Apr 18, 2016 at 09:59:33PM +, André Mantas wrote:
> > Hi. Sorry for the long delay. Just issu
Thanks. I see the pull request.
We'd be happy to have support for additional OpenFlow request in
bundles.
On Mon, Apr 18, 2016 at 09:59:33PM +, André Mantas wrote:
> Hi. Sorry for the long delay. Just issued a pull request in github, I hope
> thats ok. Please let me know if I did something w
Hi. Sorry for the long delay. Just issued a pull request in github, I hope
thats ok. Please let me know if I did something wrong.
I'm also interested in adding support for group_mod, meter_mod and
table_mod in the future (if that's ok with you).
Ben Pfaff escreveu no dia terça, 29/03/2016 às 16:
On Tue, Mar 15, 2016 at 09:21:40PM +, André Mantas wrote:
> I think one option could be do extra validations depending on the error
> returned by ofproto_check_ofpacts like checking if previous entries in the
> bundle would make the validation successful. But since group and meter mods
> are no
I see.
I think one option could be do extra validations depending on the error
returned by ofproto_check_ofpacts like checking if previous entries in the
bundle would make the validation successful. But since group and meter mods
are not implemented yet this isn't feasible.
I need to focus on my p
I think I’ll worry about that when I get to adding group and meter support.
Jarno
> On Mar 14, 2016, at 8:47 PM, Ben Pfaff wrote:
>
> Jarno, what do you think?
>
> On Mon, Mar 14, 2016 at 11:16:27PM +, André Mantas wrote:
>> Ok. And what about Packet_Out validation complicating the imple
Jarno, what do you think?
On Mon, Mar 14, 2016 at 11:16:27PM +, André Mantas wrote:
> Ok. And what about Packet_Out validation complicating the implementation of
> group and meter mod in bundles?
>
> Should I create new validation functions that don't check for group and
> meter in the action
Ok. And what about Packet_Out validation complicating the implementation of
group and meter mod in bundles?
Should I create new validation functions that don't check for group and
meter in the action of Packet_Out?
Ben Pfaff escreveu no dia segunda, 14/03/2016 às 16:54:
> On Wed, Mar 09, 2016 a
On Wed, Mar 09, 2016 at 09:10:41AM +, André Mantas wrote:
> By the way, I'm still starting vswitchd with valgrind and detected some
> memory errors after using "sudo ovs-appctl exit". Is there other way to
> exit/stop ovs?
>
> To run I used: valgrind --tool=memcheck --leak-check=full ovs-vswit
By the way, I'm still starting vswitchd with valgrind and detected some
memory errors after using "sudo ovs-appctl exit". Is there other way to
exit/stop ovs?
To run I used: valgrind --tool=memcheck --leak-check=full ovs-vswitchd
--pidfile --detach -v --log-file
==2344== HEAP SUMMARY:
==2344==
>
> You want config=0 mask=1, I believe.
>
Oh, that was it. It worked as expected.
The test was also successful. A snoop extract is below, but basically what
I've done is: send port mod to bring down port 2; create bundle with 2
messages - port mod to bring up port 2 and packet out to port 2; hos
On Tue, Mar 08, 2016 at 12:59:20PM +, André Mantas wrote:
> After some more debugging and testing packet outs are being forwarded to
> both controllers and hosts when added to a bundle.
> I've tested with 2 controllers, 3 switches and 4 hosts with controllers
> sending packet outs to each other
After some more debugging and testing packet outs are being forwarded to
both controllers and hosts when added to a bundle.
I've tested with 2 controllers, 3 switches and 4 hosts with controllers
sending packet outs to each other and pinging between hosts with pingall
from mininet.
How "good enough
It should still work, if you use ovs-ctl while testing. Usually,
though, when I'm testing, I just run ovs-vswitchd from the command-line,
and in that case you can just invoke "valgrind ovs-vswitchd ...".
OVS_CTL_OPTS is just an environment variable so you can define it
wherever that is convenient
Looks like what I need. What's the quickest way to enable valgrind?
I found this: http://openvswitch.org/pipermail/discuss/2013-May/010113.html
Does it still apply to today? Where can I define OVS_CTL_OPTS?
Ben Pfaff escreveu no dia quinta, 3/03/2016 às 18:16:
> On Thu, Mar 03, 2016 at 05:54:4
On Thu, Mar 03, 2016 at 05:54:42PM +, André Mantas wrote:
> Hi again.
>
> For now, I'm testing the implementation with a floodlight controller that
> opens a bundle, adds a packet_out message and tries to commit the bundle.
> I'm using mininet to start a simple topology with 1 switch and 2 hos
Hi again.
For now, I'm testing the implementation with a floodlight controller that
opens a bundle, adds a packet_out message and tries to commit the bundle.
I'm using mininet to start a simple topology with 1 switch and 2 hosts and
connect the switch to the remote controller. I followed INSTALL.m
On Sat, Feb 27, 2016 at 11:15:58PM +, André Mantas wrote:
> Ben Pfaff escreveu no dia sábado, 27/02/2016 às 22:30:
>
> > On Sat, Feb 27, 2016 at 06:24:23PM +, André Mantas wrote:
> > > Ok, I'll try to do that.
> > >
> > > Now related with tests for ofproto.at, if I'm not mistaken, in vers
Ben Pfaff escreveu no dia sábado, 27/02/2016 às 22:30:
> On Sat, Feb 27, 2016 at 06:24:23PM +, André Mantas wrote:
> > Ok, I'll try to do that.
> >
> > Now related with tests for ofproto.at, if I'm not mistaken, in version
> 2.3
> > we had the "bundle" command in ovs-ofctl and do things like:
On Sat, Feb 27, 2016 at 06:24:23PM +, André Mantas wrote:
> Ok, I'll try to do that.
>
> Now related with tests for ofproto.at, if I'm not mistaken, in version 2.3
> we had the "bundle" command in ovs-ofctl and do things like:
>
> ovs-ofctl bundle "open_bundle_id=,add_bundle_id=
> message=[,
Ok, I'll try to do that.
Now related with tests for ofproto.at, if I'm not mistaken, in version 2.3
we had the "bundle" command in ovs-ofctl and do things like:
ovs-ofctl bundle "open_bundle_id=,add_bundle_id=
message=[,add_bundle_id=
message=...],close_bundle_id=,commit_bundle_id="
Is this not
One approach is to use tcpdump, etc. to capture to a pcap file.
But I usually write the examples in ofp-print.at by hand, while reading
the OpenFlow specs, to assure myself that the formats that the decoders
understand are really correct. That's another part of the purpose of
the tests there, to
This may be a beginner question but is there a quick way to get a hexdump
of an OpenFlow message?
Thanks for your help.
Ben Pfaff escreveu no dia sexta, 26/02/2016 às 22:52:
> Tests like the ones in ofproto.at, which test functionality, are more
> important than the ones in ofp-print.at, which
Tests like the ones in ofproto.at, which test functionality, are more
important than the ones in ofp-print.at, which test message decoding and
printing, but it's best to have both.
On Fri, Feb 26, 2016 at 09:57:48PM +, André Mantas wrote:
> Ok, makes sense. So I should focus on making similar
Ok, makes sense. So I should focus on making similar tests to the ones in
ofproto.at? Or these are also important?
Thanks.
Ben Pfaff escreveu no dia sexta, 26/02/2016 às 20:35:
> On Fri, Feb 26, 2016 at 08:07:32PM +, André Mantas wrote:
> > I've seen some examples in ofp-print.at, ofproto.a
On Fri, Feb 26, 2016 at 08:07:32PM +, André Mantas wrote:
> I've seen some examples in ofp-print.at, ofproto.at and was trying to
> figure them out so I could add more.
>
> (ofp-print.at)
> AT_SETUP([OFPT_BUNDLE_ADD_MESSAGE - PORT_MOD])
> AT_KEYWORDS([ofp-print])
> AT_CHECK([ovs-ofctl ofp-prin
I wanted to right some unit tests to start testing my code and the
interactions of packet_outs with other messages in bundles.
I've seen some examples in ofp-print.at, ofproto.at and was trying to
figure them out so I could add more.
(ofp-print.at)
AT_SETUP([OFPT_BUNDLE_ADD_MESSAGE - PORT_MOD])
A
Thanks for the detailed answer. Comments below.
Jarno Rajahalme escreveu no dia quarta, 17/02/2016 às 17:59:
>
> > On Feb 17, 2016, at 2:39 AM, André Mantas
> wrote:
> >
> > Hi. I'm currently adding support for packet-out messages in bundles.
> >
> > I started to look at *handle_packet_out*, *h
> On Feb 17, 2016, at 2:39 AM, André Mantas wrote:
>
> Hi. I'm currently adding support for packet-out messages in bundles.
>
> I started to look at *handle_packet_out*, *handle_bundle_add *and
> *do_bundle_commit
> *functions to understand how things work. Here is what I did in each
> function
Hi. I'm currently adding support for packet-out messages in bundles.
I started to look at *handle_packet_out*, *handle_bundle_add *and
*do_bundle_commit
*functions to understand how things work. Here is what I did in each
function:
*handle_bundle_add:* added if case for OFPTYPE_PACKET_OUT which d
33 matches
Mail list logo
