Ok, I'll try to do that.

Now related with tests for ofproto.at, if I'm not mistaken, in version 2.3
we had the "bundle" command in ovs-ofctl and do things like:

ovs-ofctl bundle <bridge> "open_bundle_id=<id>,add_bundle_id=<id>
message=<message>[,add_bundle_id=<id>
message=<message>...],close_bundle_id=<id>,commit_bundle_id=<id>"

Is this not supported any more? The only way to send "bundle-add" messages
is with with the option --bundle for add-flow, mod-flows, etc?

If so, is the right approach to add a "--bundle" option for the packet-out
command?

Ben Pfaff <b...@ovn.org> escreveu no dia sábado, 27/02/2016 às 16:32:

> One approach is to use tcpdump, etc. to capture to a pcap file.
>
> But I usually write the examples in ofp-print.at by hand, while reading
> the OpenFlow specs, to assure myself that the formats that the decoders
> understand are really correct.  That's another part of the purpose of
> the tests there, to ensure that if the encoder or decoder functions in
> OVS drift away from the OpenFlow spec, the ofp-print tests will catch
> the regressions since their contents are fixed points.
>
> On Sat, Feb 27, 2016 at 01:43:05PM +0000, André Mantas wrote:
> > This may be a beginner question but is there a quick way to get a hexdump
> > of an OpenFlow message?
> >
> > Thanks for your help.
> >
> > Ben Pfaff <b...@ovn.org> escreveu no dia sexta, 26/02/2016 às 22:52:
> >
> > > Tests like the ones in ofproto.at, which test functionality, are more
> > > important than the ones in ofp-print.at, which test message decoding
> and
> > > printing, but it's best to have both.
> > >
> > > On Fri, Feb 26, 2016 at 09:57:48PM +0000, André Mantas wrote:
> > > > Ok, makes sense. So I should focus on making similar tests to the
> ones in
> > > > ofproto.at? Or these are also important?
> > > >
> > > > Thanks.
> > > >
> > > > Ben Pfaff <b...@ovn.org> escreveu no dia sexta, 26/02/2016 às 20:35:
> > > >
> > > > > On Fri, Feb 26, 2016 at 08:07:32PM +0000, André Mantas wrote:
> > > > > > I've seen some examples in ofp-print.at, ofproto.at and was
> trying
> > > to
> > > > > > figure them out so I could add more.
> > > > > >
> > > > > > (ofp-print.at)
> > > > > > AT_SETUP([OFPT_BUNDLE_ADD_MESSAGE - PORT_MOD])
> > > > > > AT_KEYWORDS([ofp-print])
> > > > > > AT_CHECK([ovs-ofctl ofp-print "\
> > > > > > 05 22 00 38 00 00 00 03 00 00 00 01 00 00 00 01 \
> > > > > > 05 10 00 28 00 00 00 03 00 00 00 03 00 00 00 00 \
> > > > > > 50 54 00 00 00 01 00 00 00 00 00 01 00 00 00 01 \
> > > > > > 00 00 00 08 00 00 00 01
> > > > > > "], [0], [dnl
> > > > > > OFPT_BUNDLE_ADD_MESSAGE (OF1.4) (xid=0x3):
> > > > > >  bundle_id=0x1 flags=atomic
> > > > > > OFPT_PORT_MOD (OF1.4) (xid=0x3): port: 3: addr:50:54:00:00:00:01
> > > > > >      config: PORT_DOWN
> > > > > >      mask:   PORT_DOWN
> > > > > >      advertise: 10MB-HD
> > > > > > ])
> > > > > >
> > > > > > From ofproto.at I can see that:
> > > > > >
> > > > > > 05 - OpenFlow14 message
> > > > > > 22 - OFPT_BUNDLE_ADD_MESSAGE (?)
> > > > > >
> > > > > > I also tried to search for ovs-ofctl ofp-print syntax or help but
> > > > > couldn't
> > > > > > find it.
> > > > > >
> > > > > > Any help?
> > > > >
> > > > > ofp-print takes a hexdump of an OpenFlow message and prints it on
> > > stdout
> > > > > with ofp_print() from lib/ofp-print.c.  It's there to test
> decoding and
> > > > > printing OpenFlow messages.
> > > > >
> > > > > It's not documented because it's meant for internal testing, not
> as an
> > > > > end user interface.
> > > > >
> > >
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to