Re: [ovs-dev] [link_resets 6/7] netdev-linux: Maintain carrier flag constantly.

2011-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2011 at 02:39:52PM -0700, Ethan Jackson wrote: > > I believe that the following may be simplified to "dev->carrier = > > change->running": > > Yes, I agree. However, in a future patch of the series, I need to > update the carrier_resets sequence number in these if blocks. If you

Re: [ovs-dev] [link_resets 6/7] netdev-linux: Maintain carrier flag constantly.

2011-10-17 Thread Ethan Jackson
> I believe that the following may be simplified to "dev->carrier = > change->running": Yes, I agree. However, in a future patch of the series, I need to update the carrier_resets sequence number in these if blocks. If you like I can change it in this patch, but the final code is going to end up

Re: [ovs-dev] [link_resets 6/7] netdev-linux: Maintain carrier flag constantly.

2011-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2011 at 12:10:23PM -0700, Ethan Jackson wrote: > Before this patch, the carrier of a linux device was only updated > if requested by a caller. This patch updates it whenever it > changes. I believe that the following may be simplified to "dev->carrier = change->running": > +

[ovs-dev] [link_resets 6/7] netdev-linux: Maintain carrier flag constantly.

2011-10-17 Thread Ethan Jackson
Before this patch, the carrier of a linux device was only updated if requested by a caller. This patch updates it whenever it changes. --- lib/netdev-linux.c | 128 +-- 1 files changed, 73 insertions(+), 55 deletions(-) diff --git a/lib/netdev-lin