On Mon, Oct 17, 2011 at 12:10:23PM -0700, Ethan Jackson wrote:
> Before this patch, the carrier of a linux device was only updated
> if requested by a caller.  This patch updates it whenever it
> changes.

I believe that the following may be simplified to "dev->carrier =
change->running":
> +                if (dev->carrier != change->running) {
> +                    dev->carrier = change->running;
> +                }

Same in netdev_linux_cache_cb().

Otherwise this looks good to me.  Thank you.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to