Re: [ovs-dev] [lacp_bugs 2/7] bridge: Configure datapath ID, before LACP.

2011-11-29 Thread Ben Pfaff
On Tue, Nov 29, 2011 at 09:09:57PM -0800, Ethan Jackson wrote: > > For example, bridge_configure_datapath_id() calls > > bridge_pick_local_hw_addr(), which uses > > ofproto_is_mirror_output_bundle(), but the latter will only return a > > correct value after bridge_configure_mirrors(). ?And we can't

Re: [ovs-dev] [lacp_bugs 2/7] bridge: Configure datapath ID, before LACP.

2011-11-29 Thread Ethan Jackson
> For example, bridge_configure_datapath_id() calls > bridge_pick_local_hw_addr(), which uses > ofproto_is_mirror_output_bundle(), but the latter will only return a > correct value after bridge_configure_mirrors().  And we can't move > bridge_configure_mirrors() before the loop that configures the

Re: [ovs-dev] [lacp_bugs 2/7] bridge: Configure datapath ID, before LACP.

2011-11-29 Thread Ben Pfaff
On Tue, Nov 29, 2011 at 07:53:19PM -0800, Ethan Jackson wrote: > The LACP code uses the bridge's datapath ID as it's system ID when > something else hasn't been explicitly configured. Since LACP was > configured before each bridge's datapath ID, the LACP module would > be configured with a datapat

[ovs-dev] [lacp_bugs 2/7] bridge: Configure datapath ID, before LACP.

2011-11-29 Thread Ethan Jackson
The LACP code uses the bridge's datapath ID as it's system ID when something else hasn't been explicitly configured. Since LACP was configured before each bridge's datapath ID, the LACP module would be configured with a datapath ID of zero which broke basic LACP support. Future patches will add t