On Tue, Nov 29, 2011 at 07:53:19PM -0800, Ethan Jackson wrote: > The LACP code uses the bridge's datapath ID as it's system ID when > something else hasn't been explicitly configured. Since LACP was > configured before each bridge's datapath ID, the LACP module would > be configured with a datapath ID of zero which broke basic LACP > support. > > Future patches will add tests which would have caught the issue. > > Bug #8516.
I think that this change will have adverse effects because the current ordering is important. For example, bridge_configure_datapath_id() calls bridge_pick_local_hw_addr(), which uses ofproto_is_mirror_output_bundle(), but the latter will only return a correct value after bridge_configure_mirrors(). And we can't move bridge_configure_mirrors() before the loop that configures the ports, because mirrors are registered with ofproto in terms of the ofbundle handles that are themselves registered with ofproto in that loop. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
