On Tue, Nov 29, 2011 at 09:09:57PM -0800, Ethan Jackson wrote: > > For example, bridge_configure_datapath_id() calls > > bridge_pick_local_hw_addr(), which uses > > ofproto_is_mirror_output_bundle(), but the latter will only return a > > correct value after bridge_configure_mirrors(). ?And we can't move > > bridge_configure_mirrors() before the loop that configures the ports, > > because mirrors are registered with ofproto in terms of the ofbundle > > handles that are themselves registered with ofproto in that loop. > > Wow, this is all a bit fragile.
Absolutely. I've often wondered whether it can be improved, but I haven't thought of a good way yet. > Easy enough to fix for now, I can simply move the lacp down instead of > moving the datapath ID up. Sounds good. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
