Re: [ovs-dev] [RFC PATCH 2/2] TCP flags matching support.

2013-09-24 Thread Ben Pfaff
On Tue, Sep 24, 2013 at 09:22:19PM -0700, Jarno Rajahalme wrote: > > On Sep 24, 2013, at 9:05 PM, Ben Pfaff wrote: > > > On Tue, Sep 24, 2013 at 07:48:55PM -0700, Jarno Rajahalme wrote: > >> > >> On Sep 24, 2013, at 5:10 PM, Ben Pfaff wrote: > >>> On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarn

Re: [ovs-dev] [RFC PATCH 2/2] TCP flags matching support.

2013-09-24 Thread Jarno Rajahalme
On Sep 24, 2013, at 9:05 PM, Ben Pfaff wrote: > On Tue, Sep 24, 2013 at 07:48:55PM -0700, Jarno Rajahalme wrote: >> >> On Sep 24, 2013, at 5:10 PM, Ben Pfaff wrote: >>> On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote: >>> I slightly prefer %# over 0x% in the following cases, be

Re: [ovs-dev] [RFC PATCH 2/2] TCP flags matching support.

2013-09-24 Thread Ben Pfaff
On Tue, Sep 24, 2013 at 07:48:55PM -0700, Jarno Rajahalme wrote: > > On Sep 24, 2013, at 5:10 PM, Ben Pfaff wrote: > > On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote: > > I slightly prefer %# over 0x% in the following cases, because 0 looks > > a little less silly than 0x0: > >

Re: [ovs-dev] [RFC PATCH 2/2] TCP flags matching support.

2013-09-24 Thread Jarno Rajahalme
On Sep 24, 2013, at 5:10 PM, Ben Pfaff wrote: > On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote: >> From ovs-ofctl man page: >> >> tcp_flags=flags/mask >> Bitwise match on TCP flags. The flags and mask are 16-bit >> num??? >> bers written in dec

Re: [ovs-dev] [RFC PATCH 2/2] TCP flags matching support.

2013-09-24 Thread Ben Pfaff
On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote: > From ovs-ofctl man page: > > tcp_flags=flags/mask > Bitwise match on TCP flags. The flags and mask are 16-bit > num??? > bers written in decimal or in hexadecimal prefixed by 0x. Each >

[ovs-dev] [RFC PATCH 2/2] TCP flags matching support.

2013-09-18 Thread Jarno Rajahalme
From ovs-ofctl man page: tcp_flags=flags/mask Bitwise match on TCP flags. The flags and mask are 16-bit num‐ bers written in decimal or in hexadecimal prefixed by 0x. Each 1-bit in mask requires that the corresponding bit in port must