Re: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum

2016-06-06 Thread Alin Serdean
> > >+curNbl = *newNbl; > > >+curNb = NET_BUFFER_LIST_FIRST_NB(curNbl); > > > > The reason we were doing the partial copy earlier is to make sure that > > ETH > > + IP + GRE headers are all in the first MDL. The code access these > > + headers > > assuming they are contiguous in memory. Is

Re: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum

2016-06-06 Thread Ben Pfaff
On Tue, May 31, 2016 at 06:09:05PM +, Nithin Raju wrote: > -Original Message- > From: dev on behalf of Alin Serdean > > Date: Tuesday, May 24, 2016 at 9:14 AM > To: "dev@openvswitch.org" > Subject: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE check

Re: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum

2016-05-31 Thread Nithin Raju
-Original Message- From: dev on behalf of Alin Serdean Date: Tuesday, May 24, 2016 at 9:14 AM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum >@@ -369,11 +383,25 @@ OvsDecapGre(POVS_SWITCH_CONTEXT switchContext, >

Re: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum

2016-05-30 Thread Paul Boca
Looks good to me. Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, May 24, 2016 7:15 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE che

[ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum

2016-05-24 Thread Alin Serdean
This patch introduces GRE checksum computation if the userspace requires it on Tx. On Rx we verify the GRE checksum if the checksum bit was specified and also inform the userspace about it. Also fix the GRE header length as specified by the GRE flags not the tunnel flags. Signed-off-by: Alin Gabr