On Tue, May 31, 2016 at 06:09:05PM +0000, Nithin Raju wrote:
> -----Original Message-----
> From: dev <dev-boun...@openvswitch.org> on behalf of Alin Serdean
> <aserd...@cloudbasesolutions.com>
> Date: Tuesday, May 24, 2016 at 9:14 AM
> To: "dev@openvswitch.org" <dev@openvswitch.org>
> Subject: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum
>
> >@@ -369,11 +383,25 @@ OvsDecapGre(POVS_SWITCH_CONTEXT switchContext,
> > headRoom += 4;
> > }
> >
> >+ /*
> >+ * Create a copy of the NBL so that we have all the headers in one
> >MDL.
> >+ */
> >+ *newNbl = OvsPartialCopyNBL(switchContext, curNbl,
> >+ tunnelSize, 0,
> >+ TRUE /*copy NBL info */);
> >+
> >+ if (*newNbl == NULL) {
> >+ return NDIS_STATUS_RESOURCES;
> >+ }
> >+
> >+ curNbl = *newNbl;
> >+ curNb = NET_BUFFER_LIST_FIRST_NB(curNbl);
>
> The reason we were doing the partial copy earlier is to make sure that ETH
> + IP + GRE headers are all in the first MDL. The code access these headers
> assuming they are contiguous in memory. Is there a good reason to move
> that code down to here?
>
> Looks good otherwise.
Alin, can you comment on this?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
