> > >+ curNbl = *newNbl;
> > >+ curNb = NET_BUFFER_LIST_FIRST_NB(curNbl);
> >
> > The reason we were doing the partial copy earlier is to make sure that
> > ETH
> > + IP + GRE headers are all in the first MDL. The code access these
> > + headers
> > assuming they are contiguous in memory. Is there a good reason to move
> > that code down to here?
[Alin Gabriel Serdean: ] GRE header length is variable. I first need to peek at
the header and validate it before doing the partial copy. I have a bug in this
version because I do not verify the packet length the second time I look at the
GRE flags.
I will send out a V3 in which I'll try to address both problems.
> >
> > Looks good otherwise.
>
> Alin, can you comment on this?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
