Re: [ovs-dev] [PATCH V5 5/5] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-03-20 Thread Ben Pfaff
On Thu, Mar 20, 2014 at 03:39:05PM -0700, Alex Wang wrote: > Thanks for the review, Ben > > > I am confused by upcall_destroy()'s free_upcall parameter: all of the > > callers pass 'false'. > > > > I think I'll remove the input argument 'free_upcall' in upall_destroy(), > since > the array of

Re: [ovs-dev] [PATCH V5 5/5] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-03-20 Thread Alex Wang
Thanks for the review, Ben I am confused by upcall_destroy()'s free_upcall parameter: all of the > callers pass 'false'. I think I'll remove the input argument 'free_upcall' in upall_destroy(), since the array of upcalls is defined as local variable in udpif_upcall_handler(). > > It might n

Re: [ovs-dev] [PATCH V5 5/5] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-03-19 Thread Ben Pfaff
On Wed, Mar 19, 2014 at 01:35:07PM -0700, Alex Wang wrote: > With the foundation laid in previous commits, this commit > removes the 'dispatcher' thread by allowing 'handler' > threads to read upcalls directly from dpif. > > This commit significantly simplifies the flow miss handling > code and br

[ovs-dev] [PATCH V5 5/5] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-03-19 Thread Alex Wang
With the foundation laid in previous commits, this commit removes the 'dispatcher' thread by allowing 'handler' threads to read upcalls directly from dpif. This commit significantly simplifies the flow miss handling code and brings slight improvement to flow setup rate. Note: - the flow setup rat