On Wed, Mar 19, 2014 at 01:35:07PM -0700, Alex Wang wrote: > With the foundation laid in previous commits, this commit > removes the 'dispatcher' thread by allowing 'handler' > threads to read upcalls directly from dpif. > > This commit significantly simplifies the flow miss handling > code and brings slight improvement to flow setup rate. > > Note: > - the flow setup rate improvement is more observable on > top of Jarno's "datapath: Reduce lock contention." > patch series. > > Signed-off-by: Alex Wang <al...@nicira.com>
I am confused by upcall_destroy()'s free_upcall parameter: all of the callers pass 'false'. It might not be worth it to destroy the upcalls one by one as one decides that they're no longer needed. I believe that udpif_upcall_handler() could just destroy all of them, if handle_upcalls() didn't destroy any. I like the simplification. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
