Re: [ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-29 Thread Ben Pfaff
On Thu, Mar 29, 2012 at 01:09:52PM +0900, Simon Horman wrote: > On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote: > > I don't think experimenter stats are actually different in 1.1 and > > 1.2, although the sections are worded differently. > > It seems to me that ofp11_experimenter_stats_

Re: [ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-28 Thread Simon Horman
On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote: [snip] > I don't think experimenter stats are actually different in 1.1 and > 1.2, although the sections are worded differently. It seems to me that ofp11_experimenter_stats_header might look like this: struct ofp11_experimenter_stats_h

Re: [ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-28 Thread Simon Horman
On Wed, Mar 28, 2012 at 05:12:21PM -0700, Ben Pfaff wrote: > Thanks Simon. > > On Thu, Mar 29, 2012 at 09:04:30AM +0900, Simon Horman wrote: > > On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote: > > > I don't think that the ofp12_match structure will really be useful in > > > this form.

Re: [ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-28 Thread Ben Pfaff
Thanks Simon. On Thu, Mar 29, 2012 at 09:04:30AM +0900, Simon Horman wrote: > On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote: > > I don't think that the ofp12_match structure will really be useful in > > this form. If we just defined an "ofp_match_header" that just > > contains length

Re: [ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-28 Thread Simon Horman
On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote: > On Wed, Mar 28, 2012 at 09:44:17AM +0900, Simon Horman wrote: > > This is a first pass at adding include/openflow/openflow-1.2.h to > > include enum and struct definitions for Open Flow 1.2 that > > are not already covered by Open Flow 1.

Re: [ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-28 Thread Ben Pfaff
On Wed, Mar 28, 2012 at 09:44:17AM +0900, Simon Horman wrote: > This is a first pass at adding include/openflow/openflow-1.2.h to > include enum and struct definitions for Open Flow 1.2 that > are not already covered by Open Flow 1.1. > > Signed-off-by: Simon Horman There are still some "uint_t"

[ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

2012-03-27 Thread Simon Horman
This is a first pass at adding include/openflow/openflow-1.2.h to include enum and struct definitions for Open Flow 1.2 that are not already covered by Open Flow 1.1. Signed-off-by: Simon Horman --- v2 As suggested by Ben Pfaff * Use ovs_be{16,32,64} in place of uint_{16,32,64} * Only include i