Re: [ovs-dev] [PATCH 1/3] dpif: Fix NULL dereference fetching non-UFID flow.

2014-12-11 Thread Ben Pfaff
On Thu, Dec 11, 2014 at 03:40:47PM -0800, Joe Stringer wrote: > On 11 December 2014 at 15:09, Ben Pfaff wrote: > > On Thu, Dec 11, 2014 at 02:48:46PM -0800, Joe Stringer wrote: > >> On 11 December 2014 at 14:05, Ben Pfaff wrote: > >> > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote:

Re: [ovs-dev] [PATCH 1/3] dpif: Fix NULL dereference fetching non-UFID flow.

2014-12-11 Thread Ben Pfaff
On Thu, Dec 11, 2014 at 02:48:46PM -0800, Joe Stringer wrote: > On 11 December 2014 at 14:05, Ben Pfaff wrote: > > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote: > >> The UFID parameter to dpif_flow_get() is optional, but the current > >> implementation dereferences it to initialize

Re: [ovs-dev] [PATCH 1/3] dpif: Fix NULL dereference fetching non-UFID flow.

2014-12-11 Thread Joe Stringer
On 11 December 2014 at 15:09, Ben Pfaff wrote: > On Thu, Dec 11, 2014 at 02:48:46PM -0800, Joe Stringer wrote: >> On 11 December 2014 at 14:05, Ben Pfaff wrote: >> > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote: >> >> The UFID parameter to dpif_flow_get() is optional, but the curr

Re: [ovs-dev] [PATCH 1/3] dpif: Fix NULL dereference fetching non-UFID flow.

2014-12-11 Thread Joe Stringer
On 11 December 2014 at 14:05, Ben Pfaff wrote: > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote: >> The UFID parameter to dpif_flow_get() is optional, but the current >> implementation dereferences it to initialize part of the output flow. >> This field is filled in by the dpif imple

Re: [ovs-dev] [PATCH 1/3] dpif: Fix NULL dereference fetching non-UFID flow.

2014-12-11 Thread Ben Pfaff
On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote: > The UFID parameter to dpif_flow_get() is optional, but the current > implementation dereferences it to initialize part of the output flow. > This field is filled in by the dpif implementation, so don't initialize > it here. > > This c

[ovs-dev] [PATCH 1/3] dpif: Fix NULL dereference fetching non-UFID flow.

2014-12-03 Thread Joe Stringer
The UFID parameter to dpif_flow_get() is optional, but the current implementation dereferences it to initialize part of the output flow. This field is filled in by the dpif implementation, so don't initialize it here. This could cause a NULL dereference if a dpif_flow_get() caller doesn't provide