Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Kyle Mestery (kmestery)
On Oct 11, 2012, at 4:52 PM, Pravin Shelar wrote: > On Thu, Oct 11, 2012 at 2:44 PM, Kyle Mestery (kmestery) > wrote: >> On Oct 11, 2012, at 4:32 PM, Pravin Shelar wrote: >>> On Thu, Oct 11, 2012 at 1:52 PM, Kyle Mestery (kmestery) >>> wrote: On Oct 10, 2012, at 6:23 PM, Pravin Shela

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Pravin Shelar
On Thu, Oct 11, 2012 at 2:44 PM, Kyle Mestery (kmestery) wrote: > On Oct 11, 2012, at 4:32 PM, Pravin Shelar wrote: >> On Thu, Oct 11, 2012 at 1:52 PM, Kyle Mestery (kmestery) >> wrote: >>> >>> On Oct 10, 2012, at 6:23 PM, Pravin Shelar wrote: >>> Patch looks good, I have few comments inli

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Kyle Mestery (kmestery)
On Oct 11, 2012, at 4:32 PM, Pravin Shelar wrote: > On Thu, Oct 11, 2012 at 1:52 PM, Kyle Mestery (kmestery) > wrote: >> >> On Oct 10, 2012, at 6:23 PM, Pravin Shelar wrote: >> >>> Patch looks good, I have few comments inlined. >>> >>> >>> On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Pravin Shelar
On Thu, Oct 11, 2012 at 1:52 PM, Kyle Mestery (kmestery) wrote: > > On Oct 10, 2012, at 6:23 PM, Pravin Shelar wrote: > >> Patch looks good, I have few comments inlined. >> >> >> On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote: >>> This is a first pass at providing a tun_key which can be >>>

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Kyle Mestery (kmestery)
On Oct 10, 2012, at 6:23 PM, Pravin Shelar wrote: > Patch looks good, I have few comments inlined. > > > On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote: >> This is a first pass at providing a tun_key which can be >> used as the basis for flow-based tunnelling. The >> tun_key includes and

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Kyle Mestery (kmestery)
On Oct 11, 2012, at 9:32 AM, "Kyle Mestery (kmestery)" wrote: > Thanks for the review, most of this is easy to address > On Oct 10, 2012, at 6:23 PM, Pravin Shelar wrote: > >> Patch looks good, I have few comments inlined. >> >> >> On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote: >>> Thi

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-11 Thread Kyle Mestery (kmestery)
Thanks for the review, most of this is easy to address On Oct 10, 2012, at 6:23 PM, Pravin Shelar wrote: > Patch looks good, I have few comments inlined. > > > On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote: >> This is a first pass at providing a tun_key which can be >> used as the basis

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-10 Thread Chris Wright
* Pravin Shelar (pshe...@nicira.com) wrote: > On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote: > > @@ -458,6 +477,9 @@ int ovs_execute_actions(struct datapath *dp, struct > > sk_buff *skb) > > struct sw_flow_actions *acts = > > rcu_dereference(OVS_CB(skb)->flow->sf_acts); > >

Re: [ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-10 Thread Pravin Shelar
Patch looks good, I have few comments inlined. On Tue, Oct 9, 2012 at 11:49 AM, Kyle Mestery wrote: > This is a first pass at providing a tun_key which can be > used as the basis for flow-based tunnelling. The > tun_key includes and replaces the tun_id in both struct > ovs_skb_cb and struct sw_t

[ovs-dev] [PATCH 1/2] datapath: Add support for tun_key to Open vSwitch datapath

2012-10-09 Thread Kyle Mestery
This is a first pass at providing a tun_key which can be used as the basis for flow-based tunnelling. The tun_key includes and replaces the tun_id in both struct ovs_skb_cb and struct sw_tun_key. This patch allows all existing tun_id behaviour to still work. Existing users of tun_id are redirected