Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-12-16 Thread Jarno Rajahalme
On Dec 16, 2013, at 10:38 PM, Ben Pfaff wrote: > At that point I'll probably find myself looking up my concerns from this > thread, though, to see it any of them have been resolved, since there > was never any discussion. I’ll get to your points before reposting. Jarno _

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-12-16 Thread Jarno Rajahalme
On Dec 16, 2013, at 10:36 PM, Jarno Rajahalme wrote: > Ben, > > I have this series on a branch after these: > > http://patchwork.openvswitch.org/patch/2157/ > http://patchwork.openvswitch.org/patch/2158/ > > Applying the first needs some manual work due to a typo fix in a comment I > made on

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-12-16 Thread Ben Pfaff
On Mon, Dec 16, 2013 at 10:36:00PM -0800, Jarno Rajahalme wrote: > Ben, > > I have this series on a branch after these: > > http://patchwork.openvswitch.org/patch/2157/ > http://patchwork.openvswitch.org/patch/2158/ > > Applying the first needs some manual work due to a typo fix in a comment I

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-12-16 Thread Jarno Rajahalme
Ben, I have this series on a branch after these: http://patchwork.openvswitch.org/patch/2157/ http://patchwork.openvswitch.org/patch/2158/ Applying the first needs some manual work due to a typo fix in a comment I made on the 1/3 of this series you acked earlier. After these two are in, I’ll s

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-12-16 Thread Ben Pfaff
On Mon, Nov 11, 2013 at 09:03:03PM -0800, Ben Pfaff wrote: > On Tue, Nov 12, 2013 at 09:19:59AM +0800, Jesse Gross wrote: > > On Tue, Nov 12, 2013 at 7:53 AM, Ben Pfaff wrote: > > > On Fri, Nov 08, 2013 at 10:54:38AM -0800, Jarno Rajahalme wrote: > > >> Add DPIF-level support for meters. Allow met

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-11-11 Thread Ben Pfaff
On Tue, Nov 12, 2013 at 09:19:59AM +0800, Jesse Gross wrote: > On Tue, Nov 12, 2013 at 7:53 AM, Ben Pfaff wrote: > > On Fri, Nov 08, 2013 at 10:54:38AM -0800, Jarno Rajahalme wrote: > >> Add DPIF-level support for meters. Allow meter_set to modify the meter > >> configuration (e.g. set the burst s

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-11-11 Thread Jesse Gross
On Tue, Nov 12, 2013 at 7:53 AM, Ben Pfaff wrote: > On Fri, Nov 08, 2013 at 10:54:38AM -0800, Jarno Rajahalme wrote: >> Add DPIF-level support for meters. Allow meter_set to modify the meter >> configuration (e.g. set the burst size if unspecified). >> Summary: > > I think we need to get Jesse's v

Re: [ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-11-11 Thread Ben Pfaff
On Fri, Nov 08, 2013 at 10:54:38AM -0800, Jarno Rajahalme wrote: > Add DPIF-level support for meters. Allow meter_set to modify the meter > configuration (e.g. set the burst size if unspecified). > Summary: I think we need to get Jesse's view on the meter stuff. I'll review the userspace API, if

[ovs-dev] [PATCH 06/12] dpif: Meter framework.

2013-11-08 Thread Jarno Rajahalme
Add DPIF-level support for meters. Allow meter_set to modify the meter configuration (e.g. set the burst size if unspecified). Summary: v2: Rebase. Signed-off-by: Jarno Rajahalme --- include/linux/openvswitch.h |3 ++ lib/dpif-linux.c| 40 lib/dpif-netdev.