Re: [ovs-dev] [PATCH 01/12] dpif-netdev: Use cmap instead of hmap.

2014-07-04 Thread Jarno Rajahalme
Thanks for the review :-) Pushed to master with the locking changes you proposed. Jarno On Jul 3, 2014, at 1:48 PM, Ben Pfaff wrote: > On Thu, Jul 03, 2014 at 01:47:38PM -0700, Ben Pfaff wrote: >> On Mon, Jun 30, 2014 at 08:17:17AM -0700, Jarno Rajahalme wrote: >>> This requires less locking

Re: [ovs-dev] [PATCH 01/12] dpif-netdev: Use cmap instead of hmap.

2014-07-03 Thread Ben Pfaff
On Thu, Jul 03, 2014 at 01:47:38PM -0700, Ben Pfaff wrote: > On Mon, Jun 30, 2014 at 08:17:17AM -0700, Jarno Rajahalme wrote: > > This requires less locking and makes lockless classifier use a simpler. > > "a simpler" => "simpler"? > "a simpler" => "possible"? ;-) > > > Signed-off-by: Jarno Rajah

Re: [ovs-dev] [PATCH 01/12] dpif-netdev: Use cmap instead of hmap.

2014-07-03 Thread Ben Pfaff
On Mon, Jun 30, 2014 at 08:17:17AM -0700, Jarno Rajahalme wrote: > This requires less locking and makes lockless classifier use a simpler. "a simpler" => "simpler"? "a simpler" => "possible"? ;-) > Signed-off-by: Jarno Rajahalme I think that, under the new locking rules, dpif_netdev_flow_get()

[ovs-dev] [PATCH 01/12] dpif-netdev: Use cmap instead of hmap.

2014-06-30 Thread Jarno Rajahalme
This requires less locking and makes lockless classifier use a simpler. Signed-off-by: Jarno Rajahalme --- lib/dpif-netdev.c | 51 --- 1 file changed, 24 insertions(+), 27 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index fce