Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-12-11 Thread Ben Pfaff
On Wed, Dec 05, 2012 at 06:01:17PM +0100, Thomas Graf wrote: > On 12/04/2012 08:25 PM, Ben Pfaff wrote: > >It tells a human user that the operation failed. It could also notify > >a script that the operation failed, e.g. if we decided to return a > >nonzero exit status. (ovs-vsctl is intended for

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-12-05 Thread Thomas Graf
On 12/04/2012 08:25 PM, Ben Pfaff wrote: It tells a human user that the operation failed. It could also notify a script that the operation failed, e.g. if we decided to return a nonzero exit status. (ovs-vsctl is intended for use by both humans and programs.) I'm perfectly willing to add anoth

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-12-04 Thread Ben Pfaff
On Thu, Nov 29, 2012 at 07:53:10PM +0100, Thomas Graf wrote: > On 11/29/2012 06:23 PM, Ben Pfaff wrote: > >It's better in that it would simply report whether the port was > >successfully added in an unambiguous fashion, instead of shipping > >possibly a lot of possibly irrelevant log data to the us

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-11-29 Thread Thomas Graf
On 11/29/2012 06:23 PM, Ben Pfaff wrote: It's better in that it would simply report whether the port was successfully added in an unambiguous fashion, instead of shipping possibly a lot of possibly irrelevant log data to the user, often regardless of whether the port was added successfully or not

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-11-29 Thread Ben Pfaff
On Thu, Nov 29, 2012 at 06:01:09PM +0100, Thomas Graf wrote: > On 11/29/2012 05:53 PM, Ben Pfaff wrote: > >This is different from the approach that we discussed earlier in the > >"ovs-vsctl: check if the device name is valid" thread in late October > >and early November. Here's what I wrote at the

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-11-29 Thread Thomas Graf
On 11/29/2012 05:53 PM, Ben Pfaff wrote: This is different from the approach that we discussed earlier in the "ovs-vsctl: check if the device name is valid" thread in late October and early November. Here's what I wrote at the time: Stepping back: I support your basic proposal, that "ovs-vsctl

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-11-29 Thread Ben Pfaff
On Thu, Nov 29, 2012 at 05:31:35PM +0100, Thomas Graf wrote: > This patchset attempts to address the missing feedback channel when > database changes performed by ovs-vsctl lead to configuration errors > when ovs-vswitchd reconfigures. This is different from the approach that we discussed earlier

[ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-11-29 Thread Thomas Graf
Hi This patchset attempts to address the missing feedback channel when database changes performed by ovs-vsctl lead to configuration errors when ovs-vswitchd reconfigures. I chose to also include INFO messages for now but it is certainly an option to limit it to WARN and ERROR. Example: $ sudo o