On Thu, Nov 29, 2012 at 05:31:35PM +0100, Thomas Graf wrote: > This patchset attempts to address the missing feedback channel when > database changes performed by ovs-vsctl lead to configuration errors > when ovs-vswitchd reconfigures.
This is different from the approach that we discussed earlier in the "ovs-vsctl: check if the device name is valid" thread in late October and early November. Here's what I wrote at the time: > Stepping back: I support your basic proposal, that "ovs-vsctl > add-port" should report a problem if the port cannot successfully be > added. The issue is that, so far, the approaches I've seen don't fit > well with the overall Open vSwitch design. Here is another approach > that fits better: make "ovs-vsctl add-port" check the value that > ovs-vswitchd assigns to the "ofport" column in the new Interface > record. When a port is added successfully, this column receives a > positive integer value; when adding a port fails, it receives the > value -1. I'd accept a patch to do this. I still think that's a good approach, probably better than the approach in this series of patches. What's the reason for this change of approach? Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
