Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-23 Thread Ben Pfaff
On Fri, Jun 10, 2016 at 12:17:57PM -0400, Lance Richardson wrote: > Commit f9b11f2a09b4 introduced a loop to wait for process exit > in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent. > Unfortunately, this does not work for cases where a unixctl socket > has to be used to send the "ex

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Lance Richardson
- Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Friday, June 10, 2016 12:17:57 PM > Subject: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > Apologies, I f

[ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Lance Richardson
Commit f9b11f2a09b4 introduced a loop to wait for process exit in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent. Unfortunately, this does not work for cases where a unixctl socket has to be used to send the "exit" command because the process ID cannot be determined from the socket pa

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Friday, June 10, 2016 11:16:08 AM > Subject: Re: [ovs-dev] [PATCH] tests: fix issue in use of > OVS_APP_EXIT_AND_WAIT > > On Fri, Jun 03, 2016

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Ben Pfaff
On Tue, Jun 07, 2016 at 12:52:37AM +, Alin Serdean wrote: > On Windows: > ## -- ## > ## openvswitch 2.5.90 test suite. ## > ## -- ## > 1747. ovsdb-monitor.at:47: testing monitor insert into empty table ... > ./ovsdb-monitor.at:47: ovsdb-to

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Ben Pfaff
On Thu, Jun 09, 2016 at 06:34:51PM -0400, Lance Richardson wrote: > Hi Ben, > > Regarding https://patchwork.ozlabs.org/patch/630046/ : > > I see that this patch is marked "changes requested" in patchwork. I > believe this is due to Alin's request (below). > > I'm having trouble understanding how

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Ben Pfaff
On Fri, Jun 03, 2016 at 06:09:26PM -0400, Lance Richardson wrote: > Commit f9b11f2a09b4 introduced a loop to wait for process exit > in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent. > Unfortunately, this does not work for cases where a unixctl socket > has to be used to send the "ex

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Lance Richardson
- Original Message - > From: "Paul Boca" > To: "Lance Richardson" > Cc: dev@openvswitch.org, "Alin Serdean" , > "Ben Pfaff" > Sent: Friday, June 10, 2016 4:16:15 AM > Subject: RE: [ovs-dev] [PATCH] tests: fix issue in use of &g

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-10 Thread Paul Boca
ut has unresolved run-time linkage > issues on win7. > > Do you have any suggestions for moving forward? > > Thanks, > > Lance > > - Original Message - > > From: "Lance Richardson" > > To: "Alin Serdean" > > Cc: dev@

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-09 Thread Lance Richardson
> From: "Lance Richardson" > To: "Alin Serdean" > Cc: dev@openvswitch.org, "Paul Boca" > Sent: Tuesday, June 7, 2016 10:40:46 AM > Subject: Re: [ovs-dev] [PATCH] tests: fix issue in use of > OVS_APP_EXIT_AND_WAIT > > - Original Mess

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-07 Thread Lance Richardson
- Original Message - > From: "Alin Serdean" > To: "Lance Richardson" , dev@openvswitch.org > Cc: "Paul Boca" > Sent: Monday, June 6, 2016 8:52:37 PM > Subject: RE: [ovs-dev] [PATCH] tests: fix issue in use of > OVS_APP_EXIT_AND_WAIT >

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-06 Thread Alin Serdean
Hi Lance, Thanks a lot for the patch just one small nit on the windows side, please see inlined comment. Thanks, Alin. > diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at index > e5710a0..fadd2be 100644 > --- a/tests/ovs-macros.at > +++ b/tests/ovs-macros.at > @@ -132,20 +132,22 @@ m4_defi

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-06 Thread Lance Richardson
- Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Friday, June 3, 2016 6:09:26 PM > Subject: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > Commit f9b11f2a09b4 introduced a loop to wait for process exi

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-06 Thread Paul Boca
Subject: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > Commit f9b11f2a09b4 introduced a loop to wait for process exit > in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent. > Unfortunately, this does not work for cases where a unixctl s

[ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-03 Thread Lance Richardson
Commit f9b11f2a09b4 introduced a loop to wait for process exit in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent. Unfortunately, this does not work for cases where a unixctl socket has to be used to send the "exit" command because the process ID cannot be determined from the socket pa